[SOLVED] Groovy to Linux variable

flukeyLinux · 09-10-2019, 04:13 AM

Hello all,
I'm struggling to convert a groovy variable to use in a bash command. Any help would be great. Can anyone see what I am doing wrong?

def teamname = "${loweritam}"
sh '''
appteam="""$teamname-REL"""
team=ap123456
echo $appteam $team
'''
Output:
+ appteam=-REL
+ team=ap123456
+ echo -REL ap123456
-REL ap123456

appteam should look like - 12345tr-REL
I've tried using single quotes like so: appteam='''+teamname+'-REL''''

but that does not work for me either.

thanks,
Fluke

scasey · 09-10-2019, 04:22 AM

Spaces around the equal?

Code:

teamname = "${loweritam}"

flukeyLinux · 09-10-2019, 04:54 AM

Quote:

Originally Posted by scasey

Spaces around the equal?

Code:

teamname = "${loweritam}"

Do you mean remove the spaces around the =?
def teamname="${loweritam}"

just tried it there but no difference. I think the issue must be in the quotes in the shell part. but I've tried combinations and I can't get it to work.

This worked for me before:
def teamname = "${loweritam}"
sh '''
./cli create-folder '''+teamname+'-REL''''
'''

So the issue must be with setting it as a variable (appteam="""$teamname-REL""")

flukeyLinux · 09-10-2019, 05:06 AM

Quote:

Originally Posted by flukeyLinux

Do you mean remove the spaces around the =?
def teamname="${loweritam}"

just tried it there but no difference. I think the issue must be in the quotes in the shell part. but I've tried combinations and I can't get it to work.

This worked for me before:
def teamname = "${loweritam}"
sh '''
./cli create-folder '''+teamname+'-REL''''
'''

So the issue must be with setting it as a variable (appteam="""$teamname-REL""")

Having just said the last line, I realized I don't really need to set vars in the shell. So I have removed them and tried the following:

sed -i "s/placeteamhere/'''+teamname+'-REL''''/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'''+teamname+''''/ create-job $appteam

Which resulted in 'script.sh: line 5: syntax error: unterminated quoted string'

Could just be a missing extra single quote. Does anyone know the meaning of the quotes and why there are 3 at the start but 4 or 5 at the end?

NevemTeve · 09-10-2019, 05:21 AM

Kindly use [code] and [/code] tags when quoting code.

Do you wish to execute shell command within your program, or you wish to set a shell-variable, after your program terminated?

The latter is not possible, but there is a well known substitution: the program writes a shell command onto the standard output.

Example:

Code:

$ resize -s
COLUMNS=136;
LINES=35;
export COLUMNS LINES;
$ eval $(resize -s)
$ echo $COLUMNS $LINES
136 35 # the new values

flukeyLinux · 09-10-2019, 05:49 AM

Quote:

Originally Posted by NevemTeve

Kindley use [code] and [/code] tags when quoting code.

Do you wish to execute shell command within your program, or you wish to set a shell-variable, after your program terminated?

The latter is not possible, but there is a well known substitution: the program writes a shell command onto the standard output.

Example:

Code:

$ resize -s
COLUMNS=136;
LINES=35;
export COLUMNS LINES;
$ eval $(resize -s)
$ echo $COLUMNS $LINES
136 35 # the new values

ok thanks. I'm not sure this is related. But I think the answer to this question will help me:

Code:

echo '''+teamname+'-REL''''
                      echo '''+teamname+'''''

The first echo works, the second does not.

Firerat · 09-10-2019, 06:16 AM

Quote:

Originally Posted by flukeyLinux

Having just said the last line, I realized I don't really need to set vars in the shell. So I have removed them and tried the following:

Code:

sed -i "s/placeteamhere/'''+teamname+'-REL''''/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'''+teamname+''''/ create-job $appteam

Which resulted in 'script.sh: line 5: syntax error: unterminated quoted string'

Could just be a missing extra single quote. Does anyone know the meaning of the quotes and why there are 3 at the start but 4 or 5 at the end?

I don't know groovy

Code:

'
sh '''sed -i "s/placeteamhere/'''+teamname+'''-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'''+teamname+'''/ create-job $appteam
'''
'

''' groovy is protecting the middle '
'some protected things'this bit groovy expands ' again this is hardcoded'

anything inside ' ' is protected from the interpreter, outside the interpreter interperates

so above Magenta and the result of bold is passed the OS

so you would be passing

Code:

sh 'sed -i "s/placeteamhere/'+teamname+'-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'+teamname+'/ create-job $appteam'

I don't think that is correct

Code:

'
sh '''sed -i "s/placeteamhere/'+teamname+'-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'+teamname+'/ create-job $appteam'''
'

should pass

Code:

sh 'sed -i "s/placeteamhere/valueofteamname-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-valueofteamname/ create-job $appteam'

I've only tested that in my head, so no idea if it will actually work
I used to do things like that with python and awk, a long time ago.

I have turned a blind eye to the UUOC

flukeyLinux · 09-10-2019, 06:28 AM

Quote:

Originally Posted by Firerat

I don't know groovy

Code:

'
sh '''sed -i "s/placeteamhere/'''+teamname+'''-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'''+teamname+'''/ create-job $appteam
'''
'

''' groovy is protecting the middle '
'some protected things'this bit groovy expands ' again this is hardcoded'

anything inside ' ' is protected from the interpreter, outside the interpreter interperates

so above Magenta and the result of bold is passed the OS

so you would be passing

Code:

sh 'sed -i "s/placeteamhere/'+teamname+'-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'+teamname+'/ create-job $appteam'

I don't think that is correct

Code:

'
sh '''sed -i "s/placeteamhere/'+teamname+'-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-'+teamname+'/ create-job $appteam'''
'

should pass

Code:

sh 'sed -i "s/placeteamhere/valueofteamname-REL/g" templates/config.xml
/bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-valueofteamname/ create-job $appteam'

I've only tested that in my head, so no idea if it will actually work
I used to do things like that with python and awk, a long time ago.

I have turned a blind eye to the UUOC

This is helpful and I'll test it out. I've been going around in circles for a while. In a bid to get away from using so many single quotes, I tried the following:

Code:

                    def teamname="${loweritam}"
                    sh '''
                      echo '''+teamname+'-REL'''' > rel
                      loweritamREL=$(cat rel)
                      loweritam=${loweritamREL::-4}
                      sed -i "s/placeteamhere/$loweritamREL/g" templates/config.xml
                      /bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-$loweritam/ create-job $loweritamREL
                      '''

But for some reason the simple redirect wont work.

Code:

                      java.lang.NullPointerException: Cannot get property ' > rel
                      loweritamREL=$(cat rel)
                      loweritam=${loweritamREL::-4}
                      sed -i "s/placeteamhere/$loweritamREL/g" templates/config.xml
                      /bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-$loweritam/ create-job $loweritamREL
                      ' on null object

Firerat · 09-10-2019, 06:34 AM

Code:

echo '''+teamname+'-REL'''' > rel

would pass

Code:

#echo '+teamname+'-REL'' > rel
# correction ?
echo '+teamname+-REL' > rel

Edit actually, it wouldn't
I don't know what groovy would do with -REL
it could be it breaks the whole thing so nothing is passed
ahh, yeah..

Quote:

java.lang.NullPointerException: Cannot get property ' > rel

Code:

echo ''''+teamname+'-REL''' > rel

would pass

Code:

echo 'valueofteamname-REL' > rel

BW-userx · 09-10-2019, 06:41 AM

running external commands in a different lang (Groovy)
It looks to me you're wanting to run sed command in Groovy , again I do not know Groovy either.
https://community.smartbear.com/t5/S...vy/td-p/116735

https://stackoverflow.com/questions/...in-java-groovy

https://www.rosettacode.org/wiki/Exe...system_command

NevemTeve · 09-10-2019, 06:49 AM

@OP: Could you please quote a complete minimal example that shows the problem? (If it is not solved yet.)

flukeyLinux · 09-10-2019, 07:52 AM

Quote:

Originally Posted by NevemTeve

@OP: Could you please quote a complete minimal example that shows the problem? (If it is not solved yet.)

Hey. Sure, here is the relevant code:

Code:

                    def teamname="${loweritam}"
                    sh '''
                      echo '''+teamname+'-REL'''' > rel
                      loweritamREL=$(cat rel)
                      loweritam=${loweritamREL::-4}
                      sed -i "s/placeteamhere/$loweritamREL/g" templates/config.xml
                      /bin/cat templates/config.xml | ./cli -s https://jenkinscore.com/teams-$loweritam/ create-job $loweritamREL
                      '''

{loweritam} is a parameter that is added by a user. something like jenkins-123456. What I want to do is when a user creates a jenkins team, they get two folders by default.

If I do

Code:

 echo '''+teamname+'-REL''''

I get exactly what I want. jenkins-123456-REL. But for some reason '''+teamname+''''' doesn't work and redirecting

Code:

echo '''+teamname+'-REL''''

to a file doesn't work.

Firerat · 09-10-2019, 08:06 AM

see post 9

flukeyLinux · 09-10-2019, 08:07 AM

Code:

echo ''''+teamname+'-REL''' > rel

would pass

Code:

echo 'valueofteamname-REL' > rel

[/QUOTE]

Tried this but no joy either. The echo comes back blank.

Firerat · 09-10-2019, 08:17 AM

Quote:

Originally Posted by flukeyLinux

Code:

echo ''''+teamname+'-REL''' > rel

would pass

Code:

echo 'valueofteamname-REL' > rel

Tried this but no joy either. The echo comes back blank.[/QUOTE]

post the whole section of code
even if ( I assume java now ) didn't concatenate +teamname+ into the sting the echo should have -REL