[SOLVED] For loop iterating endlessly

jmgibson1981 · 01-31-2023, 03:29 PM

They've got me doing tic tac toe now. It works save the winner check. The for loop goes endlessly. I'm calling the for loop with all variables.

I've tested the variables are getting passed via printf statements. It just keeps looping till I stop it. Thank you in advance for any assistance.

Code:

void winner_check_launch(char gameboard[], char player)
{
    // horizontals
    winner_check(gameboard, player, 1, 3, 1);
    // verticals
    winner_check(gameboard, player, 1, 7, 3);
    // diagonals(
    winner_check(gameboard, player, 1, 9, 4);
    winner_check(gameboard, player, 3, 2, 7);
}

void winner_check(char gameboard[], char player, int ctr1, int ctr2, int ctr3) {
    int counter = 0;
    for (int i = ctr1; i <= ctr2; i + ctr3) {
        if (gameboard[i] == player) {
            counter += 1;
        }
    }
    if (counter == 3) {
        printf("%c wins! game over and thank you for playing\n", player);
        exit(0);
    }
}

Full source I'm on now. https://gitlab.com/jmgibson1981/mycp...0-%2068/main.c

NevemTeve · 01-31-2023, 04:10 PM

Code:

Before: for (int i = ctr1; i <= ctr2; i + ctr3) {
After:  for (int i = ctr1; i <= ctr2; i += ctr3) {

jmgibson1981 · 01-31-2023, 04:21 PM

Thank you so much. Always the small things. I was wondering why the compiler was saying "warning statement with no effect" (codeblocks).

ntubski · 01-31-2023, 09:53 PM

By the way, I would also suggest some renaming, e.g.

Code:

for (int i = start; i <= end; i += step) {

jmgibson1981 · 02-01-2023, 09:37 AM

Good point. Thank you as well.