Checking of Input in Roman Program

gregarion · 04-11-2010, 11:02 AM

Hey guys for my assignment i have to write a program which checks the information inside a text file to make sure it is all integers and then convert the integers to roman Numerals. My program seems to have a bit of a problem and im not sure where exactly the problem is....

Code:

#include<stdlib.h>
#include<string>
#include<iostream>
#include<fstream>

using namespace std ;

class checkfile
{
public :
bool is_number (string& );
   private :

};

class Convert
{
public :
    void ConvertToRoman (string& );
private :
};



////cpp file to check for number/////
bool checkfile::is_number(string&s)
{
   for (int i = 0; i < s.length(); i++) {
       if (!isdigit(s[i]))
           return false;       
  }
   return true;
}

/////cpp.file convert numbers to roman Numerals///
void Convert::ConvertToRoman(string& ArabicNumber)
{
     int h,th,t,o,number;
  string roman ;
  number = atoi (ArabicNumber.c_str());
  int number2 = 0;
  int test1 = 0;
  int test2 = 0;
  int test3 = 0;
        char *ones[] = {"","I","II","III","IV","V","VI","VII","VIII","IX"};
        char *tens[] = {"","X","XX","XXX","XL","L","LX","LXX","LXXX","XC"};
        char *hundreds[] = {"","C","CC","CCC","CD","D","DC","DCC","DCCC","CM"};
     number2 = number / 1000;
for(int i = 1; i <= number2; i++)
cout << 'M' ;
     test1 = number % 1000;
            h = test1 / 100;
             test2 = test1 % 100; 
            t = test2 / 10 ;
             test3 = test2 % 10;
            o = test3 / 1;
            roman  = roman +  hundreds[h] + tens[t] + ones[o];
  cout << roman << endl ;

}

///////main////
using namespace std;
int main() {

    string num ;
     checkfile ck ;
          Convert cv;
 
    cout << "Enter the text file please ";
	cin >> num ;
        ck.FileCheck(num);
    if (ck.FileCheck(num) == 1)
        {
            cout << "File is open"<< endl ;
        }
       else
        {
            cout << "File not found" << endl;
       }
      fstream readFile("Test.txt");
       string Numeral ;       
while (getline(readFile,Numeral))
{
    if (Numeral != " "){
        ck.is_number(Numeral);  
    }   
    if (ck.is_number(Numeral)){     
        cv.ConvertToRoman(Numeral);
    }
    else {
        cout << "it has alphabets" << endl;
    }
}
      }

The probem i am facing is when my text file has only one line of information inside it....

123

THe program works fine. It is able to check if the string is just all numbers or has some alphabets. After checking, it will the pass the input into the other function to convert it to Roman Numeral. Thus, the output will be....

CXX111

which is correct. But when my text file has data in this way...

122
123

For some reason, it will not work fine. In fact, the output will be...

it has alphabets
CXX111

From the input, you realize that the program seems to read the first input wrongly and only read the 2nd one properly.

To check for mistakes, i took out the function to check for integers and just run it throught the function to convert the input into Roman numerals. In this case. the program worked and i get the correct output which is...

CXX11
CXX111

So i guess the problem might lie in the way the checking for integer function pass back the input into the main and into the other functions. Im very sure the functions are working properly. So i guess it has something to do with the way the information is passed? If anybody has any idea bout this, please tell me how i can solve this issue.

pixellany · 04-11-2010, 11:10 AM

CXX111---that is not correct for Roman numerals

Should be:
CXXIII

gregarion · 04-11-2010, 12:52 PM

sorry i meant III.

gregarion · 04-11-2010, 12:56 PM

Quote:

int checkfile::FileCheck(string& num)
{
string num2 ;
int num3 ;
num2 = num + ".txt";

const char* pszConstString = num2.c_str ();

fstream checkfile( pszConstString) ;

if (checkfile.is_open())
{
num = '1';
}
else
{
num = '0';

}

}

Sorry, i missed posting that. this is my function for the checkfile::FileCheck.

Tinkster · 04-11-2010, 01:06 PM

How did you get that to compile is what I wonder?
Even with the function added (which I only saw after I
posted this post).

gregarion · 04-11-2010, 03:04 PM

There will errors but it will compile and run. I am using Netbeans 6.8.

Tinkster · 04-11-2010, 03:35 PM

No it won't because checkfile::FileCheck isn't known to the class
in the state it's in above.

I added the missing declaration here, it compiles with warnings,
and runs. As expected, may I add (if we disregard the attempt to
read a file-name and use the hard-coded Test.txt).

Cheers,
Tink

grail · 04-11-2010, 07:28 PM

Instead of answers, I actually have 2 questions (as this is (I think) the third time I have seen this similar code):

1. And this one is perhaps personal, but as you are learning this language, have you not been told about formatting?
I am not trying to be harsh, but I have notice that others have commented also about how difficult you code is to read / follow
due to lack of indentation or misaligned braces (small example)

Quote:

int checkfile::FileCheck(string& num)
{
string num2 ;
int num3 ;
num2 = num + ".txt";

const char* pszConstString = num2.c_str ();

fstream checkfile( pszConstString) ;

if (checkfile.is_open())
{
num = '1';
}
else
{
num = '0';

}

}

Compared to:

Code:

int checkfile::FileCheck(string& num)
{
    string num2 ;
    int num3 ;
    num2 = num + ".txt";

    const char* pszConstString = num2.c_str ();


    fstream checkfile( pszConstString) ;

    if (checkfile.is_open())
    {
        num = '1';
    }
    else
    {
        num = '0';
    }
}

Now you can easily line up your braces to know which test / loop is being involved with the necessary lines
and by indenting the statements inside the braces it is clearer as to what is happening.

2. Why do you process the same function twice throughout the program:

Code:

ck.FileCheck(num);
if (ck.FileCheck(num) == 1)

//and

if (Numeral != " "){
    ck.is_number(Numeral);  
}   
if (ck.is_number(Numeral)){

Both the call to FileCheck and is_number are called twice. The first is superfluous as you are not assigning the output
to anything.

I hope some of this helps, again you can take query 1 or not but the second is worth noting.

graemef · 04-12-2010, 03:42 AM

I've not read your code but I have a question for you...

Does your first line include a return character and if so is it being checked?