Bash Shell Script Help Please

justmy2cents · 05-12-2017, 03:22 PM

Code:

#!/bin/bash
#Standard Operating Environment Setup Script
1 rfkill block 0pyth0
2 apt-get --purge remove thunderbird pidgin parole bluetooth 
3 adduser xubuntu1 && adduser xubuntu1 sudo
4 userdel xubuntu
5 cp -r /media/xubuntu/88D3-A937/Packages /home/xubuntu1 ; cp -r /media/xubuntu/88D3-A937/Config /home/xubuntu1 
6 mv /home/xubuntu1/Config/.* /home/xubuntu1
7 dpkg -i /home/xubuntu1/Packages/*.deb 
8 macchanger -A wlp6s0
9 cp -r /home/xubuntu1/oh-my-zsh /home/xubuntu1/.zshrc /root/
10 chsh ; chsh xubuntu1 
11 chmod go-rx /home/*
12 chmod go-r /etc/group
13 find / -perm -4000 -print -execdir chmod go-x {} \; 
14 chmod go+x /bin/su /usr/bin/sudo
15 passwd
16 echo -e "Do you wish to login as another user? [Y/n]"
17 read choice
18 if [ $choice == "Y" ]
19 then killall xfce4-session
20 else service lightdm restart
21 fi

justmy2cents · 05-12-2017, 03:25 PM

Can anyone please explain why in line 4 it doesn't delete the user xubuntu (note that i'm executing this as root).

astrogeek · 05-12-2017, 03:37 PM

Welcome to LQ!

Does the script produce any messages when run providing clues to the reason the user was not deleted?

As usual, I would suggest reading the man page for userdel, but this is important:

Code:

man userdel

...
CAVEATS
       userdel will not allow you to remove an account if there are running processes which belong to this
       account. In that case, you may have to kill those processes or lock the user's password or account and
       remove the account later.

justmy2cents · 05-12-2017, 03:44 PM

Hi Astro thank you, yeah I just figured out that "xubuntu is currently being used by a process". Thanks!!

dugan · 05-12-2017, 03:45 PM

Start with script with "set -e" so that it exits when anything errors.

justmy2cents · 05-12-2017, 03:47 PM

Quote:

Originally Posted by dugan

Start with script with "set -e" so that it exits when anything errors.

Awesome tip, I'll start doing that to debug my scripts, thanks

justmy2cents · 05-12-2017, 03:51 PM

Also guys I wanted to use a sed command in my script to change %sudo ALL=(ALL:ALL) ALL to %sudo ALL=(root) /usr/bin/apt-get

But I don't know how to do this cus im a noob in sed.. Any advice?

BW-userx · 05-12-2017, 08:25 PM

playing with the sudo file... hum

Code:

sed -i -e 's/%sudo ALL=(ALL:ALL) ALL/%sudo ALL=(root) /usr/bin/apt-get/g' /etc/sudoers

BW-userx · 05-12-2017, 08:30 PM

Line 16-17 can be changed to one line

Code:

read -p "Do you wish to login as another user? [Y/n]" choice

make it so that it does not matter if lowercase or upper case 'y'

Code:

userx%voider ⚡ scripts ⚡> choice="y"
userx%voider ⚡ scripts ⚡> [[ ${choice^^} == 'Y' ]] && echo "hi $choice"
hi y
userx%voider ⚡ scripts ⚡>

that changes lower case to upper case. seen as error preventing in case they forget to hit the shift key to upper case the y.

you can also default assign choice='Y' Because in most scripts standard syntax for Y/n is Y = default setting.

ondoho · 05-13-2017, 03:51 AM

Quote:

Originally Posted by justmy2cents

Also guys I wanted to use a sed command in my script to change %sudo ALL=(ALL:ALL) ALL to %sudo ALL=(root) /usr/bin/apt-get

am i right to assume that you want to automate the editing of /etc/sudoers? being a confessed noob? you know that a broken sudoers means no sudo? are you sure this is a good idea? i'm not...
anyhow, other people have things to say about that:
https://stackoverflow.com/questions/...-from-a-script
i suggest you read most of it, incl. comments, before continuing.

pan64 · 05-13-2017, 04:03 AM

I have no idea if user xubuntu really exists.

justmy2cents · 05-15-2017, 11:05 AM

Code:

#!/bin/bash
#Standard Operating Environment Setup Script
1 rfkill block 0pyth0
2 apt-get --purge remove thunderbird pidgin parole bluetooth
3 adduser xubuntu1 && adduser xubuntu1 sudo
4 userdel -f xubuntu
5 chmod u+w /etc/sudoers
6 sed 's/%sudo   ALL=(ALL:ALL) ALL/%sudo   ALL=(root) \/usr\/bin\/apt-get \/usr\/bin\/dpkg/i' /etc/sudoers > ~/sudo
7 mv ~/sudo /etc/sudoers
8 chmod u-w /etc/sudoers
9 cp -r /media/xubuntu/88D3-A937/Config/.* /home/xubuntu1
10 ^/home/xubuntu1^/root
11 chown xubuntu1 .vimrc ; chgrp xubuntu1 .vimrc
12 find /home/xubuntu1 -uid 0 -execdir rm -rf {} \;
13 cp -r /media/xubuntu/88D3-A937/Packages/*.deb /root/.cache
14 dpkg -i /root/.cache/*.deb
15 macchanger -A wlp6s0
16 chsh ; chsh xubuntu1
17 chmod go-rx /home/*
18 chmod go-r /etc/group
19 find / -perm -4000 -execdir chmod go-x {} \;
20 chmod go+x /bin/su /usr/bin/sudo
21 passwd
22 read -p "Do you wish to login as another user? [Y/n]:" choice
23 if [ $choice = "Y" ]
24    then killall xfce4-session
25    elif [ $choice = "n" ]
26    then sed 's/0/1/' /etc/lightdm/lightdm.conf > ~/light ; mv ~/light /etc/lightdm/lightdm.conf ; \  
27    sed 's/xubuntu/xubuntu1/' /etc/lightdm/lightdm.conf > ~/light ; mv ~/light /etc/lightdm/lightdm.conf ; \
28    service lightdm restart
29    else echo "Invalid Option: `echo $choice`, please select [Y/n]:" 
30 fi
31 until [[ $choice == "Y" || $choice == "n" ]]  
32 do
33 read -p "Invalid Option: `echo $choice`, please select [Y/n]:" choice
34 done

BW-userx · 05-15-2017, 11:14 AM

is that you just sharing?

justmy2cents · 05-15-2017, 11:19 AM

Hello ladies and gentlemen, can anyone tell me why sed in line 7 works on everything besides in the /etc/sudoers file? (e.g. I can make a file with %sudo All=(ALL:ALL) ALL; and it will change that, but it wont do it for /etc/sudoers). Also why in line 10 wont it modify line 9's command.. And one last thing, am I using the until loop correctly?

justmy2cents · 05-15-2017, 11:21 AM

Quote:

Originally Posted by BW-userx

Line 16-17 can be changed to one line

Code:

read -p "Do you wish to login as another user? [Y/n]" choice

make it so that it does not matter if lowercase or upper case 'y'

Code:

userx%voider ⚡ scripts ⚡> choice="y"
userx%voider ⚡ scripts ⚡> [[ ${choice^^} == 'Y' ]] && echo "hi $choice"
hi y
userx%voider ⚡ scripts ⚡>

that changes lower case to upper case. seen as error preventing in case they forget to hit the shift key to upper case the y.

you can also default assign choice='Y' Because in most scripts standard syntax for Y/n is Y = default setting.

I decided to use a loop instead so that they have to enter the characters as specified