i have the following script i am writing to convert and move some files after an upload...
The first part of renaming the files works ok but then it does not get to the conversion part
can anyone point out what i am missing?

tia

#!/bin/bash
#####################################################################
# setup variables
#####################################################################
IMAGEDIR='/home/image/convert'
DATE=`date +%m-%d`
JPG='/usr/local/apache/htdocs/imagegallery/admin/mainimages/tmp/'
TIF='/usr/local/apache/htdocs/imagegallery/admin/mainimages/'
ERRORS='/tmp/errors'
LIST='/tmp/list'
RESULTS='/tmp/results'
CONVERTED='/tmp/converted'
#####################################################################
# Convert files and log actions
#####################################################################
#
# Create three files - error, list and results.
#
# list = file listing of all files converted that day (size and name)
# errors = errors generated by conversion
# converted = output of file conversion
# results = results or errors of the conversion process
#
#
#####################################################################
cd ${IMAGEDIR}
# Rename files with spaces - replace the spaces with a _
#
find ${IMAGEDIR} -name '* *' -type f | sort | while read FILE
do
NEWFILE=`dirname "${FILE}"`/`basename "${FILE}" | sed 's/ /_/g;'`
mv "${FILE}" "${NEWFILE}"
#
# Populate list of files > generated each time and cleaned out at the end of the daily script
ls -lh ${IMAGEDIR} | awk ' { print $9 " " $5 } '>>$LIST
#
for files in ${IMAGEDIR}
do
(
echo converting ${files} >>$CONVERTED
#
# echo output from conversion to converted log file/convert the files/move the files and set permissions
#
echo "convert ${files} -resize 800x600 -colorspace rgb ${files}.jpg >>$CONVERTED 2>&1"
#
# mv files to web space and set permissions (echo put in for testing)
#
echo "mv ${files} ${TIF}${files}_${DATE}.tif"
echo "mv ${files}.jpg ${JPG}${files}_${DATE}.jpg"
echo "cd ${TIF}"
echo "chown nobody:nobody *.tif"
echo "chmod 664 *.tif"
echo "cd ${JPG}"
echo "chown nobody:nobody *.jpg"
echo "chmod 664 *.jpg"
)
done
#
# Generate Result section (Part 4)
#
#
cat $CONVERTED |egrep "converting|error" >>$RESULTS
#
# Generate Errror section (Part 5)
#
cat $RESULTS |egrep "error|delegate" |awk ' { print $ 2 }' >>$ERRORS
#
cat /dev/null >$CONVERTED
cat /dev/null >$LOGFILE

You do realise that doing:
echo "mv ${files} ${TIF}${files}_${DATE}.tif"
echo "mv ${files}.jpg ${JPG}${files}_${DATE}.jpg"
echo "cd ${TIF}"
echo "chown nobody:nobody *.tif"
echo "chmod 664 *.tif"
echo "cd ${JPG}"
echo "chown nobody:nobody *.jpg"
echo "chmod 664 *.jpg"

will not carry out the commands

yup

look above the statements...

# mv files to web space and set permissions (echo put in for testing)

So.. does it not get to that point or something?

If so why not change your for statement from:
for files in ${IMAGEDIR}

to:
IFS="
"
for files in `cat $LIST`

could you explain what that statement means please?
(can't use it but i'm curious :-)

also , $LIST is also populated throughout the day as a master list of what files were changed that day. It will contain more that what is in the IMAGEDIR as conversions happen from other locations..

I need to be able to say for files in the $IMAGEDIR do ..... but i'm not sure how to specify the files in the directory..

thanks for your help.

S.

Why not use the ls command in the for loop.

The:
IFS="
"

Just sets the field delimitor to a newline.

not sure of the syntax for it, i need to convert only the files...

also, do you know how i would pause between the first commands that search and rename the files if they contain spaces before moving onto the conversion? As i test it is not waiting for this process to complete, the files with the spaces in their names then crap out when i try to move them...

You have 2 do loops but only one done statement. Maybe this is just a typo?
echo "Press enter to continue...";read
or
echo "Taking a short nap...";sleep 5


What part doesn't work?

One line messes it all up:

for files in ${IMAGEDIR}

You probably mean

for files in ${IMAGEDIR}/*

The difference is that characters like * and ? are expanded by the shell to make them match with the contents of your file system. The rules involved are called globbing and take place after the IMAGEDIR variable is substituted for its value.

If you need more info, try man bash and man glob.

thanks guys you were both right - i was missing the done statement (my bad

Also, thanks for the globbing info - you learn somethin new every day...

the script now works as needed.

Cheers.

S.