About bash scripting

pazvant · 10-20-2003, 05:39 AM

Here is the code for given at least 10 scores and ascending them, then making a sum of inputed values..In expr part i got 'syntax error' İ did not solve the problemm...Can anyone help me

#!/bin/bash
declare -a num
echo -n " input 10 scores : "
read -a num
for ((i=0; i<=10; i++))
do
echo " ${num[i]} " >> temp1
done
echo -n " Ordered Scores : "
sort -n -r temp1 | xargs -l1
sum=0
read -a num
for ((i=0; i<=10; i++))
do
sum=`expr $sum + ${num[i]}`
done
echo $sum

nhs · 10-20-2003, 07:50 AM

Firstly, your script asks for 12 scores (0 to 10 inclusive is 11 and you ask for a 12th after the sum=0 line). You then read the first 11 entries of which only 10 will be numeric so the eleventh will generate an error. (I think, I cannot experiment at the moment).

SaTaN · 10-20-2003, 09:32 AM

yeah nhs is right . I even checked your program by removing

Code:

read -a num

Then

Quote:

[SaTaN@mirage linux_org]$ sh bash.sh
input 10 scores : 1 2 3 4 5 6 7 8 9 10 11
Ordered Scores : 11 10 9 8 7 6 5 4 3 2 1
66

So I suppose you should remove those equal to signs in

Code:

for ((i=0; i<=10; i++))

This is if you want to accept only 10 numbers

And your code doesn't work for the next time because you are using >> which means append and so the 11 numbers which are
entered now will get appended to the previous 11 numbers and so on.
Don't use temp1 , if you really want to use it add a statement
rm -f temp1
at the end of the your code.

And your order is not ascending it is descending

Welcome to LQ

SaTaN · 10-20-2003, 11:12 AM

Instead of mailing me, you could have posted it right here.

One way of getting rid of temp is to write your sort.
i.e, here all that you need to do is sort an array of "n" elements
which is quite easy.
Use two for loops and it is done...