[C] system command

netpumber · 04-12-2009, 06:15 AM

Hi guyz... finally i write this script i c.

how you see it? does it have any mistakes? I m new in programming so...

Code:

#include <stdio.h>
#include <stdlib.h>

int main()
{

char counter;
char dname;
counter = "y";

do {
printf( "[x] Database_Name:".\n );
scanf( "%c", &dname );
printf( "[x] Dumping Database %d", dname );
printf( "waiting...".\n );
system("mysqldump --user=myuser --password=mypass $dname > /var/www/html/uploads/files/$dname.sql");
printf( "[x] Dumped Successfully".\n );
printf( "[x]Do you want to continue ? (y/n) :".\n );
scanf( "%c", &counter );
} while ( $counter != "y" );

getchar();
return 0;
}

thanks...in advance for every answer..

Hko · 04-12-2009, 07:27 AM

Why write a shell script C ?!?
It will be slower..

As for a mistake in the code, here:

Code:

system("mysqldump --user=myuser --password=mypass $dname > /var/www/html/uploads/files/$dname.sql");

you're trying to use a shell variable ($dname) in C. That won't work.

bgeddy · 04-12-2009, 07:48 AM

You really are making a lot of mistakes in this. I think you should learn a bit of C first. You are mixing up shell script amd C code in a bit of a mess.

You are mixing up characters (bytes) and character strings - you are using your format strings for printf and scanf incorrectly - you are using carriage returns incorrectly - you are using shell variables in C system calls.

To be honest this looks like a conversion from something in another post when you used Bash script. I think you would be better concentrating on the Bash and getting that working.

I don't wish to sound derogatory or be overly critical but the whole thing needs a rewrite - honestly get the Bash version to work - it will be less work.