unable to insert command output in html table format

hruday · 01-30-2017, 09:36 AM

I've a bash script written to insert ping statistics into html table.

#!/bin/bash

PINGGOOGLE=echo -e "<H1>Ping Status</H1>"; echo "<table border="1">" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>"

echo '<html>' >> pinghost.txt

echo '<body>' >> pinghost.txt

ssh root@192.168.16.130 "${PINGGOOGLE}" >> pinghost.txt

echo '</body>' >> pinghost.txt

echo '</html>' >> pinghost.txt

I want to put output of "ping 8.8.8.8 -c 3 | grep ping -A 2" in a table. What is wrong in my script?

Turbocapitalist · 01-30-2017, 09:56 AM

There are three mistakes.

One is [code] [/code] tags are missing to make the script more readable.

The second is this line, which due to the lack of quoting turns out to be four different lines.

Quote:

Originally Posted by hruday

PINGGOOGLE=echo -e "<H1>Ping Status</H1>"; echo "<table border="1">" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>"

It could be written like this:

Code:

PINGGOOGLE='echo -e "<H1>Ping Status</H1>"; echo "<table border="1">" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>"'

Notice the single quotes However, only the ping needs to be run on the remote system. However, that still does not add cell elements to the table. Maybe you would prefer <pre> element instead of a table?

Lastly, and the most important mistake, is that you are logging into the remote machine as root. Remote root access should be turned off. It is certainly not needed for ping and can be worked around for other cases.

smallpond · 01-30-2017, 09:58 AM

Presumably this is being run as a cgi by your web server as the user "apache" or "nano" or something. Have you tried running it under the same environment by hand? Is the script mode set to executable? Is it in the CGI directory?

Also, note that the first line output by the script should be: "Content-type: text/html".
Also HTTP line endings should be CR LF, not just LF.

Turbocapitalist · 01-30-2017, 10:04 AM

Quote:

Originally Posted by hruday

I want to put output of "ping 8.8.8.8 -c 3 | grep ping -A 2" in a table.

Also, can you paste some manually marked up HTML for how you want that output to look?

hruday · 01-30-2017, 10:05 AM

Quote:

Originally Posted by Turbocapitalist

There are three mistakes.

One is [code] [/code] tags are missing to make the script more readable.

The second is this line, which due to the lack of quoting turns out to be four different lines.

It could be written like this:

Code:

PINGGOOGLE='echo -e "<H1>Ping Status</H1>"; echo "<table border="1">" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>"'

Notice the single quotes However, only the ping needs to be run on the remote system. However, that still does not add cell elements to the table. Maybe you would prefer <pre> element instead of a table?

Lastly, and the most important mistake, is that you are logging into the remote machine as root. Remote root access should be turned off. It is certainly not needed for ping and can be worked around for other cases.

Hi thanks for your reply. single quotes didnt work.

Cant we use echo itself.?

hruday · 01-30-2017, 10:07 AM

Quote:

Originally Posted by hruday

Hi thanks for your reply. single quotes didnt work.

Cant we use echo itself.?

however command is working when i execute it in cli. It doesnt work when i assign it to a variable.

Turbocapitalist · 01-30-2017, 10:10 AM

Quote:

Originally Posted by hruday

however command is working when i execute it in cli. It doesnt work when i assign it to a variable.

Then it needs to have the quotes escaped, and be careful of the dollar signs which also need to be escaped.

Edit: I would do the echos on the local machine and only run ping on the remote.

Code:

ssh user@192.168.16.130 "ping -c 3 -w 1 -q | sed '/ping statistics/,$!d'"

hruday · 01-30-2017, 10:20 AM

Quote:

Originally Posted by Turbocapitalist

Then it needs to have the quotes escaped, and be careful of the dollar signs which also need to be escaped.

Edit: I would do the echos on the local machine and only run ping on the remote.

Code:

ssh user@192.168.16.130 "ping -c 3 -w 1 -q | sed '/ping statistics/,$!d'"

if i try escaping quotes it shows the same value which i assigned doesnt excute.

PINGGOOGLE=" echo -e "<H1>Ping Status</H1>"; echo "<table border="1">" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>" "

output: echo -e "<H1>Ping Status</H1>"; echo "<table border=1>" ; ping 8.8.8.8 -c 3 | grep ping -A 2; echo "</table>"

Turbocapitalist · 01-30-2017, 10:33 AM

Sorry. Copy-past error above.

Code:

ssh user@192.168.16.130 "ping -c 3 -w 1 -q 8.8.8.8" | sed '/ping statistics/,$!d'

You need only ping to run on the remote machine. Everything else can be local.

michaelk · 01-30-2017, 10:41 AM

To elaborate on Turbocapitalist post you can

Code:

pinggoogle=$(ssh user@192.168.16.130 "ping -c 3 -w 1 -q 8.8.8.8" | sed '/ping statistics/,$!d')

You can then insert $pinggoogle variable into the desired echo statement.