sendEmail usage - Can't use improperly formatted email address: (for

kbp · 10-05-2010, 09:23 PM

Looks like a change in function somewhere along the way .. it works on 2.5.2 but not on 2.6.3

(I think) I managed to get it filtering correctly, please change line 381 in sendphish to:

Code:

for abnetwaddr in `whois -h whois.abuse.net $targethost | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g ` ;

I haven't tested it thoroughly so if anyone can see anything wrong with the regex please speak up

cheers

Toadman · 10-05-2010, 09:53 PM

Made the change, the below was logged into /tmp/sendEmail

Code:

Oct 05 21:42:22 cpollock sendEmail[13043]: DEBUG => Assigned $opt{} key/value: tls => auto
Oct 05 21:42:22 cpollock sendEmail[13043]: DEBUG => Assigned $opt{} key/value: reply-to => cpollock@embarqmail.com
Oct 05 21:42:22 cpollock sendEmail[13043]: DEBUG => Assigned $opt{} key/value: message-file => /tmp/msgbody.11566
Oct 05 21:42:22 cpollock sendEmail[13043]:[*] kbp_debug (to): current address: "info@kickme.to"
Oct 05 21:42:22 cpollock sendEmail[13043]:[*] kbp_debug (to): current address: "(for"
Oct 05 21:42:22 cpollock sendEmail[13043]: ERROR => Can't use improperly formatted email address: (for
Oct 05 21:42:22 cpollock sendEmail[13043]: HINT => Try viewing the extended help on addressing with "--help addressing"

The above was with this URL -

http://zyngabonus-gift-luckywinner.8bit.at/

however, another URL has no problems -

http://64.15.147.205/~onlinep2//Cent...enturyLink.htm

kbp · 10-05-2010, 11:35 PM

Would you mind redoing the test with the new line, it works with grep-2.6.3

Code:

cat /tmp/test.txt | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g

Toadman · 10-06-2010, 06:13 AM

I put the line in place of line 381 and get:

Code:

[chris@localhost ~]$ sendphish http://zyngabonus-gift-luckywinner.8bit.at/
/usr/local/bin/sendphish: line 384: syntax error near unexpected token `do'
/usr/local/bin/sendphish: line 384: `do'

This is how I put the line:

Code:

cat /tmp/test.txt | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g

actually did a copy/paste -

kbp · 10-06-2010, 11:27 PM

No .. please replace with the line I posted before:

Code:

for abnetwaddr in `whois -h whois.abuse.net $targethost | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g ` ;

When I said please retry the test, that command was meant to be run at the command line like so:

Code:

cat <<'EOF'> /tmp/test.txt
blah1
info@kickme.to (for kickme.to)
blah3
EOF

cat /tmp/test.txt | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g

.. got it ?

Toadman · 10-07-2010, 05:31 PM

Got it now,ran

Code:

# cat <<'EOF'> /tmp/test.txt
> blah1
> info@kickme.to (for kickme.to)
> blah3
> EOF

Then

Code:

# cat /tmp/test.txt | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g

and got

blah1,info@kickme.to,blah3

kbp · 10-07-2010, 06:16 PM

Perfect .. that's what we want, then as mentioned in post #16, please replace what was originally line 381 in sendphish with:

Quote:

for abnetwaddr in `whois -h whois.abuse.net $targethost | grep -v -e "default" | grep -o -E -e "^[^[:space:]]*" | tr '\012' "," | sed -r s/",$"/"\n"/g ` ;

Note: the line probably won't be at 381 any more due to the debugging lines I asked you to add.

The only difference from the original line is the extra '^'

<edit> You may find it easier to grab a fresh copy of sendphish and modify that instead</edit>

cheers

Toadman · 10-07-2010, 07:06 PM

So far so good, I took my backup copy I'd made of sendphish and made the modification. I appreciate your help on this, I never would have figured it out. I'll keep an eye on the output as I go along but hopefully I won't see anymore addressing issues.

Chris