[SOLVED] Script to check files

orangepeel190 · 07-11-2020, 05:56 PM

Hi All,

I was wondering if someone would be able to check my script....

I am wishing to download a file from the mater website, if that website or file is not present, it will redirect to a backup server - and try and source the file from there

Bash Script....

Code:

/usr/bin/wget https://drive.google.com/drive/path/here/$FILE1 || \
/usr/bin/wget http://www.second.webserver/$FILE2 \\ error 1

if [ -f $FILE1 ]; then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
else

[ -f $FILE2 ] then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

exit 0;;

The Google address is proving temperamental (must be missing something in the URL), but I am having issues trying to checking which File was downloaded in the IF/FI statement so that when whichever file was downloaded - the correct statement was displayed

Thought to give it a try, but I am going around in circles to find out what is wrong and missing.

Would curl be a better option than wget for the download?

Code:

/usr/bin/curl -sSkLo $FILE1 https://drive.google.com/drive/path/here/$FILE1 || \
/usr/bin/curl -sSkLo $FILE2 http://www.second.webserver/$FILE2 || error 1

if [ -f $FILE1 ]; then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
else

[ -f $FILE2 ] then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

exit 0;;

What part is fowling up?

individual · 07-11-2020, 06:23 PM

Quote:

Originally Posted by orangepeel190

Hi All,

I was wondering if someone would be able to check my script....

I am wishing to download a file from the mater website, if that website or file is not present, it will redirect to a backup server - and try and source the file from there

Bash Script....

Code:

/usr/bin/wget https://drive.google.com/drive/path/here/$FILE1 || \
/usr/bin/wget http://www.second.webserver/$FILE2 \\ error 1

if [ -f $FILE1 ]; then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
else

[ -f $FILE2 ] then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

exit 0;;

The Google address is proving temperamental (must be missing something in the URL), but I am having issues trying to checking which File was downloaded in the IF/FI statement so that when whichever file was downloaded - the correct statement was displayed

Thought to give it a try, but I am going around in circles to find out what is wrong and missing.

Would curl be a better option than wget for the download?

Code:

/usr/bin/curl -sSkLo $FILE1 https://drive.google.com/drive/path/here/$FILE1 || \
/usr/bin/curl -sSkLo $FILE2 http://www.second.webserver/$FILE2 || error 1

if [ -f $FILE1 ]; then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
else

[ -f $FILE2 ] then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

exit 0;;

What part is fowling up?

You can't add a condition to an else statement, because else is the 'catch all' statement.
Try elif [ CONDITION ].

You can use curl if you want to, but you will need to manually specify the output file, or use the -O option. Otherwise, it will try to print to stdout.

orangepeel190 · 07-11-2020, 06:40 PM

Opps .... Sorry - the curl statement should be:

/usr/bin/curl -SkL https://drive.google.com/drive/path/here/$FILE1 -o $FILE1|| \
/usr/bin/curl -SkL http://www.second.webserver/$FILE2 -o $FILE2|| error 1

That should work better ?

Ill give the elif in the middle of the condition statement

Code:

if [ -f $FILE1 ]
then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
elif 
[ -f $FILE2 ]
then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

Appreciate your reply and helping me resolve the issue ....

That look a little better?

individual · 07-11-2020, 07:35 PM

Quote:

Originally Posted by orangepeel190

Opps .... Sorry - the curl statement should be:

/usr/bin/curl -SkL https://drive.google.com/drive/path/here/$FILE1 -o $FILE1|| \
/usr/bin/curl -SkL http://www.second.webserver/$FILE2 -o $FILE2|| error 1

That should work better ?

Ill give the elif in the middle of the condition statement

Code:

if [ -f $FILE1 ]
then
echo ".... SUCCESS !!! $FILE1 downloaded from Master Site....."
elif 
[ -f $FILE2 ]
then
echo ".... SUCCESS !!! $FILE2 downloaded from backup site....."
fi

Appreciate your reply and helping me resolve the issue ....

That look a little better?

You may want to add an else statement to handle the event of neither file being downloaded. Also, curl has the -O (capital letter O) flag, which will output to the file name specified in the URL. So you don't need to write -o $FILE1, just curl -SkLO 'URL'.

orangepeel190 · 07-12-2020, 12:01 AM

Fantastic!

Working a treat now..... Much appreciated!