NS2: Blackhole aodv error

chenil · 06-27-2013, 07:28 AM

i want solution for given problem.

Hello
I was trying to add malicious node in current AODV which i have executed without any errors.

While doing changes as suggested in [URL="http://http://narentada.com/what-is-black-hole-attack-in-manets-my-code-for-adding-malicious-node-as-blackhole-in-aodv-protocol/"]

attaching my currnt files also.
I got the same output which was for AODV.

Where i am going wrong?
Please help me.

knudfl · 06-28-2013, 03:53 AM

Your link, @ Naren Tada
http://narentada.com/what-is-black-h...aodv-protocol/
.. refers to @Elmurod http://elmurod.net/en/index.php/archives/196

The attached file "aodvcc.txt" seems to be a copy of your tcl file.
Please attach the real aodv.cc as "aodv.cc.txt" : aodv<period>cc<period>txt.

Your exampple, "aodvtcl" : Already some files named aodv.tcl . Must have new name.
Suggest e.g. 'm-aodv-chenil.tcl'.

About the line : #$ns_ at 0.0 “[$n2 set ragent_] malicious" :
The hash mark ( # ) is a "comment", and means : Do not use this line.
Please replace with something like : $ns at 0.0 "[$n(2) set ragent_] malicious"
I.e. the syntax must be adjusted to the syntax used in your tcl file :
Edit ns_ to ns ; $n2 to $n(2) ; “ to " .

In the Elmurod aodv.cc, `malicious` is defined as "hacker" :
if(strcmp(argv[1], "hacker") == 0) {
malicious = true;
return TCL_OK;
}
..... and the line in the tcl file must then be : $ns at 0.0 "[$n(2) set ragent_] hacker" :
$ ns233-maodv m-aodv-chenil.tcl : OK, and xgraph is OK.

Quote:

Where I am going wrong ?

Which result do you expect ? And where did you find the "aodv.tcl" ?
Which version of ns2 ? Which OS is used ? $ cat /etc/*release* ; $ uname -m

LQ, aodv-malicious : http://www.linuxquestions.org/questi...odv-malicious/
LQ, blackholeaodv http://www.linuxquestions.org/questi...blackholeaodv/
LQ, blackhole http://www.linuxquestions.org/questions/tags/blackhole/

Simulation examples, aodv-malicious-examples.tar.gz ( 5.3 kB )
https://docs.google.com/file/d/0B7S2...it?usp=sharing
blackholeaodv2005-examples.tar.gz ( 6.7 kB )
https://docs.google.com/file/d/0B7S2...it?usp=sharing

-

chenil · 06-28-2013, 04:58 AM

Now i am getting error after make as " expected ‘}’ at end of input
make: *** [aodv/aodv.o] Error 1

Please help me.
i have attached my aodv.cc.

Quote:

Originally Posted by knudfl

Your link, @ Naren Tada
http://narentada.com/what-is-black-h...aodv-protocol/
.. refers to @Elmurod http://elmurod.net/en/index.php/archives/196

The attached file "aodvcc.txt" seems to be a copy of your tcl file.
Please attach the real aodv.cc as "aodv.cc.txt" : aodv<period>cc<period>txt.

Your exampple, "aodvtcl" : Already some files named aodv.tcl . Must have new name.
Suggest e.g. 'm-aodv-chenil.tcl'.

About the line : #$ns_ at 0.0 “[$n2 set ragent_] malicious" :
The hash mark ( # ) is a "comment", and means : Do not use this line.
Please replace with something like : $ns at 0.0 "[$n(2) set ragent_] malicious"
I.e. the syntax must be adjusted to the syntax used in your tcl file :
Edit ns_ to ns ; $n2 to $n(2) ; “ to " .

In the Elmurod aodv.cc, `malicious` is defined as "hacker" :
if(strcmp(argv[1], "hacker") == 0) {
malicious = true;
return TCL_OK;
}
..... and the line in the tcl file must then be : $ns at 0.0 "[$n(2) set ragent_] hacker" :
$ ns233-maodv m-aodv-chenil.tcl : OK, and xgraph is OK.

Which result do you expect ? And where did you find the "aodv.tcl" ?
Which version of ns2 ? Which OS is used ? $ cat /etc/*release* ; $ uname -m

LQ, aodv-malicious : http://www.linuxquestions.org/questi...odv-malicious/
LQ, blackholeaodv http://www.linuxquestions.org/questi...blackholeaodv/
LQ, blackhole http://www.linuxquestions.org/questions/tags/blackhole/

Simulation examples, aodv-malicious-examples.tar.gz ( 5.3 kB )
https://docs.google.com/file/d/0B7S2...it?usp=sharing
blackholeaodv2005-examples.tar.gz ( 6.7 kB )
https://docs.google.com/file/d/0B7S2...it?usp=sharing

-

knudfl · 06-28-2013, 05:48 AM

# 3 : Please do not quote entire posts. Please edit.

Quote:

Now i am getting error after make as " expected ‘}’ at end of input
make: *** [aodv/aodv.o] Error 1

Which file is it about ? Which line number in that file ?

And, repeat from post #2 :
Which result do you expect ? And where did you find the "aodv.tcl" ?
Which version of ns2 ? Which OS is used ? :
$ cat /etc/*release*
$ uname -m

P.S. : Don't your post #1 say that you made a successful build ?

-

chenil · 06-28-2013, 07:56 AM

Thank you for replying.

I have executed aodv without any error as mentioned but after changing as mentioned in adding malicious node to aodv as mentined here http://narentada.com/what-is-black-h...aodv-protocol/i am getting error after make as:

aodv/aodv.cc:778: warning: this decimal constant is unsigned only in ISO C90
aodv/aodv.cc:837: warning: this decimal constant is unsigned only in ISO C90
aodv/aodv.cc: In member function ‘virtual void AODV::recv(Packet*, Handler*)’:
aodv/aodv.cc:579: warning: comparison between signed and unsigned integer expressions
aodv/aodv.cc:634: error: a function-definition is not allowed here before ‘{’ token
aodv/aodv.cc:1420: error: expected ‘}’ at end of input
make: *** [aodv/aodv.o] Error 1

As you asked ;

Which file is it about ?Which line number in that file ?
It is related with aodv.cc

And, repeat from post #2 :
Which result do you expect ?
I want blackhole should be added in plain AODV.

where did you find the "aodv.tcl" ?
Fromhttp://network-simulator-ns-2.7690.n...4-td10367.html

Which version of ns2 ? Which OS is used ? :
I am using NS-2.34 on Ubuntu 10.10

knudfl · 06-28-2013, 09:29 AM

Please edit post # 3 :
See post #4 : Hit the 'Edit' button, and delete the surplus "Quoted text".

? And : What is your output from the command $ uname -m <Enter>

How to type / copy a link, to be readable here at LQ, e.g.
http://network-simulator-ns-2.7690.n...4-td10367.html
→ → Either click 'select all' in the Internet browser address line.
Or use copy / paste, to grab the link.

-