Extra innings in line score
Small thing, but thought you'd want to know. For extra inning games, the line score shows only the 9 innings. The final score is correct. Good example is the Boston-Tampa Bay game of April 13. It went 10 innings and the Red Sox scored the winning run in the bottom of the tenth. The line score shows nine innings of scoring (so they add up to a 1-1 game) and then the total runs shows the Sox with 2.
Not sure how difficult it would be to show the extra inning(s) and in any event, the total scores are right. |
Master Scoreboard
The Master Scoreboard feature is great! Love at the end of the Phillies games being able to quickly find the one that's a good one to tune in and listen.
|
Quote:
EDIT: Turned out to be easier than I thought. Checked in a fix for this. For games that have extra innings, left and right arrow keys will let you navigate through the extra frames. I tested it with several games this season and even going back to a 20-inning game on 4/17/10. |
SVN revision 423: Fixed line score view to handle extra innings
Left and right arrow keys in line score view will now let you scroll through extra innings.
I also changed the name of prepareMediaPlayer() method in MediaStream to prepareMediaStreamer() to more accurately describe what the routine does. Shouldn't change anything unless you are writing your own code with MLBviewer library. |
SVN revision 426: Changed jump to innings to fix jump to extra innings
Reworked internal data structures for jump to innings to support jump to any inning, not just the first 10.
Prior to 426: MLBSchedule.parseInningsXml() returned a list of tuples of (inning, is_top, time) and MLBInningWin had a hack to to store top innings as 1-10 and bottom innings as 11-20. It made creating the availability frames a little easier but it also limited the jumps to the first 10 innings. Change in 426: The list of tuples is replaced with a dictionary of innings[inning]['away'] and innings[inning]['home']. This dictionary is built in MLBSchedule.parseInningsXml() rather than MLBInningWin. Two major benefits to this are that extra inning jumps can go directly to the desired half inning (e.g. "b16" will go to bottom 16th rather than only having "e" to go to top of 10th) and mlbplay support for innings will be a lot easier (coming soon.) (If you like extra implementation details, the ~/.mlb/log file will contain a link to the innings XML that was parsed and entering "D" for the half inning to jump to will give you a debug dump of the parsed innings file.) Two things I also changed with this:
Quick poll: For those who use jump to innings feature, do you want to know about extra innings at all? Seems to me that it would be a spoiler for an archived game. However, if the game is still in progress, it would seem like a good thing to know, especially if it's gone to 16+ innings. You may just want to jump in and watch to the end rather than sitting through the first 16. What do you think? If you are experiencing any problems with either jump to inning or starting an archived nexdef game (uses the same code to find the start of broadcast), please tell me the date, game, nexdef or not, and half inning. |
Quote:
Unless it has changed, if you don't want to see the innings played, you could always set show_inning_frames=0 in the config file. I have always done that to prevent an extra inning spoiler: in previous versions, although jump to extra innings didn't work, the innings frames still indicated whether there were extra innings. |
Quote:
BTW, I have checked in a new revision of mlbplay that supports 'i' flag with the same syntax as the inning screen: 't' or 'b' plus inning, e.g. t8; 'e' for top 10; or 'd' for debug dump (cross-reference with innings xml URL written to ~/.mlb/log if you have doubts about how a game was parsed.) |
Quote:
|
SVN revision 433: Box scores!
Box scores!
'x' key or BOX_SCORE action if you're customizing keybindings (see README on how to do that.) I am aware that the screen size often breaks the box score in inconvenient places (like header on the last line, then all the stats continued on the next page) but I'm not sure how to fix that yet. I currently build the box score line by line into a list and by the time it gets drawn to the screen, I am not checking the contents of that list. Give me some time to use it, play with it, get seriously annoyed with that limitation, and I'll probably come up with a fix eventually. :p |
I'm on rev 438. Today I'm trying to catch the phillies @ reds. The game was rain delayed for 1.25 hr, my feed dropped out. The game is currently in the t7, when I go to the innings selector, try to get the t4 I get:
Traceback (most recent call last): File "./mlbviewer.py", line 677, in <module> curses.wrapper(mainloop, mycfg) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/curses/wrapper.py", line 43, in wrapper return func(stdscr, *args, **kwds) File "./mlbviewer.py", line 405, in mainloop mediaUrl = mediaStream.locateMedia() File "/Users/mchapter/mlbviewer/MLBviewer/mlbMediaStream.py", line 159, in locateMedia content_list = self.parseMediaReply(reply) File "/Users/mchapter/mlbviewer/MLBviewer/mlbMediaStream.py", line 183, in parseMediaReply raise Exception,self.error_str Exception: Other Undocumented Error I looked int ~/.mlb/log... 2013-04-16 21:13:41.410054 UNSUCCESSFUL MEDIA REQUEST: status-code: -1500 , event-id = 14-346942-2013-04-16 See /Users/mchapter/.mlb/unsuccessful-1.xml for XML response. session-key from cookie file: UE%2B8%2BfmrTv8cf6dSETEvudgrpYc%3D parseInningsXml(): url = http://mlb.mlb.com/mlb/mmls2013/346942.xml unsuccessful-1.xml is zero bytes and empty EDIT: started working again, I guess it was on mlb's end. |
Quote:
Not sure why unsuccessful-1.xml was empty though. That's something I can look into (review the code) but not sure how to reproduce it. EDIT: File descriptor was not closed after writing and before crashing. Checked in a fix for that as well as displaying an error message instead of crashing. |
SVN rev 438: Various improvements to line score and master scoreboard for Delayed games
Made a lot of little changes and a lot of check-ins to resolve errors with line scores and master scoreboard for Delayed and Suspended games.
Delayed/Suspended/Postponed games now show up as Delayed/Suspended/Postponed in master scoreboard with the last half inning played for Delayed (Suspended and Postponed are treated as Game Over.) There's also a Delayed/Suspended/Postponed reason like "Snow" or "Rain" which gets attached to the status in line score view. For make up games and double headers, mlb.com indicates as much in their scores. Now line score view shows the same. So how are you guys liking the box scores? |
SVN revision 444: Various bug fixes (including use_librtmp and condensed games)
Jump to Innings:
* Removing an extra frame (bottom 10th) for in progress extra-innings game - moved the > 9 check outside of the ( 'home', 'away' ) loop MediaStream: * Changed prepareMplayerCmd to prepareLibrtmpCmd to more accurately describe what it does * Added check for streamtype == condensed and use_librtmp to prepareMediaStreamer * Added extra checks to prepareLibrtmpCmd to not construct a librtmp url for use_nexdef=True and streamtype == video mlbviewer.py * Fix for media debug from box score * Fix for media debug from one of the new screens (can't remember which it was that didn't work but it's fixed now) Any other nagging bugs that need attention? Looks like I'm done with new features for awhile and just looking at bug fixes now. Speaking of new features, anyone try out box scores yet? ;) |
Quote:
|
It's amazing how much time you have dedicated to mlbviewer this year. Thank you very much!
Quote:
It regularly happens that I need many tries to get a game started. It's not really a mlbviewer problem, since mlbviewer is able to get the media URL just fine. But then rtmpdump just can't get the stream going. The error messages are usually along the lines of: Code:
ERROR: RTMP_ReadPacket, failed to read RTMP packet body. len: <random number> Code:
ERROR: DECODING ERROR, IGNORING BYTES UNTIL NEXT KNOWN PATTERN! Code:
WARNING: Received FLV packet before play()! Ignoring. I have tried different rtmpdump versions including the current git version and different mplayer/mplayer2 versions. Am I the only one this happens to? Any ideas why this could be happening? |
All times are GMT -5. The time now is 01:08 AM. |