[SOLVED] Issues creating an init script

RetroSpock · 03-17-2015, 10:16 AM

Hey,

I'm struggling with this init script I've created.

The process runs fine, but I'm unable to get the PIDFILE to create, and I can't kill the process because of this.

Other than the issues with the PID/PIDFILE, the script works fine.

I even tried a

pid=`ps -A |grep java |cut -d" " -f1`
echo ${pid} > ${pidfile}

which works in bash, just not within the script

Code:

#!/bin/bash
#
# stock-management
#
# chkconfig: 2345 80 30
# description: stock-management

### BEGIN INIT INFO
# Provides: stock-management
# Required-Start: $local_fs $network $remote_fs
# Required-Stop: $local_fs $network $remote_fs
# Default-Start: 2 3 4 5
# Default-Stop: 0 1 6
# Short-Description: start and stop stock-management
### END INIT INFO
# Author: Dave

# Source function library
. /etc/rc.d/init.d/functions

voyager_dir=${VOYAGER_DIR-/opt/voyager}
appname=${APPNAME-stock-management}
pidfile=${PIDFILE-/var/run/${appname}.pid}
lockfile=${LOCKFILE-/var/lock/subsys/${appname}}
RETVAL=0

start() {
        echo -n $"Starting stock-management: "
        daemon --user="voyager" --pidfile="${pidfile}" "${voyager_dir}/${appname}/bin/${appname} -Dconfig.file=${voyager_dir}/${appname}.conf > ${voyager_dir}/${appname}/${appname}-`date +%Y%m%d%H%M`.log "
        RETVAL=$?
        echo
                [ $RETVAL = 0 ] && touch ${lockfile}
                return $RETVAL
}

stop() {
        echo -n $"Stopping stock-management: "
        kill $(cat ${pidfile})
        REVAL=$?
        echo
        [ $RETVAL = 0 ] && rm -f ${lockfile} ${pidfile}
}

restart() {
    stop
    start
}

case "$1" in
  start)
        start
        ;;
  stop)
        stop
        ;;
  restart)
        restart
        ;;
  status)
        rh_status
        ;;
  *)
        echo $"Usage: $0 {start|stop|restart}"
        exit 1
esac

exit $RETVAL

Any help?

Thanks!

smallpond · 03-17-2015, 12:33 PM

Could be PIDFILE="". Unless that's valid, change the test to:

Code:

pidfile=${PIDFILE:-/var/run/${appname}.pid}

Keith Hedger · 03-17-2015, 07:52 PM

To start if you are setting default values in bash you need to use :- not just - like the post above, also upper and lower case variable names are not the same so for instance you should use

Code:

PIDFILE=${PIDFILE:-/var/run/${APPNAME}.pid}

Try to stick to a format ie I use all uppercase variable names for global variables and all lowercase names for local variables.

RetroSpock · 03-18-2015, 02:48 AM

Thank you both for your replies.

I'm not overly familiar with Bash scripting as I struggle to find any decent learning material.

Everything I know has come from about 6 months of playing around with scripts.

I've gone for a different approach now, which appears to work; I just need to add some sanity checks.

I'll post the final draft once I've added some checks.

Thanks again!

TenTenths · 03-18-2015, 03:06 AM

Quote:

Originally Posted by RetroSpock

I'm not overly familiar with Bash scripting as I struggle to find any decent learning material.

http://www.tldp.org/LDP/abs/html/

RetroSpock · 03-18-2015, 04:51 AM

Thanks TenTenths! That site occasionally pops up when I'm searching for something specific, I'll give it a read start to finish.

Here is the script I went with which appears to work as I want it to:

Code:

#!/bin/bash
#
# stock-management
#
# chkconfig: 2345 80 30
# description: stock-management

### BEGIN INIT INFO
# Provides: stock-management
# Required-Start: $local_fs $network $remote_fs
# Required-Stop: $local_fs $network $remote_fs
# Default-Start: 2 3 4 5
# Default-Stop: 0 1 6
# Short-Description: start and stop stock-management
### END INIT INFO
# Author: Dave

# Source function library
. /etc/rc.d/init.d/functions

VOYAGER_DIR=${VOYAGER_DIR:-/opt/voyager}
APP_NAME=${APP_NAME:-stock-management}
VOYAGERD=${VOYAGERD:-${VOYAGER_DIR}/${APP_NAME}/bin/${APP_NAME}}
DCONF=${DCONF:-${VOYAGER_DIR}/${APP_NAME}.conf}
LOG_FILE=${LOG_FILE:-${VOYAGER_DIR}/${APP_NAME}/logs/${APP_NAME}-`date +%Y%m%d%H%M`.log}
PID_FILE=${PID_FILE:-/var/run/${APP_NAME}.pid}
LOCK_FILE=${LOCK_FILE:-/var/lock/subsys/${APP_NAME}}
IS_RUNNING=${IS_RUNNING:-"${APP_NAME} is already running! "}
NOT_RUNNING=${NOT_RUNNING:-"${APP_NAME} is not running! "}
NAME=java
RETVAL=0

start() {
        if [ -s ${PID_FILE} ] ; then
                echo $"${IS_RUNNING}"
                exit 1
        else
                echo -n $"Starting ${APP_NAME}: "
                touch ${PID_FILE}
                su - voyager -c "nohup ${VOYAGERD} -Dconfig.file=${DCONF} > ${LOG_FILE} 2>&1 & echo \$!" > ${PID_FILE}
                RETVAL=$?
                if [ $RETVAL = 0 ] ; then
                        echo "OK!"
                        touch ${LOCK_FILE}
                        return $RETVAL
                fi
        fi
}

stop() {
        if [ ! -s ${PID_FILE} ] ; then
                echo $"${NOT_RUNNING}"
                exit 1
        else
                echo -n $"Stopping ${APP_NAME}: "
                kill $(cat ${PID_FILE})
                #kill $(ps -A |grep $NAME |cut -d " " -f1)
                REVAL=$?
                if [ $RETVAL = 0 ] ; then
                        echo "OK!"
                        rm -f ${LOCK_FILE} ${PID_FILE}
                fi
        fi
}

restart() {
        if [ -s ${PID_FILE} ] ; then
                stop
                start
        elif [ ! -s ${PID_FILE} ] ; then
                echo -n "${NOT_RUNNING} Attempting to start: "
                start
                echo -n "OK!"
        fi
}

status() {
        if [ -s ${PID_FILE} ] ; then
                echo "${APP_NAME} is running!"
                exit 1
        elif [ ! -s ${PID_FILE} ] ; then
                echo "${NOT_RUNNING}"
                exit 1
        fi
}

case "$1" in
  start)
        start
        ;;
  stop)
        stop
        ;;
  restart)
        restart
        ;;
  status)
        status
        ;;
  *)
        echo $"Usage: $0 {start|stop|restart|status}"
        exit 1
esac

exit $RETVAL