Help me make this work.

fshstx1 · 12-03-2009, 05:48 PM

I am trying to get this working with option to loop or exit

Code:

#!/bin/bash

create_user () {
clear
read -p "Enter username : " username
read -p "Enter Group : " group
        useradd -g $group -p $username $username
        chage -d 0 $username
        echo "User has been added to system!"
        echo "User must change password at first login"
        read -p "Create another user : (y)es (n)o : " repeat
        if [ $repeat = n ]
        then creat_user
        else
        exit
}

This is only the portion that I want to repeat and it works up until the if statement. please help. I am using Red Hat

pixellany · 12-03-2009, 06:09 PM

I fixed the [CODE] tags (no extra charge....

)

Assuming that "creat_user" was meant to be "create_user", I do not understand calling a function from within its own definition code. Assuming that this is legal, then I think the logic is wrong---if $repeat = y, you want to create another user.

bigrigdriver · 12-03-2009, 06:14 PM

Maybe a while loop instead of an if condition?

Code:

#!/bin/bash

create_user () {
clear
repeat = y
while [ $repeat != n ]
do
read -p "Enter username : " username
read -p "Enter Group : " group
        useradd -g $group -p $username $username
        chage -d 0 $username
        echo "User has been added to system!"
        echo "User must change password at first login"
        read -p "Create another user : (y)es (n)o : " repeat
done
}

chrism01 · 12-03-2009, 06:31 PM

Note

Quote:

-p, --password PASSWORD
The encrypted password, as returned by crypt(3). The default is to disable the account.

Means you have to encrypt the passwd before you call useradd.

If you supply a plaintext passwordd, do this instead

echo password | passwd --stdin $USER

which will encrypt it for you and add it to /etc/shadow.

deepinlife · 12-03-2009, 11:12 PM

Code:

#!/bin/bash

create_user () {
clear
read -p "Enter username : " username
read -p "Enter Group : " group
        useradd -g $group -p $username $username
        chage -d 0 $username
        echo "User has been added to system!"
        echo "User must change password at first login"
        read -p "Create another user : (y)es (n)o : " repeat
        if [ $repeat = y ]
        then create_user
        else
        exit
fi

what about this code now , is it working?
it works on my pc
recursion in bash , nice idea