cron problem

sle09 · 02-18-2012, 06:02 PM

i have a hosting account at hostgator running linux and have ssh access and cron via cpanel, i have two security cameras that ftp upload snapshots upon movement and the upload to /home/sle09/ftp/door/ and /home/sle09/ftp/rover/ one for each camera, so the folders both just get alot of snapshots to many to look through, so i made a cron script that basically every hour takes the pictures from each folder and creates a new folder in /home/sle09/ftp/camera/door/ and /home/sle09/ftp/camera/rover/ respectivly naming the folder with the date and time and then moving the pictures into the newly created folder that way every hour will have a different folder and will never have 90,000 pictures to go through over time. i made a door.sh and rover.sh and made the exectutable and called them from ssh command line and it works fine and creates the folder with date and time and moves files, also i set it to run every minute just to test it while i was watching and it worked too. however i set it to everyhour and walked away and when i came back i find that it is running and moving the files from /home/sle09/ftp/door/ to /home/sle09/ftp/camera/door/ but not creating the folder with date and time its just putting the pictues in there so instead of /home/sle09/ftp/camera/door/ havning folders in it, it has picutes, and it did the same for /home/sle09/ftp/camera/rover

the .sh files contain

mkdir /home/sle09/ftp/camera/door/`date --date='UTC +4 hours' +\%F_\%R`; find /home/sle09/ftp/door/ -type f -name '*' -exec mv {} $_/. \;

and the other file the same but door is rover

ive been trying to fix this like crazy with no success, thanks

uhelp · 02-18-2012, 09:17 PM

use a var to for the date:

Code:

doorDate=$( date --date='UTC +4 hours' +'%F_%R'
doorDIR='/home/sle09/ftp/camera/door/'
doorDirNew=${doorDir}${doorDate}'/'

# and finally something like this:
mv * $doorDirNew

$_ Gives the last argument to the previous command. At the shell startup, it gives the absolute filename of the shell script being executed.

So don't use this. What do you expect will happen, when a failure occurs?

pafoo · 02-19-2012, 09:32 PM

Quote:

Originally Posted by uhelp

use a var to for the date:

Code:

doorDate=$( date --date='UTC +4 hours' +'%F_%R'
doorDIR='/home/sle09/ftp/camera/door/'
doorDirNew=${doorDir}${doorDate}'/'

# and finally something like this:
mv * $doorDirNew

$_ Gives the last argument to the previous command. At the shell startup, it gives the absolute filename of the shell script being executed.

So don't use this. What do you expect will happen, when a failure occurs?

He is correct. Always, always, ALWAYS use the absolute path of everything unless you cannot avoid it. Also, you should enter error handling as well. Lets say..

Code:

#!/bin/bash
doorDate=$( date --date='UTC +4 hours' +'%F_%R'
doorDIR='/home/sle09/ftp/camera/door/'
doorDirNew=${doorDir}${doorDate}'/'

if [ ! -d $doorDirNew ]
  then 
    mkdir $doorDirNew 
    if [ ! -d $doorDirNew ]
      then
        printf "Failed making new directory %s\n please look in to error" $doorDirNew | mail -s "Error making pic directory" myadmin@adminsrule.net
    fi
    find $doorDir -type f -cmin -60 -name "*.pic" -exec mv {} $doorDirNew \;
  else printf "Directory %s exists, problem with date variable?" $doorDate | mail -s "Error making pic directory" myadmin@adminsrule.net
fi

Even basic scripts work better with SOME level of error handling.

catkin · 02-20-2012, 03:14 AM

Quote:

Originally Posted by pafoo

He is correct. Always, always, ALWAYS use the absolute path of everything unless you cannot avoid it.

Or set and export PATH