Yep, you guessed it -- another bad script.

L_Carver · 12-24-2016, 10:41 AM

And this one checks out on the two shellchecks I gave it to, as well.

Code:

#!/bin/bash
if [ ! -f "commented-files.txt" ]; then
    echo "There is no 'commented-files.txt in this directory."
    echo "Can't continue."
    exit 1
fi

 while read -r file0; do
#	comm1=$(exiftool -fast5 -p "home/steve/bin/iptccomment.fmt" "$line" 2>/dev/null)
# comm1=$(exiv2 -q -pc "$file0")
comm1=$(exiftool -fast5  -Comment "$file0")
	if ! [[ -z "$comm1" ]]; then
	echo -e "$file0 has a Comment."
			if [[  "$comm1" = *"CREATOR:GD-JPEG"* ]] || [[  "$comm1" = *"ACDSystems"* ]] || [[ $comm1 =  *"Created with GIMP"* ]]; then
#			if [[ $comm1 =  *"Created with GIMP" * ]]; then
			echo -e "$file0 has a bad Comment. Writing to file."
			echo -e "$file0">>had-bad-comment.txt
            exiftool -fast5 -overwrite_original_in_place -q -Comment= "$file0"
#			jhead -dc "$file0"
			echo -e "Comment data removed from $file0."
			echo -e "$file0">>comment-cleared.txt
		fi
	fi
	
done<commented-files.txt

On one run it wrote the names of the files with "bad" comments to "had-bad-comment.txt," on a subsequent run it didn't. And checking the files afterwards with Gwenview (I don't trust gThumb to update anything), I noticed none of the comments were removed.

Now the 2 scripts this was built from work. Seems to be the way with my scripts: when I try to make things more efficient by combining elements of two shorter scripts (note the long-ish if conditional above), the combination fails to work.

Any ideas?

Carver

michaelk · 12-24-2016, 12:41 PM

So no real obvious syntax errors but the script isn't working as expected. Try adding set -xv after your shebang to enable debugging. You will then be able to see where it goes astray.

BW-userx · 12-24-2016, 12:46 PM

so the first time you ran it on the (test?) files, it worked,
the second time you ran it on the (same?) test files it did not work?

could it be that after you ran it the first time (if you are doing this with the same files each time) that the first run changed the (test?) files in a way that would make it so a second run and the (same?) files would not give the desired results due to them being altered by the first run?

grail · 12-24-2016, 07:00 PM

I would be curious to know what you expect from all the globbing used in your test, ie. all the asterisks you have used will be expanded prior to the test but as
I would think there are no files on your system with those names, I am not sure I understand the need??

L_Carver · 02-06-2017, 06:08 AM

Quote:

Originally Posted by grail

I would think there are no files on your system with those names, I am not sure I understand the need??

The asterisks were intended to have the script (shell?) look for any possible variation on the comment strings returned by

Code:

comm1=$(exiftool -fast5  -s -S -Comment "$file0")

that contain the GD-JPEG substring. There are a few variations on the "GD-JPEG" comment; the one I've seen most often is on the order of

Code:

GD-JPEG v1.0 (using IJG JPEG v62), quality = 90

I think it would limit the scope of the script to have it look for the one I just bold-ed and ignore the other possibilities.

I just tried the if/then test in Konsole and noticed the conditional did not perk up with

Code:

"$file0 has a \"libgd\" Comment.

The longer part of the substring (a Comment from a recently-downloaded JPEG) my script tested for was in lowercase, while the script looks for all caps instead of both. Testing for each one looks like a way forward, unless there's a better way about it.

Thanks for your advice. I hope you'll help me further with this one.

Carver

grail · 02-06-2017, 09:24 AM

Personally I would force the 'comm' variable to all upper / lower case and then use a simple regex on the resulting string.