[SOLVED] While Loop Not Working

MrLinuxDonnelly · 05-13-2015, 05:08 AM

Hey, not sure if this is the best place however thought id ask my question ..

My while loop below doesnt return as id expect :

while [[ ! "$RES" =~ (1|2|3|4|5|6|7|8|9|x|10)$ ]]
do
read -p "Please select an above option : " RES || exit
done

if [[ "$RES" =~ 1 ]]
echo "Option 1 Selected"
and so on through all my results

This goes on and works all the way up to 10.

If i select option 10 it runs option 1.

Any idea how to make sure when i select option 10 it runs it not 1.

translator1111 · 05-13-2015, 05:15 AM

Dear MrLinuxDonnelly,

Quote:

This goes on and works all the way up to 10.

Is this related to the fact that the 10 is after the x?
would it work better like this?

Quote:

while [[ ! "$RES" =~ (1|2|3|4|5|6|7|8|9|x|10)$ ]]

Quote:

while [[ ! "$RES" =~ (1|2|3|4|5|6|7|8|9|10|x)$ ]]

Faithfully,
M.

chrism01 · 05-13-2015, 05:39 AM

Code:

if [[ "$RES" =~ 1$ ]]
then
    echo "match 1"
fi
if [[ "$RES" =~ 10$ ]]
then
    echo "match 10"
fi

Regexes match the target string anywhere; you need to anchor the end ($)

millgates · 05-13-2015, 05:45 AM

How about using case?

Code:

while :; do
	read -p "Please select an above option : " res
	case "$res" in 
		1) echo "Option 1 Selected" ;;
		2) echo "Option 2 Selected" ;;
		# ...
		10) echo "Option 10 Selected" ;;
		*) break ;;
	esac
done

MrLinuxDonnelly · 05-13-2015, 06:00 AM

Quote:

Originally Posted by chrism01

Code:

if [[ "$RES" =~ 1$ ]]
then
    echo "match 1"
fi
if [[ "$RES" =~ 10$ ]]
then
    echo "match 10"
fi

Regexes match the target string anywhere; you need to anchor the end ($)

Hi Chris
For some reason this didnt work for me however i found that the below while loop worked after playing around a few time
while [[ ! "$RES" =~ ^(1[0-1]|[1-9x])$ ]]

Thanks for your help though

---------- Post added 05-13-15 at 12:01 PM ----------

Quote:

Originally Posted by millgates

How about using case?

Code:

while :; do
	read -p "Please select an above option : " res
	case "$res" in 
		1) echo "Option 1 Selected" ;;
		2) echo "Option 2 Selected" ;;
		# ...
		10) echo "Option 10 Selected" ;;
		*) break ;;
	esac
done

I actually slapped my head after reading this as not sure why i didnt use a case statement in the first place