[SOLVED] unexpected eof again...

jzoudavy · 08-12-2012, 05:19 PM

Hi all

I have this funny little script, its suppose to make me a tone of users. But right now I am getting an error about unexpected end of file. I am sure many of you have come across this before, and many people raising this question, god knows google certainly gave a ton of stuff to read through, but still nothing really fixed it.

Here is the code, I have removed a whole bunch of the actual user creation because I have already ruled them out. I removed those chunks, ran it again, and still got the same errors.

Code:

#******************************************************************************
#  
#  Usage: ./Add_Subscriber.sh user id  how many ids
#    e.g. ./Add_Subscriber.sh 4932782111000 10 will add 4932782111000-4932782111009
#
# Version PA1
#*****************************************************
i_loop=0
while [ $i_loop -lt $2 ]; do

i_subscriber=`expr $1 + $i_loop`

echo loop number: $i_loop
echo Writing subsriber: $i_subscriber
#removed a bunch of stuff here

i_loop=`expr $i_loop + 1`
done

any help you guys can provide I would really appreciated it.

I looked for extra CRs and etc, but still couldn't find anything.

the linux is running some kind of corporate modified suse 11.

i_joh · 08-12-2012, 05:30 PM

Worked for me. That is up to the start number 49327821110000000000. Then number out of range.

Edit: Worked in posix mode too, run with /bin/sh

jzoudavy · 08-12-2012, 07:03 PM

how did you run it? just

./Provision_Sub_skeleton_code.sh x y, x and y being whatever number?

cause I keep getting this:

./Provision_Sub_skeleton_code.sh
./Provision_Sub_skeleton_code.sh: line 24: syntax error: unexpected end of file

grail · 08-12-2012, 07:48 PM

Well I would have 2 questions for you:

1. The while test requires the second of 2 parameters to be passed in yet you run it with none?

2. The code you have presented does not have 24 lines, so what are you running?

chrism01 · 08-12-2012, 07:54 PM

Interesting, because I only count 18 lines in that code; are you SURE that's all of it??
Incidentally, try amending the top to

Code:

#!/bin/bash
set -xv
#******************************************************************************
#

ie enforce the shell you want to use and turn on debugging.

Also, do arithmetic using (( )); its more efficient and modern http://tldp.org/LDP/abs/html/arithexp.html

You can enforce *nix line endings with http://linux.die.net/man/1/dos2unix

HTH

jzoudavy · 08-12-2012, 08:59 PM

hi grail

missing lines are comments containing private information, which i can't really post on a public forum.

hi chrism01

I tried the !/bin/bash, I still get the same error about unexpected end of file.

Actually !/bin/bash gave an error about bad interpretor and I had to change it to ./bin/bash instead.
I also had to take out set -vx because it doesn't like the way I set the options, according to man i am suppose to use --, but that just gave me the same error.

sorry if I sound a bit short, this is the 3rd time i am typing this because the token keeps expiring.

Thanks for all your help guys.
Davy

jzoudavy · 08-12-2012, 09:09 PM

Hi guys

here is something interesting, i was reading the shell guide on tlpd and figured i would try this:

Proc_m1_s1# bash -posix Provision_Sub_skeleton_code.sh 12 1
+ i_loop=$'0\r'
Provision_Sub_skeleton_code.sh: line 26: syntax error: unexpected end of file

what is this 0\r?

grail · 08-12-2012, 09:30 PM

You have created the file in Windows and hence the unusual line endings are causing issues. See chrism01's link about dos2unix.

Also, the reason the bash section was causing you errors is you missed or mis-read chrism01's example and left off the leading #, the hash is required
as together with ! it tells the script which interpreter to use. I would suggest that without this being set correctly would be the reason why 'set' was
misbehaving for you.

jzoudavy · 08-12-2012, 09:33 PM

hi grail

the hash isn't the issue, both . and ! had the has in front of them.

I will try the dos2unix and get back to.

jzoudavy · 08-12-2012, 09:40 PM

hi grail

You might be onto something, cause i do use windows notepad++ and then upload it to the linux environment where it is run.

here is the output from dos2unix.exe, i have to run it on my PC's cygwin because the linux environment doesn't have it.

correction: i was using the wrong options, you have to use -n if you are writing to a new file.

so here goes nothing

jzoudavy · 08-12-2012, 09:46 PM

AND WE HAVE A WINNER!!!

i used the dos2unix and now the code works! this is awesome. If it fails i would have to create 1000 users by hand.

thanks a lot for your help guys

Davy

jzoudavy · 08-12-2012, 10:07 PM

hey, do i have to this everytime I use notepad++?

I mean, I use dos2unix to generate the new file, and use notepad++ to edit the new file, do I still have to dos2unix it afterwards?

grail · 08-12-2012, 11:37 PM

Depends on whether notepad++ overwrites any changes when you save and puts the windows line endings back in?

Simple test would be to change file you have run dos2unix on in notepad++ and then use cat -A in linux and see what the output is.
To check it is correct create a simple file on linux (echo word > test_file) and use the same cat -A

David the H. · 08-13-2012, 02:26 PM

notepad++ appears to have the ability to handle and convert line endings itself.

http://npp-community.tuxfamily.org/d...newline-format

jzoudavy · 08-13-2012, 03:47 PM

hi all

so i tried it, as in the modify with dos2unix and then use the notepad++ to edit it again.

I found that you do not have to run dos2unix again on the file.

But if its a brand new file, you might have to run the dos2unix.

Thanks for all your help guys.

Davy