Unexpected end-of-file error (bash script) - need another pair of eyes.
Linux - NewbieThis Linux forum is for members that are new to Linux.
Just starting out and have a question?
If it is not in the man pages or the how-to's this is the place!
Notices
Welcome to LinuxQuestions.org, a friendly and active Linux Community.
You are currently viewing LQ as a guest. By joining our community you will have the ability to post topics, receive our newsletter, use the advanced search, subscribe to threads and access many other special features. Registration is quick, simple and absolutely free. Join our community today!
Note that registered members see fewer ads, and ContentLink is completely disabled once you log in.
If you have any problems with the registration process or your account login, please contact us. If you need to reset your password, click here.
Having a problem logging in? Please visit this page to clear all LQ-related cookies.
Introduction to Linux - A Hands on Guide
This guide was created as an overview of the Linux Operating System, geared toward new users as an exploration tour and getting started guide, with exercises at the end of each chapter.
For more advanced trainees it can be a desktop reference, and a collection of the base knowledge needed to proceed with system and network administration. This book contains many real life examples derived from the author's experience as a Linux system and network administrator, trainer and consultant. They hope these examples will help you to get a better understanding of the Linux system and that you feel encouraged to try out things on your own.
Click Here to receive this Complete Guide absolutely free.
Unexpected end-of-file error (bash script) - need another pair of eyes.
I'm pretty much satisfied that all the i's have been dotted and the t's crossed, so far as if/fi, closed parentheses, in-out quotation marks and the like go. I just need another pair of eyes to be sure. My bash shell keeps insisting on there being a line 32 to this script, while nano, vim and the "cat foo.sh | wc -l" combo all agree with my GUI text editor (with which I wrote 98% of the script -- and yes it's been dos2unix'ed as well)-- there are only 31 lines!
Here's the script:
Code:
#!/bin/bash -x
echo -ne "Fixture Identification Fixer for Exiv2 - FIFE\n"
echo -ne "Please enter the name of the file you want to modify.\n"
read gfile
if [ -e $gfile ]
then
oldf1=$(exiv2 -PInv $gfile | grep 'FixtureId' | sed 's/^FixtureId[ ]*//')
echo -e "The word or phrase currently in this file reads: ${oldf1}.\n"
echo -ne "Do you want to change this Fixture ID to something else? y/n \n"
read yesorno
if [ $yesorno = "n" ]
then
echo -ne "No changes made to file ${gfile}\.\n"
else
echo "Are you sure? y/n "
read confirmm
if [ $confirmm = "n" ]
then
exit 1;
else
exiv2 -M"del Iptc.Application2.FixtureId" modify $gfile
echo -e "The old FixtureID has been removed."
echo -ne "Please enter the word or phrase to replace '$oldfi .'\n"
read newstringhx
exiv2 -M"add Iptc.Application2.FixtureId String $newstringhx" modify $gfile
sleep 1
echo -ne "The new phrase, \"$newstringhx\",\n has been written to file \033[37;40m${gfile}.\033[0m\n"
fi
fi
else
echo -e "Sorry, that file is not in this folder."
You might notice one if without an fi. Everytime I add it back, I get an "unexpected token" error for it and its line. So there's got to be some other punctuation or complementary code missing somewhere.
Hope someone finds whatever it is, and can point it out to me. No sweat off my knee if it was something I couldn't see (rhyme unintended).
I thought that approach, double-brackets, would be the way to go about it, too. I've found that they do prevent errors of a few types in other scripts. Good to have a reminder.
I apologize for the duplicate thread. I'm not certain as to how it occurred, but I suspect it may have been due to a double-login on my part, ie, closing a window with the site (and the original thread) in it and not waiting for the customary timeout before logging back in while viewing another thread (which link opened via Google or some item in my browser history). I'll do what I can to add only to this thread, unless doing so makes deleting its twin more difficult. I'd appreciate your advice on how to proceed.
LinuxQuestions.org is looking for people interested in writing
Editorials, Articles, Reviews, and more. If you'd like to contribute
content, let us know.