[SOLVED] Shell scripting help- unexpected fi

akifennec · 11-11-2012, 11:30 PM

Im writing a script for a shell scripting class and I'm running into a unexpected fi problem and could use some help. heres the script

Code:

#!/bin/bash
set v = menu
clear
read -p "Please Enter your name " name
read -p "Enter your birth year.  Example: 1900 : "year
yearnow=$(date '+%Y')
agey=$(($yearnow-$year))
if [ $agey -lt 18 ] ; then
          echo "Sorry $name , you must be at least 18."
else

while : do
clear
        cat menu
        read -p "pick from above " choice
        if [ $choice -eq x ] ; then
                break
else
           set z = 1 # the counter

case "$choice" in
L)
clear
                set z = $z + 1
echo "Select field to cut form 'last' add comma to add multiple fields (x to quit)"
read value1
if [[ $value1 == x ]]; then exit;fi
echo "Select first row"
read value2
echo "Select last row "
read value3
last | tr -s ' ' ' ' | cut -d' '  -f"$value1" | tail -n +$value2 | head -n $value3
;;

U)
clear
set $z = $z + 1
who
read -p "Heres who's online line who do you want more info on? " name1
finger $name1
;;


esac
fi
fi
echo "$name"

I know there might be other things wrong but Id only like help with the if problem please

evo2 · 11-11-2012, 11:49 PM

Hi,

welcome to LQ. When posting questions, please post the *exact* error message. Also, it would be *much* easier to read your code it you indented it properly. In fact, I suspect that if your code was indented correctly, you might be able to see the problem yourself.

Evo2.

akifennec · 11-12-2012, 12:02 AM

the error I'm getting is line 51: syntax error near unexpected token `fi'

code with better formatting

Code:

else
#!/bin/bash
set v = menu
clear

read -p "Please Enter your name " name
read -p "Enter your birth year.  Example: 1900 : " year
yearnow=$(date '+%Y')
agey=$(($yearnow-$year))

if [ $agey -lt 18 ] ; then
        echo "Sorry $name , you must be at least 18."
else

while : do
        clear
        cat menu
        read -p "pick from above " choice
                if [ $choice -eq x ] ; then
                        break
                else
                        set z = 1 # the counter

                        case "$choice" in

                                L)
                                        clear
                                        set z = $z + 1
                                        echo "Select field to cut form 'last' add comma to add multiple fields (x to quit)"
                                        read value1
                                                if [[ $value1 == x ]]; then
                                                        exit;
                                                fi
                                        echo "Select first row"
                                        read value2
                                        echo "Select last row "
                                        read value3
                                        last | tr -s ' ' ' ' | cut -d' '  -f"$value1" | tail -n +$value2 | head -n $value3
                                        ;;

                                U)
                                        clear
                                        set $z = $z + 1
                                        who
                                        read -p "Heres who's online line who do you want more info on? " name1
                                        finger $name1
                                        ;;


                        esac
                fi
fi

echo "$name"

I don't see any unaccounted for if or fi

catkin · 11-12-2012, 12:24 AM

The while : do is not terminated (rigorous indentation would have identified that).

if [ $choice -eq x ] will not work because -eq is an arithmetic comparison operator and x is not an integer.

bash variables are not set by the likes of set v = menu

Code:

c@CW9:~$ set v = menu
c@CW9:~$ echo $v

c@CW9:~$ echo $1 $2 $3
v = menu
c@CW9:~$ v=menu
c@CW9:~$ echo $v
menu

Debugging is easier without the interactive prompts and with the clear commands commented out

Code:

#read -p "Please Enter your name " name
name=foo
#read -p "Enter your birth year.  Example: 1900 : " year
year=1990
...
    #clear

chrism01 · 11-12-2012, 01:40 AM

I also suspect this is not what you meant

Code:

else
#!/bin/bash

to help debug, try adding 'set -xv' thus

Code:

#!/bin/bash
set -xv

NB: the shebang line ( #!/bin/bash ) MUST be the first line in a shell script.

Handy links
http://rute.2038bug.com/index.html.gz
http://tldp.org/LDP/Bash-Beginners-G...tml/index.html
http://www.tldp.org/LDP/abs/html/

konsolebox · 11-12-2012, 02:47 AM

Also 'while : do' should be 'while :; do'.

I also suggest variables to be closed from IFS parsing. e.g. command "$abc" ...

akifennec · 11-12-2012, 08:41 AM

don't know how the else got there its not in my code. but thank you i missed indenting the while statement and see that I was miss "done"

Thank you all for the help