[SOLVED] Seeking advice with shell script (homework)

BW-userx · 04-07-2016, 11:06 AM

Quote:

Originally Posted by sobey

Code:

 -bash-3.2$ sed -ri .s/(.* )1/1/g. Gasoline
-bash: syntax error near unexpected token `('

Code:

sed -ri 's/(.* )1/1/g'

quotes so that the system sees it as one complete argument.

michaelk · 04-07-2016, 11:16 AM

That will fix the syntax error but will not give the expected results.

Code:

 sed -ri 's/(.* )\1/\1/g' gasoline

sobey · 04-07-2016, 11:20 AM

I have been working on this in the background, below is what I have compiled thus far, any thoughts?

Code:

#!/bin/bash
# Bash TestScript

#a. Remove punctuation; #b. Make all characters lowercase
tr -d '[:punct:]' < Gasoline | tr '[:upper:]' '[:lower:]' tee ScriptResults


#c. Put each word on a line by itself
tr ' ' '\n' < gasoline



#d. Remove blank lines; #e. Sort the text to pull all lines containing the same word on adjacent lines; #f. Remove duplicate words from the text
sed '/^$/d' | sort | uniq -c




#g. List most used words in the file first
cat ScriptResults | tr ' '  '\012' | tr '[:upper:]' '[:lower:]' | tr -d '[:punct:]' | grep -v '[^a-z]' | sort | uniq -c | sort -rn | head

exit 0

BW-userx · 04-07-2016, 12:07 PM

it doesn't exit it hangs in the terminal on mine NE ways.

sobey · 04-07-2016, 01:05 PM

Quote:

Originally Posted by BW-userx

it doesn't exit it hangs in the terminal on mine NE ways.

To prevent it from hanging would exit 0 work or would I need to input something else?

sobey · 04-07-2016, 01:26 PM

I think I am close, the command sequence below (I am assuming as I have not tried it in pyrite yet)will complete steps A - E...A second pair of eyes would be helpful with my assumption.

Code:

tr -d '[:punct:]' < Gasoline | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < gasoline | sed '/^$/d' | sort | uniq -c tee ScriptResults

michaelk · 04-07-2016, 01:27 PM

gasoline should only appear once as input.

BW-userx · 04-07-2016, 02:23 PM

it is still hanging on me. it is like this one almost works. So is that cheeting????

reference you're work and this page

Code:

#!/bin/bash
cat gas | tr -ds [:upper:]  [:lower:] | tr ' ' '\n' > ScriptResults | sed '/^$/d' ScriptResults

mod: scrap my idea ..

sobey · 04-07-2016, 02:52 PM

Quote:

Originally Posted by BW-userx

it is still hanging on me. it is like this one almost works. So is that cheeting????

reference you're work and this page

Code:

#!/bin/bash
cat gas | tr -ds [:upper:]  [:lower:] | tr ' ' '\n' > ScriptResults | sed '/^$/d' ScriptResults

mod: scrap my idea ..

I am going to try the script below and name it TestScript, would running it like this still hang?

Code:

#!/bin/bash
# Bash TestScript

tr -d '[:punct:]' < Gasoline | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < gasoline | sed '/^$/d' | sort | uniq -c | sort -rn tee ScriptResults

exit 0

BW-userx · 04-07-2016, 02:58 PM

Quote:

Originally Posted by sobey

I am going to try the script below and name it TestScript, would running it like this still hang?

Code:

#!/bin/bash
# Bash TestScript

tr -d '[:punct:]' < Gasoline | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < gasoline | sed '/^$/d' | sort | uniq -c | sort -rn tee ScriptResults

exit 0

try just this without the exit 0 tell me what you think
this seperates that 20week to make it,
20
week

it was really bugging me so I worked it out for ya.

Code:

#!/bin/bash
cat gasoline | tr -s ", -" " " |  tr ' ' '\n'  | tr '[:upper:]' '[:lower:]' > ScriptResults | sed '/^$/d' ScriptResults ScriptResults

I took it one tr command at a time, then rearranged them in a different order of operation.

first I remove the punctuation putting a space in place of it to get that 20word to 20 word, so I an put each one on a new line each, then change the caps to lower case. then put it into another file, then send it to sed to print out on the screen, I have no idea what that sed command actually does, I don't play with sed, nor tr ... I only learn what I have to as I go to get my scripts to work to do what I actually need them to do. more real world applications in my experience.

don't you still have to get a count of like words per your original post?

http://www.linuxquestions.org/questi...rk-4175485733/

grail · 04-07-2016, 04:17 PM

I have read the specifications again. If you follow them exactly in order (as I am guessing your teacher has as she wrote them), it is possible to deliver the output required.

Below is the list of command in order without the what-to-do:

Code:

tr | tr | tr | sed | sort | uniq | sort

Using the above order I was able to generate the following output:

Code:

      2 a
      2 prices
      1 20
      1 an
      1 continuing
      1 gallon
      1 gas
      1 half
      1 in
      1 mostly
      1 of
      1 only
      1 past
      1 penny
      1 rose
      1 steady
      1 the
      1 trend
      1 two
      1 unusual
      1 week
      1 weeks

sobey · 04-07-2016, 07:49 PM

Thank you all especially Grail and BW-Userx your help on this has been great. Below is the code string (script) I used which gave the results needed. At first I used the tee ScriptResults and it gave an error so I removed the tee with the > symbol and it worked without errors. This has been a true learning experience, I was over complicating the whole thing, a lack of understanding in this OS for sure... Again thank you.

Code:

#!/bin/bash
# Bash TestScript

tr -d '[:punct:]' < Gasoline | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < Gasoline | sed '/^$/d' | sort | uniq -c | sort -rn > ScriptResults

exit 0

michaelk · 04-07-2016, 07:58 PM

FYI the second < Gasoline (tr ' ' '\n' < Gasoline) is not necessary since your piping the output from the previous command. Would not want you to lose points...

BW-userx · 04-07-2016, 08:04 PM

data:

Quote:

Gas Prices Rose Only half a penny a, gallon in the Past two weeks, continuing an unusual 20-week trend of mostly steady prices

results:

Quote:

1 weeks,
1 unusual
1 two
1 trend
1 the
1 steady
1 prices
1 penny
1 of
1 mostly
1 in
1 half
1 gallon
1 continuing
1 an
1 a,
1 a
1 Rose
1 Prices
1 Past
1 Only
1 Gas
1 20-week

command:

Code:

# punctuation are still there the , and - ?
tr -d '[:punct:]' < gas | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < gas | sed '/^$/d' | sort | uniq -c | sort -rn > ScriptResults

#Capitalization is still there too.

try it without the exit 0 that is something that should not even be needed in a script like this.

think about the order in which you preform each step of the complete operation.

preforms one operation then pipes the results into the next operation in the format that the last operation performed on the data.

is it just me ? I don't know.

sobey · 04-07-2016, 08:14 PM

Quote:

Originally Posted by BW-userx

data:

results:

command:

Code:

# punctuation are still there the , and - ?
tr -d '[:punct:]' < gas | tr '[:upper:]' '[:lower:]' | tr ' ' '\n' < gas | sed '/^$/d' | sort | uniq -c | sort -rn > ScriptResults

#Capitalization is still there too.

like the other said only need to redirect the file into it once. No I am not even giving up that answer.

try it without the exit 0 that is something that should not even be needed in a script like this.

think about the order in which you preform each step of the complete operation.

Did the recommended changes and you were correct the exit 0 and the second > Gasoline part was not needed... Again thank you.