Scripting help

abrandnewday · 04-18-2013, 09:10 PM

i need help with the user input, i have to have the user enter two numbers and store them for later use, this is what i have

#!/bin/bash

if [ $# -eq 0 ]
then
echo "Please enter two intergers"
read number number1
fi

if [ $# -ne 2 ]
then
echo "Not enough intergers, please enter two intergers"
read number number1
fi

shivaa · 04-18-2013, 10:12 PM

What exactly you want to do and where you're stuck?

In your case, read will not store two input numbers, so use 2 read statements for each number as:

Code:

#!/bin/bash
if (( $# -eq 0 ))
 then
 echo "Please enter first integer"; read number1
 echo "Please enter second integer"; read number2
 fi
if (( $# -ne 2 ))
 then
 echo "Not enough intergers, please enter two integers"
 echo "Not enough intergers, please enter first integer"; read int1
 echo "Not enough intergers, please enter second integer"; read int2
 fi

FYI, $# holds number of arguments specified on command line.

abrandnewday · 04-18-2013, 10:50 PM

I then need to take number1 and number2 from user imput and have a while loop print the numbers in between number1 and number2

chrism01 · 04-19-2013, 12:44 AM

In that case you need to write some code and see how far you get.
Post back with the code if you get stuck.
I'd advise you to bookmark & read these, they'll give you all the info you need
http://rute.2038bug.com/index.html.gz
http://tldp.org/LDP/Bash-Beginners-G...tml/index.html
http://www.tldp.org/LDP/abs/html/

shivaa · 04-19-2013, 01:37 AM

Quote:

Originally Posted by abrandnewday

I then need to take number1 and number2 from user imput and have a while loop print the numbers in between number1 and number2

Post your full script, if it's possible. Also mention that where you are stuck at.

salasi · 04-19-2013, 05:24 AM

Quote:

Originally Posted by abrandnewday

i need help with the user input, i have to have the user enter two numbers and store them for later use, this is what i have

#!/bin/bash

if [ $# -eq 0 ]
then
echo "Please enter two intergers"
read number number1
fi

if [ $# -ne 2 ]
then
echo "Not enough intergers, please enter two intergers"
read number number1
fi

When putting forward code, please use code tags (see shivaa's first post). It is easier to read and just generally helpful.
They would be 'integers' and not 'intergers'
How do you intend to test that what is entered is (1 or 2) integers, and what do you intend to do if you get other than integer input?

David the H. · 04-21-2013, 12:59 PM

Quote:

Originally Posted by shivaa

What exactly you want to do and where you're stuck?

In your case, read will not store two input numbers, so use 2 read statements for each number as:

This is incorrect. read can indeed store multiple values at once, with the individual words split by the current value of IFS. If you enter fewer words than the number of variables, then the extra variables will be empty, and if you enter more, then the final variable will contain all the extra text. Use the "-a" option to create an array that will expand to hold as many words as entered.

Code:

read -r -p 'Enter two words: ' word1 word2
echo "Word 1 is \"$word1\""
echo "Word 2 is \"$word2\""

IFS=: read -r -p 'Enter three words, separated by colons: ' word1 word2 word3
echo "Word 1 is \"$word1\""
echo "Word 2 is \"$word2\""
echo "Word 3 is \"$word3\""

read -r -p 'Enter as many words as you want: ' -a words
for ((i=0; i<${#words[@]}; i++ )); do
    echo "Word $(( i + 1 )) is \"${words[i]}\""
done

However, using multiple reads does let you provide more feedback to the user and hopefully control the input a little better.

Finally, prompts for user input are often embedded in continual loops so that you can ensure that you're getting what you want before you use it.

Code:

while true; do
    read -r -p 'Enter a single lower-case word: ' word

    case $word in
        *[^a-z]*) echo 'The word must only contain "a-z". Try again.'
                  continue     
               *) echo "Entry accepted.  You chose \"$word\""
                  break ;;
    esac

done