SCP Playlist Script to local machine.

qkzoo · 10-22-2017, 01:46 PM

My goal is to have a script that reads a playlist file (.m3u), reads each line, then downloads that file to a folder on my local machine over SSH.

I found a script online that does this using cp instead of SCP, so I adapted it a little, but it's not working, and I'm not script savvy.

Code:

#!/bin/bash
grep -v '#' 5_Star.m3u | tr -d '\r' |while read line ; do scp pi@192.168.1.2:"/media/mypassport$line" "/home/andrew/temp/" ; done

It appears to me that the spaces in the filenames are breaking the script, as I see a lot of this:

Code:

scp: /media/mypassport/music/Collective: No such file or directory
scp: Soul: No such file or directory

...the folder name is "Collective Soul...", so it looks like it's splitting after each space?

Can anybody offer some additions to make this script work properly?

ondoho · 10-22-2017, 02:11 PM

test the script with

- adding 'set -x' just under #!/bin/bash

and

- prepending 'echo' before scp

show us.

frankbell · 10-22-2017, 08:17 PM

This link discusses ways of replacing the spaces in the file names with underscores using scripting: https://stackoverflow.com/questions/...-a-bash-script

michaelk · 10-23-2017, 10:25 AM

Although the hint about using set -x should provide some help on what might be happening it may not be obvious.

bash will strip the quotes before the scp command runs so spaces are not escaped on the server. Basically you need to double quote the spaces.

Without seeing the exact playlist try

Code:

scp pi@192.168.1.2:/media/mypassport/""$line"" /home/andrew/temp/

qkzoo · 10-23-2017, 08:17 PM

After running -set x and adding the echo, plus the quotes, here is what I get:

Quote:

+ read line
+ echo scp pi@192.168.1.2:/media/mypassport/music/The Pretty Reckless - Going To Hell/07 - The Pretty Reckless - Absolution.mp3 /home/andrew/temp/
scp pi@192.168.1.2:/media/mypassport/music/The Pretty Reckless - Going To Hell/07 - The Pretty Reckless - Absolution.mp3 /home/andrew/temp/

Looks like the spaces aren't escaped?

michaelk · 10-23-2017, 08:39 PM

Your correct I messed up my quotes...

Code:

scp pi@192.168.1.2:/media/mypassport/"'$line'" /home/andrew/temp/

qkzoo · 10-23-2017, 09:43 PM

That worked with the spaces. Some characters are still breaking, i.e., the single quote ' and the ampersand & broke quite a few track titles. Any suggestions on those?

michaelk · 10-23-2017, 10:15 PM

Post the exact path/title.

Sometimes as frankbell suggested it is easier to change the name...

chrism01 · 10-23-2017, 11:44 PM

I always change the names of files like that, even if it's only temp for processing in a *nix system.
Otherwise you're always having to fool around with every cmd... just too hard.
I use underscores instead of spaces, remove quotes. Ampersands I think are safe if surrounded by other (non-whitespace) chars.

ondoho · 10-24-2017, 01:32 AM

is that a quirk of scp?
i really can't see anything wrong with the syntax used in post #1.
i'm sure it would have worked with a normal cp command?

michaelk · 10-24-2017, 06:24 AM

Does seem to be a "quirk" of ssh/scp and your correct it should of worked if just using a normal cp command.

Another option which might work better is to create a sftp batch file. While more complicated you should not have to deal with all the exceptions.

qkzoo · 10-24-2017, 10:19 PM

Quote:

Originally Posted by chrism01

I always change the names of files like that, even if it's only temp for processing in a *nix system.
Otherwise you're always having to fool around with every cmd... just too hard.
I use underscores instead of spaces, remove quotes. Ampersands I think are safe if surrounded by other (non-whitespace) chars.

If I had started my library like that it would be an option, but I have over 400 albums I've scanned into my library and really don't want to have to go back and fix everything. I did find a solution here, check this out:

Code:

#!/bin/bash
# set -x
#grep -v '#' 5_Star.m3u | tr -d '\r' |while read line ; do scp pi@192.168.1.2:/media/mypassport"'$line'" /home/andrew/temp/ ; done
grep -v '#' 5_Star.m3u | tr -d '\r' |while read line ; do scp pi@192.168.1.2:/media/mypassport"$(printf '%q' "$line")" /home/andrew/temp/music/ ; done

Not exactly sure why it works, but it did. I had only 1 album that didn't go through, and still not sure why, as there were no funky characters in the filename, but since it was only 1, I was able to copy that over manually.

Would there be a way to tell this script to skip a file if it already exists on the local computer, just to jazz it up and make this script so I could use it to update my local files?

chrism01 · 10-24-2017, 11:11 PM

It is fairly easy to script the name changes, and you only need to write that program once.
You can re-use it if/when you need it again.
(eg any time you bring in files from MSWin if you write it generically)
After running it, you'll never have to worry again for those (renamed) files.

Re your other qn, see rsync eg https://www.tecmint.com/rsync-local-...tion-commands/

qkzoo · 10-25-2017, 08:41 PM

Quote:

Originally Posted by chrism01

It is fairly easy to script the name changes, and you only need to write that program once.
You can re-use it if/when you need it again.
(eg any time you bring in files from MSWin if you write it generically)
After running it, you'll never have to worry again for those (renamed) files.

Re your other qn, see rsync eg https://www.tecmint.com/rsync-local-...tion-commands/

I might check out a solution for renaming. As for the rsync solution, is there a maximum for the number of includes you can use with it? My one playlist has 455 songs in it, so if I was piping each filename to a single rsync command it would be a very large command! My music library is not everything just all jumbled in a single folder, it's all organised by artist/album title and then every song for that album is in that folder, even ones I don't really listen to. I wouldn't want to rsync those to my local pc.

ondoho · 10-26-2017, 01:03 AM

personally, i can see the need for what qkzoo has scripted, and i would be against touching these filenames.
because new ones are added all the time (at least that's how it is with me), media servers rely on the names (and think there's new files if you rename them), the order of files (i.e. songs) is sometimes defined by those names etc...
since a usable workaround exists, i wouldn't touch the filenames.