Returning Strings

isdigit · 12-24-2009, 10:47 PM

Code:

#!/bin/bash

ActivateMonitoring() {

echo -n "Enter device: "
read Device
xterm -e ifconfig $Device down
xterm -e macchanger -A $Device
xterm -e ifconfig $Device up
xterm -e airmon-ng stop $Device
xterm -e airmon-ng start $Device

echo -n "Any more[y/n]? "
read Decision
if [[ $Decision == 'y' ]]; then
{
ActivateMonitoring
}
else
echo 
echo  "Monitoring mode Configured"
fi

return '$device'
}
s=""
ActivateMonitoring = s
echo $s


exit 0

I am trying to get the function ActivateMonitoring to return a string, so I can use a global variable and then in return, use it as input for new functions. But, when I try by by doing ActivateMonitoring = s, I get an error of: $s: numeric argument required. And, when I try to set it as s = ActivateMonitoring, another error comes up saying s is not a function. (Obviously; Im just trying things).

ghostdog74 · 12-24-2009, 11:10 PM

why do you have a space between the "=" sign? to get the return value,

Code:

var=$(ActivateMonitoring)

isdigit · 12-24-2009, 11:53 PM

Quote:

Originally Posted by ghostdog74

why do you have a space between the "=" sign? to get the return value,

Code:

var=$(ActivateMonitoring)

I do it because it is easier to read, and I normally code in C. Bash, as I am becoming to see, can be tedious. Thanks, but either way, functions only return numerical values so the return would not have worked stopping the script before var=${ActivateMonitoring}

catkin · 12-25-2009, 12:05 AM

What does "it stops on the last bracket in Menu" mean? What are the symptoms? It would be helpful if you could also post what you see at the command prompt when you run the script.

ghostdog74 · 12-25-2009, 12:05 AM

Quote:

Originally Posted by isdigit

I do it because it is easier to read, and I normally code in C. Bash, as I am becoming to see, can be tedious.

not really. you can't have spaces when you declare variables

Quote:

Thanks, but either way, functions only return numerical values so the return would not have worked stopping the script before var=${ActivateMonitoring}

not really either. Function return numerical values , true, but you can "return" strings if you like, using echo/printf and then "catching" it from main.

here's how i would do it, using infinity loop

Code:

while true
do
cat <<EOF
1) this is option 1
2) this is option 2
3) Exit
EOF
  read -p "Enter your choice" choice
  case "$choice"in    
    1) echo "do something";;
    2) echo "do something";;
    3) exit;;
    *) echo "try again";;
  esac
done

isdigit · 12-25-2009, 12:39 AM

Yes, I see what you mean by calling it outside in main. I did the same thing to my situation before your post, it resembled this:

Code:

#!/bin/bash

Function() {
echo "hello enter some junk: "
read junk
}

Function
echo $junk

exit 0

isdigit · 12-25-2009, 12:52 AM

Edit: oops