[SOLVED] Problem with shell script

agent_mach · 11-24-2017, 01:58 PM

Hello Gurus/Experts,

I started working on shell scripting recently, and drafted a attached shell script which can be run on both RHEL versions i.e. 6.x and 7.x.

But while running this script i am getting below errors:

Code:

[root@rhel74 ~]# ./Demo-PreReq-RHEL.sh
./Demo-PreReq-RHEL.sh: line 10: [: missing `]'
./Demo-PreReq-RHEL.sh: line 24: [: too many arguments
./Demo-PreReq-RHEL.sh: line 34: [: missing `]'
Redirecting to /bin/systemctl restart sshd.service
./Demo-PreReq-RHEL.sh: line 54: [: missing `]'
Redirecting to /bin/systemctl stop firewalld.service
./Demo-PreReq-RHEL.sh: line 84: [: too many arguments
./Demo-PreReq-RHEL.sh: line 113: [: missing `]'
24 Nov 14:32:23 ntpdate[24612]: the NTP socket is in use, exiting
     remote           refid      st t when poll reach   delay   offset  jitter
==============================================================================
 xx.xx.xx.xx .INIT.          12 u    -  51    0    0.000    0.000   0.000
 xx.xx.xx.xx   .INIT.          12 u    -  51    0    0.000    0.000   0.000
./Demo-PreReq-RHEL.sh: line 180: [: missing `]'

It would be really great if someone can point me out what exactly i am missing here.

Script is copied in the attached txt file.

Thanks in advance.

GazL · 11-24-2017, 02:42 PM

You need a space before the closing ']'.

giis · 11-24-2017, 10:46 PM

On few places you are using correct spacing like

Quote:

if [ $get_DNS = $DNS ]

and others are wrong

Quote:

if [ ! -f /etc/redhat-release]

As other member mentioned you need to add missing space before ]

agent_mach · 11-25-2017, 02:23 AM

Thanks GazL/giis for pointing out the problem. I corrected that and now i am not seeing "./Demo-PreReq-RHEL.sh: line 10: [: missing `]'" issue.

But i am still seeing below error:

./Demo-PreReq-RHEL.sh: line 24: [: too many arguments
./Demo-PreReq-RHEL.sh: line 84: [: too many arguments

is there any issue with below block of code :

Code:

# Checking RHEL versions

rhel6="cat /etc/redhat-release | grep -o 6"
rhel7="cat /etc/redhat-release | grep -o 7"
OS_VER=""

if [ $rhel6 = 6 ]         ==> 24th line
	then
	OS_VER=6
else
	OS_VER=7
fi

And

Code:

# Enable NTP to sync time from "ntp.demo.net"

DNS="10.100.105.11"
get_DNS="cat /etc/resolv.conf | grep -o 10.100.105.11"

if [ $get_DNS = $DNS ]          ==> 84th line
	then
	echo "DNS $DNS is configured."	
else
	echo "nameserver 10.100.105.11" >> /etc/resolv.conf
fi

Thanks.

agent_mach · 11-25-2017, 03:35 AM

Anyways i have figured out the error i made ... it should be like this

rhel6=`cat /etc/redhat-release | grep -o 6`
rhel7=`cat /etc/redhat-release | grep -o 7`

Thanks a lot for the help guys.

-Ashish

pan64 · 11-25-2017, 04:29 AM

this is a bit overcomplicated:

Code:

#instead of:
cat file | grep pattern
#just use
grep pattern file

Next, you can try www.shellcheck.net to check your script. This will also help you to write better code.
you can do something like this too:

Code:

grep -q 6 /etc/redhat-release && OS_VER=6