[SOLVED] printf in nested for/while loop not working

samasat · 11-30-2016, 05:58 AM

@pan64

Quote:

Is this what you are looking for?

Since some of the keywords are common in both setA and setB, I don't think this approach will work. e.g. setA could choose from { Mary|John, Left|Right, Eye|Ear} and setB could choose from{ John|Joseph, Left|Right, Hand|foot}

samasat · 12-01-2016, 12:16 AM

@pan64

Quote:

you only need to remove the files from the list where both keyA and keyB can be found.

Is this what you are looking for?

I don't think this will work since some of the words are common in both the sets. e.g. setA belongs to {John|Mary, Right|Left, Eye|Ear} and setB belongs to {Mary|Amit, Right|Left, Hand|Foot}
If above approach is followed setA=[John,Right,Eye] will never form a pair with setB=[Amit,Right,Hand]
Also, I don't see how pairs would have been formed by the approach you suggested.

pan64 · 12-01-2016, 04:22 AM

so you need to tweak that grep in the middle. Probably and awk/perl/python would be better to filter (select the required lines) and also you may mark them (in a second column for example).
Actually you will have a lot of pairs, because all of the lines of keyA1 & keyA2 will be paired to all the lines of keyB1 and keyB2 below that line (I hope you understand what I wanted to explain)

samasat · 12-02-2016, 10:44 AM

So here is the final working code for me which is almost similar to what MadeInGermany said earlier.

Code:

opFile="FilePairs.txt"
rm -rf $opFile

find . -name "*txt" -path "*keyA1/*" -path "*keyA2/*" > tmpfileA.txt
find . -name "*txt" -path "*keyB1/*" -path "*keyB2/*" > tmpfileB.txt

while read -r fileA
do
     while read -r fileB
     do     
         if [[ "$fileA" < "$fileB" ]] ; then
            printf '%s %s \n' "$fileA" "$fileB"
         fi
     done < tmpfileB.txt >> $opFile;
done < tmpfileA.txt

Difference compared to my old approach is that:
1) The find command output was saved separately
2) While loop read in Lines from there
3) Important - earlier I used to run bash script as a command and I used to redirect terminal output to the intended output file like this:

Code:

>> ./myScript.sh > FilePairs.txt

Now as suggested by MadeInGermany the redirection is directly happening from the end of the inner while loop.

NOTE - the blank spaces in the if statement condition [[ "$fileA" < "$fileB" ]] are important

Thanks everyone

MadeInGermany · 12-02-2016, 12:00 PM

If you do not print anything in the outer loop then you can move the $opFile redirection to the outer loop.
And if you overwrite it with > then you don't need to rm it.

Code:

opFile="FilePairs.txt"

find . -name "*txt" -path "*keyA1/*" -path "*keyA2/*" > tmpfileA.txt
find . -name "*txt" -path "*keyB1/*" -path "*keyB2/*" > tmpfileB.txt

while read -r fileA
do
     while read -r fileB
     do     
         if [[ "$fileA" < "$fileB" ]] ; then
            printf '%s %s \n' "$fileA" "$fileB"
         fi
     done < tmpfileB.txt
done < tmpfileA.txt > $opFile

samasat · 12-05-2016, 11:57 PM

Thank you MadeInGermany. I appreciate all your help.