Introduce working "break" to terminate script (bash)

L_Carver · 07-02-2017, 11:24 AM

The script is as follows:

Code:

#!/bin/bash
#The script below came from:
#http://stackoverflow.com/questions/14350556/creating-a-calculator-script

PS3="what's the operation? "
declare -A op=([add]='+' [subtract]='-' [multiply]='*' [divide]='/')

while true; do
    read -p "what's the first number? " n1
    read -p "what's the second number? " n2
    select ans in "${!op[@]}"; do
        for key in "${!op[@]}"; do
            [[ $REPLY == $key ]] && ans=$REPLY
            [[ $ans == $key ]] && break 2
        done
        echo "invalid response"
    done
    formula="$n1 ${op[$ans]} $n2"
    printf "%s = %s\n\n" "$formula" "$(bc -l <<< "$formula")"
done

In the past, I have been able to introduce a conditional (testing for x as input) that exits the script and returns to prompt. Since downloading the above from the page mentioned in line 3 about four weeks ago, that didn't work so I removed it.

I'd like to write an "if/then" back in that will work.

Carver

michaelk · 07-02-2017, 12:23 PM

Looks like you forgot the $

Code:

if [ $n1 == "x" ]; then exit 0; fi

You can always add set -xv to aid in debugging...

Shadow_7 · 07-02-2017, 01:22 PM

You might add an initial echo $0 to verify that it's running under bash. Things like debian have a default shell of dash these days. So if you run the script by $(sh script.sh) then that's dash, not bash. But if you run it by $(./script.sh) it will observe the shebang statement #!/bin/bash and run it under bash.

edit: or echo $SHELL as $0 will likely return the script name. YMMV