[SOLVED] Help Bash script for HISTTIMEFORMAT

MienMatrix · 06-23-2022, 11:41 AM

Hello World,
i'm developing bash script to insert HISTTIMEFORMAT into /etc/profile to activate date and time in history file for all users linux starting from a server to all server of DataCenter.
I done some proofs but statemente echo send error: i put script follow:

Code:

#!/bin/bash
> /tmp/histDateTime.sh
i=/tmp/server_list.txt
c="cp /etc/profile /etc/profile_bck"
d="echo 'export HISTTIMEFORMAT="%d/%m/%y %T"' >> /etc/profile"
cat $i | while read A
do

cat <<EOF >> /tmp/histDateTime.sh
ssh $A "$c" ;"$d" 

EOF
done
sh /tmp/histDateTime.sh

I think also use some variable to separate data as:

Code:

#!/bin/bash
> /tmp/histDateTime.sh
i="/home/user/scripts/asset.csv"
c="cp /etc/profile /etc/profile_bck"
d=('export HISTTIMEFORMAT="%d/%m/%y %T"')
e="/etc/profile"

cat $i | while read A
do
ssh $A "$c" ; "$d" >> "$e"

but this goes error too :_(

I'm sure to not be master in bash script, so please if you can give me help i thank you forever.

Best regards
Enrico

pan64 · 06-23-2022, 12:00 PM

Code:

#!/bin/bash
echo "cp /etc/profile /etc/profile_bck" > /tmp/script
echo "echo 'export HISTTIMEFORMAT=\"%d/%m/%y %T\"' >> /etc/profile" >> /tmp/script

while read A
do
    cat /tmp/script | ssh $A /bin/bash
done < /tmp/server_list.txt

something like this may work (not tested)

SlowCoder · 06-23-2022, 12:12 PM

Quote:

Originally Posted by MienMatrix

d="echo 'export HISTTIMEFORMAT="%d/%m/%y %T"' >> /etc/profile"

try

Code:

d="echo -e 'export HISTTIMEFORMAT=\"%d/%m/%y %T\"' >> /etc/profile"

michaelk · 06-23-2022, 01:24 PM

It might help knowing what distribution is running on the servers.

I would create a file that contains your export command and then transfer it to the server's /etc/profile.d directory versus appending the command to the /etc/profile file.

You do have to log into the server as root or run a sudo command if your remote user has sudo privileges but it gets a little tricky if you need to be able to enter your password.

You also need a space following the %T i.e

Code:

export HISTTIMEFORMAT="%d/%m/%y %T "

MienMatrix · 06-24-2022, 05:01 AM

Quote:

Originally Posted by pan64

Code:

#!/bin/bash
echo "cp /etc/profile /etc/profile_bck" > /tmp/script
echo "echo 'export HISTTIMEFORMAT=\"%d/%m/%y %T\"' >> /etc/profile" >> /tmp/script

while read A
do
    cat /tmp/script | ssh $A /bin/bash
done < /tmp/server_list.txt

something like this may work (not tested)

Thanks Pan64 for replay, i try it and then reply.. Stay tuned XD

edit: "A" is A=/tmp/server_list.txt right?

MienMatrix · 06-24-2022, 05:11 AM

Quote:

Originally Posted by michaelk

It might help knowing what distribution is running on the servers.

I would create a file that contains your export command and then transfer it to the server's /etc/profile.d directory versus appending the command to the /etc/profile file.

You do have to log into the server as root or run a sudo command if your remote user has sudo privileges but it gets a little tricky if you need to be able to enter your password.

You also need a space following the %T i.e

Code:

export HISTTIMEFORMAT="%d/%m/%y %T "

Thanks for replay,
i explain my situation:
Operation system for server data center is RedHat version (about 600 servers more or less)
I'd like use a bridge server that has direct access to all servers of data center as root (sure), list server in file txt, with protocoll ssh. Right, i need this script to insert HISTTIMEFORMAT string into /etc/profile (after made a copy) to activate date and time in all users's history file.

I'll try your code also, thank you

let me check all solution
see you after
Enrico

michaelk · 06-24-2022, 06:38 AM

Then as suggested I would copy the command as a file to the /etc/profile.d directory instead of appending to /etc/profile. /etc/profile runs the scripts in /etc/profile.d

Per Redhat

Quote:

First of all, the files in the /etc directory are global for all users, but should really avoid changing them if at all possible. If need to modify the global settings, you can use /etc/profile.d (this is to prevent your changes from getting wiped out when packages are upgraded).

MienMatrix · 06-24-2022, 07:02 AM

Quote:

Originally Posted by michaelk

Then as suggested I would copy the command as a file to the /etc/profile.d directory instead of appending to /etc/profile. /etc/profile runs the scripts in /etc/profile.d

Per Redhat

Ok
So, if I understand correctly: if I insert in the path /etc/profile.d a file.sh containing
export HISTTIMEFORMAT = "% d /% m /% y% T"
export HISTTIMEFORMAT
into
/etc/profile.d/history.sh

history.sh would run automatically?
This it will be too much simple, because can create file history.sh and with scp script send in all server, right?

Thanks a lot
Regard
Enrico

pan64 · 06-24-2022, 07:05 AM

Quote:

Originally Posted by MienMatrix

Ok
So, if I understand correctly: if I insert in the path /etc/profile.d a file.sh containing
export HISTTIMEFORMAT = "% d /% m /% y% T"
export HISTTIMEFORMAT
into
/etc/profile.d/history.sh

history.sh would run automatically?
This it will be too much simple, because can create file history.sh and with scp script send in all server, right?

Thanks a lot
Regard
Enrico

yes, that will be "automagically" executed together with /etc/profile
But it is syntactically incorrect, space is not allowed after/before = (equal sign).

michaelk · 06-24-2022, 07:28 AM

You only need the one line.

Code:

export HISTTIMEFORMAT="%d/%m/%y %T "

An example of the history output with time is:

Quote:

989 06/24/22 09:31:37 top

The space after the %T separates time from the actual command ran.

MienMatrix · 06-24-2022, 07:38 AM

Quote:

Originally Posted by pan64

yes, that will be "automagically" executed together with /etc/profile
But it is syntactically incorrect, space is not allowed after/before = (equal sign).

IT WORKS, GREAT!
spaces there aren't in command, maybe is bug of quote.

Thank you very much to solve my issue and thank to all.

BEST REGARD
Enrico