Error executing shell script by crontab

mijan1373 · 07-05-2017, 02:26 PM

Hi,

I have a shell script called runbackup.sh as follows:

Quote:

#!/bin/sh

cd ~frappe/frappe-bench/
pwd
bench backup

when I run this in command line, everything works fine. but when this executed by cron I am getting following output log:

Quote:

/home/frappe/frappe-bench
/home/frappe/runbackup.sh: 5: /home/frappe/runbackup.sh: bench: not found

Can anyone point out the issue, please.

BR/Mijan

szboardstretcher · 07-05-2017, 02:31 PM

Where is 'bench' located?

TB0ne · 07-05-2017, 02:48 PM

Quote:

Originally Posted by mijan1373

Hi,
I have a shell script called runbackup.sh as follows:

Code:

#!/bin/sh

cd ~frappe/frappe-bench/
pwd
bench backup

when I run this in command line, everything works fine. but when this executed by cron I am getting following output log:

Code:

/home/frappe/frappe-bench
/home/frappe/runbackup.sh: 5: /home/frappe/runbackup.sh: bench: not found

Can anyone point out the issue, please.

You posted it yourself...twice, actually. Think about how cron runs, and about the fact that you probably have put your cron job into the root cron, right?

Your first line is the "cd" command, with a relative path (the "~frappe/frappe-bench"). As root, you're trying to run "cd /root/frappe/frappe-bench"...which probably doesn't exist. So that's the first problem; don't use relative paths in scripts, but fully qualified paths.

Your second issue is that the "bench" command (the line 5 where you're getting the error), isn't in your PATH, and can't be found. Even *IF* the cd command worked...you're not specifying the directory to run it from. So unless you've got the "bench" command in your PATH, it'll die. Again, use fully-qualified paths. Why the "pwd" command as line 4?? Running that through cron will only output a current working directory, which does nothing. Your whole script could be just:

Code:

#!/bin/sh
/path/to/bench backup

or even better...don't have a script, just put the time into cron, and put "/path/to/bench backup" in. No need for a script.

mijan1373 · 07-05-2017, 03:03 PM

1. Please see the return of "pwd" command in the output, it is /home/frappe/frappe-bench where bench exists.
2. It is Ubuntu 14.04, there is no /home/root.
3. Crontab belongs to frappe user, not root.

That makes me confused.

BR/Mijan

TB0ne · 07-05-2017, 03:06 PM

Quote:

Originally Posted by mijan1373

Please see the return of "pwd" command in the output, it is /home/frappe/frappe-bench where bench exists.
That makes me confused.d

It shouldn't, since when you're running that from your command-line prompt, that WILL be correct. When you run it through cron, it changes. Again, put a fully-qualified path in if you want this to work.

szboardstretcher · 07-05-2017, 03:06 PM

Yes. And if you just run

Code:

bench

Then the shell will look for 'bench' in the PATH, not in the current directory. This is basic Linux shell info.

you would need

Code:

./bench

To fire it off from the local directory. Or even better yet, as Tb0ne says,. use the full path /home/whatever/whatever/bench