[SOLVED] coma seperations

Fracker · 09-12-2011, 12:24 AM

Dear All,

I have a file which contains items like this

1234=abc xyz,aa1@domain1.com,aa2@domain1.com
2345=nn,bb1@domain.com
3456=lsop sds fds,cc1@domain.com,cc2@domain1.com

now i need to extract 4 variables 1st before "=" sign, 2nd after equal sign and comma and third after 1st coma and 2nd coma and 4th after last coma. Also there is a possibility that 4th coma doesn't exists.

I have loop which read the file line by line and extract 1st 4 character, now i need email address(es) in that loop so i can process them. I have tried while IFS=',' but don't know how to store them in variables?

Thanks in advance for the help

Edit:

I have Code like this which works fine, but i wanna do it with clean way.

Code:

#!/bin/bash

while read line; do
        code1=`echo $line | cut -c -4`
        echo "Code1 :" $code1
        echo $line > /tmp/tmp_lines_file
        while IFS=, read garb email1 email2
        do
            echo "Garbage:" $garb
            echo "Email Address1" $email1
            echo "Email Address2" $email2
        done < /tmp/tmp_lines_file
        rm /tmp/tmp_lines_file
done < MyFile.txt

paulsm4 · 09-12-2011, 12:57 AM

Seems like you're already doing pretty well

Here's a snippet that might help:

Code:

#/bin/bash

while read line; do
  echo line=$line...
  code1=$(echo $line|cut -d= -f1)
  echo code1=$code1...
  email1=$(echo $line|cut -d, -f2)
  email2=$(echo $line|cut -d, -f3)
  echo email1=$email1, email2=$email2
  echo
done

Code:

# Sample output:
$ cat test.txt
1234=abc xyz,aa1@domain1.com,aa2@domain1.com
2345=nn,bb1@domain.com
3456=lsop sds fds,cc1@domain.com,cc2@domain1.com

$ ./test.sh < test.txt
line=1234=abc xyz,aa1@domain1.com,aa2@domain1.com...
code1=1234...
email1=aa1@domain1.com, email2=aa2@domain1.com

line=2345=nn,bb1@domain.com...
code1=2345...
email1=bb1@domain.com, email2=

line=3456=lsop sds fds,cc1@domain.com,cc2@domain1.com...
code1=3456...
email1=cc1@domain.com, email2=cc2@domain1.com

David the H. · 09-12-2011, 01:00 AM

Your solution is already a good way to go about it, other than the fact that it's completely pointless to use a temporary text file and second loop.

The only other real change I would make is that you can set IFS to more than one character, meaning you can avoid doing the separate cut operation. I'd also move its line outside the loop so you only have to set it once.

Code:

#!/bin/bash

IFS='=,'
while read code1 garb email1 email2 ; do

	echo "Code1 : $code1"
	echo "Garbage: $garb"
	echo "Email Address1 $email1"
	echo "Email Address2 $email2"

done < MyFile.txt

In addition, always quote your variable expansions, unless you want word-splitting to occur. In this case it means quoting the entire echo'd lines.

http://mywiki.wooledge.org/Arguments
http://mywiki.wooledge.org/WordSplitting
http://mywiki.wooledge.org/Quotes

And finally, $(..) is highly recommended over `..`.

grail · 09-12-2011, 01:28 AM

Or you could use awk which is a doddle for this type of thing:

Code:

awk -F"[=,]" '{printf "Code1 : %s\nGarbage : %s\nEmail Address1 %s\nEmail Address2 %s\n",$1,$2,$3,$4}' file

Fracker · 09-12-2011, 05:44 AM

Thanks everyone for the tips and help me to improve my script.