Check Folder/Directory and Echo

ducati94 · 07-26-2017, 01:55 AM

Hi there

newbie here, i am trying to get the following script to work, but for the life of me, i cannot get it working.

Note: the <results> </results> are required. This is for JSS Extension Attribute.

Code:

#!/bin/bash
 
DIR=/Desktop/OneDrive - Name of Company
 
if [ ! -d $DIR ]; then
echo <results> "Directory exists" </results>
else
echo <results> "Incorrect" </results>
fi

i have success in doing something similar for Applications but not folder. Below is just an example of what i am trying to achieve

Code:

#!/bin/sh
# Identify App Store vs non App Store.

if [ -e /Applications/Numbers.app ]; then
    if [ -e /Applications/Numbers.app/Contents/_MASReceipt/ ]; then
        echo "<result>Apple</result>"
    else
        echo "<result>BCGS</result>"
    fi
else
    echo "<result>Not Installed</result>"
fi

And yes i have tried playing around with where the <result> tag is put as well. Where the result tag is in " "

Thanks in advance

please be gentle lol

aus9 · 07-26-2017, 02:40 AM

firstly I am not a real coder but me thinks your contrapositive statement needs to be reversed

here is test

Code:

./script                                                                                                                                                                       
Directory not found                                                                                                                                                                          

mkdir Desktop/OneDrive                                                                                                                                                         
gordon@neo:~$ ./script                                                                                                                                                         
Directory exists

script changed as I don't use JSS...to
#!/bin/bash

DIR=~/Desktop/OneDrive

if [ -d $DIR ] ; then echo "Directory exists"
else
echo "Directory not found"
fi

ducati94 · 07-26-2017, 02:53 AM

Quote:

Originally Posted by aus9

firstly I am not a real coder but me thinks your contrapositive statement needs to be reversed

here is test

Code:

./script                                                                                                                                                                       
Directory not found                                                                                                                                                                          

mkdir Desktop/OneDrive                                                                                                                                                         
gordon@neo:~$ ./script                                                                                                                                                         
Directory exists

script changed as I don't use JSS...to
#!/bin/bash

DIR=~/Desktop/OneDrive

if [ -d $DIR ] ; then echo "Directory exists"
else
echo "Directory not found"
fi

thanks for the reply

does it matter if it has spaces ? because my structure would look like OneDrive - Name Of Company
the above inclused - as well.

aragorn2101 · 07-26-2017, 03:29 AM

Quote:

Originally Posted by ducati94

does it matter if it has spaces ?

Yes, it matters.

So I suggest you do something like this:

Code:

#!/bin/bash
 
DIR="/Desktop/OneDrive - Name of Company"
 
if [ -d "$DIR" ]; then
  echo <results> "Directory exists" </results>
else
  echo <results> "Incorrect" </results>
fi

I removed the "!" as it will invert the results. "-d" returns True if $DIR exists and is a directory.

JJJCR · 07-26-2017, 03:35 AM

Try this:

Code:

#!/bin/bash

 DIR='OneDrive - Name of Company'

cd /Desktop
ls  | grep "$DIR" && echo "The folder is found" || echo "The folder cannot be found"
#Script ends

Got idea from this link: http://quickbytesstuff.blogspot.sg/2...er-exists.html

Good luck!

acescript · 07-29-2017, 07:33 AM

It's not so clear what exactly you want to achieve because your script is doing contrary to what's obvious:

Quote:

#!/bin/bash

DIR=/Desktop/OneDrive - Name of Company

if [ ! -d $DIR ]; then
echo <results> "Directory exists" </results>
else
echo <results> "Incorrect" </results>
fi

Question 1: Is /Desktop/OneDrive a directory or a file, if its a directory the expression in the test

Quote:

! -d $DIR

will execute the first echo statement if the $DIR doesn't exists. These contradict themselves. The correct code should be:

Quote:

#!/bin/bash

DIR=/Desktop/OneDrive - Name of Company

if [ -d $DIR ]; then
echo <results> "Directory exists" </results>
else
echo <results> "Incorrect" </results>
fi

For the second code

Quote:

#!/bin/sh
# Identify App Store vs non App Store.

if [ -e /Applications/Numbers.app ]; then
if [ -e /Applications/Numbers.app/Contents/_MASReceipt/ ]; then
echo "<result>Apple</result>"
else
echo "<result>BCGS</result>"
fi
else
echo "<result>Not Installed</result>"
fi

The

Quote:

-e /Applications/Numbers.app

appears to be a file. If this is true it contradicts this line

Quote:

-e /Applications/Numbers.app/Contents/_MASReceipt/

because you cannot make a sub-directory of a file.

Always use the appropriate syntax when writing your code.