Can you help me with my shell script I'm trying to write?

Yaesu · 04-25-2013, 07:41 PM

I need to create a script in linux that will check to see if a file exists and if it does then make 10 copies of itself in another directory. This is what I have but its not working. Can someone check this out for me.

Code:

#!/bin/sh
 if [ $1 -e ]
 do
 N=1
 while [$N -le 10 ]
 do
 cp $1 $2
 done
 else
 echo File does not exist.
 fi

chrism01 · 04-25-2013, 07:52 PM

Here's a few trs
1. indent for easier reading

Code:

#!/bin/sh    # try #!/bin/bash, its more capable than sh
# add the next line to enable the debugger
set -xv

 if [ $1 -e ]     # if [[ -e $1 ]]
 do               # delete
     N=1
     while [$N -le 10 ]      # use [[ ]] or even (( ))
     do
         cp $1 $2         # why $2? create a new name with eg numeric suffix
     done
 else
     echo File does not exist.
 fi

bookmark & read
http://rute.2038bug.com/index.html.gz
http://tldp.org/LDP/Bash-Beginners-G...tml/index.html
http://www.tldp.org/LDP/abs/html/

HTH & Welcome to LQ

Yaesu · 04-25-2013, 08:02 PM

I am using $2 as the second argument that way the user can enter where they want the files to be copied. I changed my code around and its not working.

Code:

#!/bin/bash
 
if [[ -e $1 ]]

   N=1
   while [[ $N -le 10 ]]
   do
      cp $1 $2
   done
   
else
     echo File does not exist.
fi

chrism01 · 04-25-2013, 08:05 PM

If you read those links, they'll show you everything you need.
Have a good attempt first, then come back if you're really stuck.
If/when you do, post your new code and show what happened when you ran it.

Yaesu · 04-25-2013, 08:11 PM

Thank you for the links I am checking them out now.

cortman · 04-25-2013, 09:16 PM

Your copy could be better implemented with a for loop rather than while, i.e.,

Code:

for i in {1..10} ; do
    echo "frodo"
done

Can't recommend the Bash Beginner's Guide highly enough. My favorite CLI resource.

grail · 04-25-2013, 11:19 PM

When learning scripting you should include the following as your first line of code after the shebang every time (as indicated by chrism01):

Code:

set -xv