Binary operator expected

mike9287 · 07-15-2006, 11:35 AM

Hi, when I pass multiple argument to this function I get multiple errors - binary operator expected:

Code:

function checkExisting ()
{
if [ -d "$TRASH/$@" ] || [ -f "$TRASH/$@" ]; then
     rm -rf $TRASH/$@
     writePro $@

else
     writePro $@

fi
}

any ideas of a way round it?

ta

Mike

mike9287 · 07-15-2006, 12:27 PM

Also, is there a way to remove non-empty directories without using rm? I want to alias my script to rm when its done and if I use rm it will simply call my script.

hfawzy · 07-15-2006, 12:37 PM

To remove non-empty directories, you could still use rm, but by calling /bin/rm instead of directly rm (this will not call your alias).
Concerning your first post, is writePro a function you have written?
If so, please post it.

HTH.

mike9287 · 07-15-2006, 12:52 PM

Quote:

Originally Posted by hfawzy

To remove non-empty directories, you could still use rm, but by calling /bin/rm instead of directly rm (this will not call your alias).
Concerning your first post, is writePro a function you have written?
If so, please post it.

HTH.

Hi here is my full script:

Code:

#!/bin/bash
# Ai program to emulate the "rm" command in UNIX.
# Created by Michael Kelly
# Last revison 12/07/2006


# INITIALIZE VARIABLES
NO_ARGS=0
FLAG_R=""
FLAG_F_I=""
FLAG_V=""
TRASH=$HOME/deleted

# FUNCTIONS

function errors() {
if [ "$#" -eq  "$NO_ARGS" ] ; then
      echo "rm: too few arguments"
      echo "Try \`rm --help' for more information."
      exit 0
elif [[  ! -f "$1"  && ! -d "$1"   ]] ; then
      echo "rm: cannot remove $ARG : no such file or directory"
      exit 0
elif [[ -d $ARG  &&  "$FLAG_R" = ""  ]] ; then
      echo "rm: \`$ARG' is a directory"
      exit 0
else
     writePro $1
fi
}

function verbose () {
if [ "$FLAG_V" = "v" ] ; then
echo "removing \`$1'"
fi
}

function interactive () {
echo -n "rm: remove $1 ?"
     read A
     if [[ "$A" = [Yy] ]] ; then
     remove $1
     else
     exit 0
fi
}

function writePro () {
if ! [ -w  "$1" ] ; then
echo -n "rm: remove write-protected file \`$*'?"
     read A
     if [[ "$A" = [Yy] ]] ; then
     delete $1
     fi
else
     delete $1
fi

}
function checkExisting ()
{
if [ -d "$TRASH/$1" ] || [ -f "$TRASH/$1" ]; then


     shred -fp $TRASH/$1 2>/dev/null
     writePro $1

else
     writePro $1

fi
}

function force () {

mv -f $1 $TRASH 2>/dev/null
verbose $1
}


function remove () {
mv  $1 $TRASH 2>/dev/null
verbose $1
}

function delete() {
if [ "$FLAG_F_I" = "-i" ] &&  [ -w  "$@" ] ; then
   interactive $1
elif [ "$FLAG_F_I" = "-f"  ] ; then
   force $1
elif [ "$FLAG_R" = "-R"  ] ; then
   recursive $1
else
   remove $1
fi

}

# Getops

while getopts :rRfvi o
do    case $o in
           r|R) FLAG_R=-R
             ;;
             f) FLAG_F_I=-f
             ;;
             v) FLAG_V=-v
             ;;
             i) FLAG_F_I=-i
             ;;
             *) echo "rm: invalid option -$1"
                echo "try \`rm --help' for more information"
                exit 0
      esac
done
shift `expr $OPTIND - 1`

if ! [ -d "$HOME/deleted" ] ; then
     mkdir $HOME/delete

else
   for ARG in $*
   do
   errors $ARG
   done
fi
if [ $# -eq $NO_ARGS ] ; then
errors
fi

I am trying to emulate the "rm" command and then set this script as an alias to rm and simply move files rather than delete then.

I am struggling with the directories, I can handle files fine.

Thanks for the help!
Mike

mike9287 · 07-15-2006, 02:01 PM

Hi again,

I have amended my function to this:

Code:

function checkExisting ()
{
if [ -d "$TRASH/$1" ] || [ -f "$TRASH/$1" ]; then
     shred -fu $TRASH/$1/* 2>/dev/null
     rmdir $TRASH/$1
     writePro $1
else
     writePro $1

fi
}

but that will only shed for one directory, if there is a directory with a directory and so on it only shreds the contents of the first directory, can I improve it to do this recursively? if so how to I do it?

Ta

Mike

hfawzy · 07-15-2006, 04:34 PM

Are you using shred to avoid the problem you stated in your second post ?

Quote:

Also, is there a way to remove non-empty directories without using rm? I want to alias my script to rm when its done and if I use rm it will simply call my script.

If so, I said in my earlier post that you could still use rm (and not shred), but by calling /bin/rm instead of rm. By calling /bin/rm instead of rm, the command that will be executed is really /bin/rm, whereas if you call rm after you aliased it to your script, your script will be executed instead of rm.

Anyway, if you really intend to use shred, you can delete all files recursively using this command :

Quote:

find -type f -exec shred -u '{}' \;

and then remove the tree of empty directories by calling /bin/rm -rf *

HTH.

mike9287 · 07-16-2006, 01:36 PM

Quote:

Originally Posted by hfawzy

Are you using shred to avoid the problem you stated in your second post ?

If so, I said in my earlier post that you could still use rm (and not shred), but by calling /bin/rm instead of rm. By calling /bin/rm instead of rm, the command that will be executed is really /bin/rm, whereas if you call rm after you aliased it to your script, your script will be executed instead of rm.

Anyway, if you really intend to use shred, you can delete all files recursively using this command :

and then remove the tree of empty directories by calling /bin/rm -rf *

HTH.

Hi, thanks for the info, much appreciated.

Can I use the second commands to remove directories with rmdir? I tried

find -type d -exec rmdir -u '{}' \deleted;

but it didn't work, any idea if this is possible (without /bin/rm)?

mike9287 · 07-17-2006, 05:52 AM

Hi,

anyone help with the above post? can I use find and rmdir to remove empty directories within empty directories after using shred in one of the previous posts to delete the files?

Please Help!

Mike

jschiwal · 07-17-2006, 06:21 AM

Code:

function checkExisting ()
{
if [ -d "$TRASH/$@" ] || [ -f "$TRASH/$@" ]; then

If you pass 3 arguments to checkExisting(), then the expression "$TRASH/$@" will expand to "/home/username/DELETED/arg1 arg2 arg3"

Here is an example:

Code:

jschiwal@hpamd64:~/temp> function testfunction() { if [ -d "$@" ] ; then echo "is a dir"; elif [ -f "$@" ]; then echo "is a file"; fi; }
jschiwal@hpamd64:~/temp> ls
sample  testa  testb  testc
jschiwal@hpamd64:~/temp> testfunction testa
is a dir
jschiwal@hpamd64:~/temp> testfunction sample
is a file
jschiwal@hpamd64:~/temp> testfunction testa testb
bash: [: testa: binary operator expected
bash: [: testa: binary operator expected

mike9287 · 07-17-2006, 08:27 AM

Hi,

I managed to fix that, instead of using $@ I am now using a for loop to processs each argument
individually, can anyone help with the recursive removal of empty directories?

Also in this code, kindly recommended by hfawzy where do I specify the folder?

Code:

find -type f -exec shred -u '{}' \;

do I do it like this:

Code:

find -type f -exec shred -u '{}' $TRASH;

And does anyone know more about using rmdir as above like shred is being used to remove recursivley?

Thanks for any help!

Mike