bash: Works here, not there. why not?

L_Carver · 05-14-2017, 02:14 AM

First script (here the special labeling of output files works):

Code:

#!/bin/bash
SAVEIFS=$IFS
IFS=$(echo -en "\n\b")
##With regard to the Smiths song "Cemetery Gates"
keats=0; yeats=0;
function throwin () {
echo -e "What list will I be using?"
read -e item
#Allowing for, and correcting, the trailing space in interactive mode
if [[ "$item" =~ " " ]]; then
	capfile=${item% *}
else
	capfile=$item
fi
#echo $capfile
}
throwin
tuna=0; catfood=0
#wilde1=$((yeats+1))
while read file0
do
wilde1=$((tuna+1))
#file0=$item
echo -e "Checking file #$wilde1, $file0"
if [ -f "$file0" ];then
if [[ $capfile = list.txt ]]; then
	callit="$capfile"
	nocall="nocredit.txt"
	yescall="hascredit.txt"
	listem="credited-files.txt"
#	echo -e "$callit\t$nocall\t$yescall\t$listem"
#	exit 0
fi
if [[ ! $capfile = list.txt ]]; then 
	callit="${capfile%.*}"
	listem="$callit-credited-files.txt"
	nocall="$callit-nocredit.txt"
	yescall="$callit-hascredit.txt"
#	echo -e "$callit\t$nocall\t$yescall\t$listem"
#	exit 0
fi
cred=$(exiftool -s -S -IPTC:Credit "$file0" 2>/dev/null)
if [[ -n "$cred" ]]; then
#if [[ -n "$cred" ]]; then
	echo -e "$file0 \e[42mhas\e[0m Credit data."
	echo "$file0">>"$listem"
	echo "Writing to file."
	echo -e "$file0^$cred">> "$yescall"
	catfood=$((catfood+1))
fi
if [[ -z "$cred" ]]; then
	echo -e "$file0 does \e[41mnot\e[0m have Credit data."
	echo "Writing filename to file nocredit.txt"
	echo "$file0">>"$nocall"
fi
else
	echo "File $file0 was not found in this directory."
fi
tuna=$((tuna+1))
#sleep 0.5
done<"$capfile"
echo "$catfood out of $tuna files had Credit data."
IFS=$SAVEIFS

Second script (written, to my eyes, almost identically where special output files are concerned, but does not create them when called upon to do so):

Code:

#!/bin/bash -i
SAVEIFS=$IFS
IFS=$(echo -en "\n\b")
ape=0 monkey=0
function pickfile () {
echo -e "What text file will I be using?"
read -e item
#Allowing for, and correcting, the trailing space in interactive mode
if [[ $item =~ " " ]]; then
	capfile1=${item% *}
else
	capfile1=$item
fi
}
pickfile
 while read file0; do
 if [ -f "$file0" ];then
 if [[ $capfile1 = list.txt ]]; then
	callit="$capfile"
	nocall="nocomment.txt"
	yescall="hascomment.txt"
	listem="commented-files.txt"
#	echo -e "$callit\t$nocall\t$yescall\t$listem"
#	exit 0
fi
if [[ ! $capfile1 = list.txt ]]; then 
	callit="${capfile%.*}"
	listem="$callit-commented-files.txt"
	nocall="$callit-nocomment.txt"
	yescall="$callit-hascomment.txt"
#	echo -e "$callit\t$nocall\t$yescall\t$listem"
#	exit 0
fi
else
echo -e "That list was not in this directory.\nExiting."
exit 1
fi
#	comm1=$(exiv2 -pc "$line")
	comm1=$(exiftool -s -S -Comment $file0)
	comm2=$(exiftool -s -S -UserComment $file0)
	if [[ -n "$comm1" ]]; then
		echo -e "$file0 \e[1mhas\e[0m Comment data. Noted."
		echo -e "$file0" >>commented-files.txt
		echo "Writing Comment to file."
		echo -e "$file0^$comm1" >>hascomment.txt
		monkey=$((monkey+1))
	fi
	if [[ -z $comm1 ]] && [[ -z $comm2 ]]; then
		echo -e "$file0 has \e[91;1mno\e[0m Comment data. Moving on"
		echo "$file0">>nocomment.txt
	fi
ape=$((ape+1))
done< "$capfile1"
echo -e "$monkey out of $ape files had JPEG Comments."

IFS=$SAVEIFS

Shellcheck output on second script:

Code:

In /home/carver/bin/checkmycomments line 9:
if [[ $item =~ " " ]]; then
               ^-- SC2076: Don't quote rhs of =~, it'll match literally rather than as a regex.


In /home/carver/bin/checkmycomments line 19:
        callit="$capfile"
                ^-- SC2154: capfile is referenced but not assigned (did you mean 'capfile1'?).


In /home/carver/bin/checkmycomments line 28:
        listem="$callit-commented-files.txt"
        ^-- SC2034: listem appears unused. Verify it or export it.


In /home/carver/bin/checkmycomments line 29:
        nocall="$callit-nocomment.txt"
        ^-- SC2034: nocall appears unused. Verify it or export it.


In /home/carver/bin/checkmycomments line 30:
        yescall="$callit-hascomment.txt"
        ^-- SC2034: yescall appears unused. Verify it or export it.


In /home/carver/bin/checkmycomments line 39:
        comm1=$(exiftool -s -S -Comment $file0)
                                        ^-- SC2086: Double quote to prevent globbing and word splitting.


In /home/carver/bin/checkmycomments line 40:
        comm2=$(exiftool -s -S -UserComment $file0)
                                            ^-- SC2086: Double quote to prevent globbing and word splitting.

I thought I had this resolved. I guess not.

Carver

ondoho · 05-14-2017, 02:36 AM

why are there 2 versions of the script?
what are the exact differences?
what do the scripts do?

why don't you fix what shellcheck found, then re-formulate your question?

in addition to that, i find this:
"$callit-hascomment.txt"
highly unusual.
i think it means "a string composed from the contents of the variable $callit-hascomment, and the suffix '.txt'".
you should know.
in cases like this i find it best to enclose the var name in curly brackets, like so: "${callit-hascomments}.txt"

AwesomeMachine · 05-14-2017, 02:41 AM

Did you try:

Code:

#!/bin/bash
set -x

L_Carver · 05-14-2017, 05:19 AM

[quote="ondoho"]why are there 2 versions of the script?[/quote}
There aren't. It's a comparison. I'm trying to figure out why almost-identical code works in one but not in the other. Please refer back to the Subject line of this thread.

Quote: