[SOLVED] Bash script - too many arguments

igadoter · 07-14-2021, 01:01 PM

Of course you right. Just to illustrate possible list use. And having lists is convenient. But one more thing. Script should use separate working directory. Due to fact that if it will fail during execution - rerun would give incorrect numbers. Say after performing conversion of pdf file - script exits. Now rerun will count twice the same file. Working directory partially fix this. If script exit code is non-zero all working directory is cleared up - files are copied again and script runs again.

Edit: This is version with if condition. I don't understand reason for branching - if there are text files count - if there are not converse and count words. Seems something is not right here. But

Code:

wc -w *.txt > word_count 2> /dev/null || {
  for i in *.odcx ; do odc2txt "$i" ; done
  for i in *.odt ; do odt2txt "$i" ; done
  for i in *.pdf ; do pdf2txt "$i" ; done
  wc -w *.txt > word_count 2> /dev/null ;}

and that's it

salmanahmed · 07-15-2021, 01:35 AM

Quote:

Originally Posted by dugan

This is one of the newer BASH books. It has a good reputation.

https://linuxcommand.org/tlcl.php

Thanks a lot. I will definitely look into it

salmanahmed · 07-15-2021, 01:42 AM

Quote:

Originally Posted by igadoter

Ok what about

Code:

DOCX=(*.docx)
ODT=(*.odt)
PDF=(*.pdf)

# correct conversion command format so they produce files with .txt suffix
for i in ${DOCX[@]} ; do docx2txt "$i" ; done 
for i in ${ODT[@]} ; do  odt2txt "$i$ ; done
for i in ${PDF[@]} ; do pdf2txt  "$i"; done

# the last
wc *.txt > total_word_count

Say

Code:

$ wc -w *.info > /tmp/total_word_info
$ cat /tmp/total_word_info 
  11 Jinja2.info
  11 MarkupSafe.info
  21 Sphinx.info
  11 alabaster.info
  11 imagesize.info
  11 mando.info
  15 python3-babel.info
  11 pytz.info
  11 snowballstemmer.info
  11 sphinxcontrib-applehelp.info
  11 sphinxcontrib-devhelp.info
  11 sphinxcontrib-htmlhelp.info
  11 sphinxcontrib-jsmath.info
  11 sphinxcontrib-qthelp.info
  11 sphinxcontrib-serializinghtml.info
 179 total

So you really don't want to go back? At least run what I posted.

Yes, it works. I made minor modification in the syntax of pdf2txt and odt2txt (as mentioned in their manpages):

Code:

#!/bin/bash
DOCX=(*.docx)
ODT=(*.odt)
PDF=(*.pdf)

# correct conversion command format so they produce files with .txt suffix
for i in ${DOCX[@]} ; do docx2txt "$i"; done
for i in ${ODT[@]} ; do  odt2txt "$i" --output="$i".txt ; done
for i in ${PDF[@]} ; do pdf2txt -o "$i".txt "$i" ; done

# the last
wc -w *.txt > total_word_count

After looking at your code, I realized my initial mistake, i.e instead of appending the wordcount_file (and use if and loop for it), why not just convert all files and generate new wordcount_file, as the wordcount for existing text files remain the same

igadoter · 07-15-2021, 05:00 AM

I am happy I could be of some help.