[SOLVED] BASH --> Function, while & for loop's sanity check

manwithaplan · 10-06-2009, 11:21 PM

I am very new with programming... and have been using recommended guides.. very helpful...

I am uncertain of my for loop's & while loop. The reason being I have never had so many loops in a function before... I need to know if these for loops will work ... So any advice on making the loop's more condensed or of any different way, would be great ...

Code:

# Builds the packages & then copies to your CLFS partition

buildpkg()
{
  
                       cd $abs_bd 
		    for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
		    do
			cd $pkg 
			    makepkg -s $pkg || pkgfail  # Rebuild function
			cd ..  
		    done   

E=0
while [ $E -eq 0 ]; then
 
  cat << END 
Now that all packages have been built, we need to know where to copy the built 
packages. Please specifiy where to copy your built packages.

e.g.   /mnt/clfs/sources/pacman

END

    read clfs_dir
	   cd $clfs_dir   
				if [ -d $clfs_dir ]; then 
					break
				else
				    clear && echo "INVAILD DIRECTORY" && sleep 1s && clear && E=0
				fi
done

                cd $abs_bd  # <--Seems redundant, but unsure
	     for mpkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;
		do
		    cd $mpkg
		          cp *x86_64.pkg.tar.gz $clfs_dir
		     cd ..   
                done
}

chrism01 · 10-07-2009, 12:19 AM

If you re-format that, it'd be easier to read.

Anyway

Code:

for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
do
    cd $pkg

is a problem. Once you cd into a sub-dir, it'll assume the next dir is a sub-sub-dir etc ie its going to try to

cd acl
acl> cd attr
acl/attr>cd fakeroot

etc. not what you meant. You need to 'cd ..' at the end of the loop to get back to '$abs_bd' or 'cd $abs_bd' .

This
cd $clfs_dir
is redundant; just test if it's a dir, no point in cd'ing into it (especially as the dir test comes after that line; too late...

manwithaplan · 10-07-2009, 01:04 AM

Quote:

Originally Posted by chrism01

If you re-format that, it'd be easier to read.

Ya the formating was a copy and paste from my IDE ... its much easier to read in my app.

Quote:

Originally Posted by chrism01

is a problem. Once you cd into a sub-dir, it'll assume the next dir is a sub-sub-dir etc ie its going to try to

cd acl
acl> cd attr
acl/attr>cd fakeroot

etc. not what you meant. You need to 'cd ..' at the end of the loop to get back to '$abs_bd' or 'cd $abs_bd' .

That makes sense... it was cd'ing into a sub-dir... This is how it was, can you give me an example...

Code:

 
cd $abs_bd 
for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
do
  cd $pkg 
  makepkg -s $pkg || pkgfail  # Rebuild function
  cd ..   # Doesn't this return to $abs_bd ..?
done

This seemed like it cd .. into the next dir, followed in the loop ...
Is this what you meant..?

Code:

makepkg -s $pkg && cd .. || pkgfail  # Rebuild function

Quote:

Originally Posted by chrism01

This
cd $clfs_dir
is redundant; just test if it's a dir, no point in cd'ing into it (especially as the dir test comes after that line; too late...

I tried using my [-d] test w/o the cd, and for some reason it would just loop in my "while", so I had to add a "cd $clfs_dir" in order for the test statement to work ... odd

Thanks for your patience ... You've helped me on other occasions...

With only a few months combined experience with Bash, I'm slowly grasping the basics.

vonbiber · 10-07-2009, 01:27 AM

Code:

cd $abs_bd 
for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
do
  cd $pkg 
  makepkg -s $pkg || pkgfail  # Rebuild function
  cd ..   # Doesn't this return to $abs_bd ..?
done

to be sure that you're in the right directory
you could use absolute paths, eg:

Code:

cd $abs_bd
CWD=$PWD
for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
do
  cd $CWD/$pkg 
  makepkg -s $pkg || pkgfail  # Rebuild function
  cd $CWD   # this does return to $abs_bd
done

manwithaplan · 10-07-2009, 01:43 AM

Quote:

Originally Posted by vonbiber

Code:

cd $abs_bd
CWD=$PWD
for pkg in acl attr fakeroot pacman libfetch libarchive openssl wget rsync;  
do
  cd $CWD/$pkg 
  makepkg -s $pkg || pkgfail  # Rebuild function
  cd $CWD   # this does return to $abs_bd
done

Brilliant ... I didn't think of pwd ... Thanks man ... this should work nicely.

chrism01 · 10-07-2009, 05:07 AM

cd ..
means go up one level ie to the parent dir; which where you came from as you are not using absolute paths for the acl attr fakeroot pacman libfetch dirs there.

You really just need to decide if you are going to 'know where you are' and use relative paths, or assume the worst and use absolute paths.
It's important to understand the pwd thing clearly.
I'd recommend

set -xv

at the start to see exactly what's happening.