[question] Bash Script from Github not working

Arch4GoodieLike · 01-07-2021, 12:27 PM

I found this interesting Bash-Snippets from Github. I downloaded it with the [code] button and extracted it manually. The "meme" bash outputs a jpg which is, corrupt and can't be viewed therefore. I checked the code but still can't pinpoint the reason, why it isn't working. I tried multiple PhotoViewer tools. For usage, i tried

Code:

$ ./meme -f test #outputs the filename as "test.jpg"
$ doge #background
$ Topline #toplineText
$ Bottomline #BottomlineText

The other bashes, which i can profit from, are all functional, out of the box.

Question: Anyone knows the reason, why the script isn't working on my side?

rtmistler · 01-07-2021, 12:41 PM

Just sharing or was there a particular question?

Arch4GoodieLike · 01-07-2021, 01:23 PM

Quote:

Originally Posted by rtmistler

Just sharing or was there a particular question?

If you have nothing helpful to say, then go along. Simple as that.

teckk · 01-07-2021, 02:20 PM

That's a bunch of scripts.
This one.
https://github.com/alexanderepstein/...ster/meme/meme

Code:

usage()
{
  cat <<EOF
Meme
Description: A lightning fast meme generator
Usage: tool [flags] or tool [flags] [arguments]
  -u  Update Bash-Snippet Tools
  -h  Show the help
  -f  Choose the output filename
  -v  Get the tool version
Examples:
   meme -h
   meme -f dogeMeme
EOF
}

Looks like it is suppose to do this

Code:

httpGet "https://memegen.link/$bg/$first/$second.jpg" >> "$fileName".png

Lets see:

Code:

agent="Mozilla/5.0 (Windows NT 10.1; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0"

curl -A "$agent" https://memegen.link/dog/cat/test.jpg -o test.jpg
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

Looks like it needs to be this
https://api.memegen.link/images/dog/cat/test.jpg

It redirects, this will get it.

Code:

curl -LA "$agent" https://memegen.link/dog/cat/test.jpg -o test.jpg

Go ahead and fix that script if you want to.

rtmistler · 01-07-2021, 02:35 PM

Excuse the brief confusion Arch4GoodieLike, until you edited your original, it was unclear what the particular problem was, although there were some clues.

I agree that teckk has it covered fairly well and suggest if you desire to modify the httpGet() function cited and try to create the meme.

An additional thing you can do if you continue to see problems, is to put a "set -xv" line just after the first line of the script. This will enable verbose and debug output when you run the script, you should see how the script progresses through the main and functions and see the detailed output if there are additional errors.

Arch4GoodieLike · 01-07-2021, 03:18 PM

[QUOTE=teckk;6205162
Go ahead and fix that script if you want to.[/QUOTE]

the little one-liner trick of yours does it!
I added "api." to this line:

Code:

httpGet "https://api.memegen.link/$bg/$first/$second.jpg" >> "$fileName".png || return 1

and it's still not working if i try it scriptwise.

teckk · 01-07-2021, 03:23 PM

No, Look at line 24

Code:

httpGet()
{
  case "$configuredClient" in
    curl)  curl -A curl -s "$@" ;;
    wget)  wget -qO- "$@" ;;
    httpie) http -b GET "$@" ;;
    fetch) fetch -q "$@" ;;
  esac
}