Bash script for adding SMB/Windows printer to CUPS failing, why??

lefty.crupps · 04-23-2008, 03:46 PM

I am trying to create a simple command-line script for a RHEL5.1_64 system to add shared Windows printers to their Linux server. When I run this command alone at a bash prompt, it works:

Code:

lpadmin -p michele1320pcl6 -v smb://Administrator:PASS@michele/michele1320pcl6 -E

But when I put that into a script, I get no successes and a lot of errors in the cups/error_log. Here is my script:

Code:

#!/bin/bash
echo -e "\n"
echo -e "Please enter the Windows computer name, which must not have spaces:"
read COMP
echo -e "Please enter the printer's Share Name, also without spaces:"
read PRINTER
echo -e "Please enter the desktop Administrator's password:"
read PASSWD
clear
echo -e "\n\nDoes this look correct? \n\t Computer: $COMP \n\t Printer:  $PRINTER \n\t Password: $PASSWD \n If this is wrong, press [Ctrl][C] to stop this program; otherwise press [Enter] to add your printer. \n\n"
read PAUSE
/usr/sbin/lpadmin \-p $PRINTER \-v smb://Administrator:${PASSWD}@${COMP}/${PRINTER} \-E
echo -e "\n"
echo -e "Printing test page now to $PRINTER"
/usr/bin/lpr -P "$PRINTER" /root/printtest.txt
echo -e "\n"

The errors are generally "Tree connect failed (NT_STATUS_BAD_NETWORK_NAME)" but I get others also, depending on if I try to \@ escape the @ symbol in the "-v URI" string; I've tried with and without quotes, with and without \-v \-E, but no matter what I cannot get it.

Any ideas out there for me?

BrianK · 04-23-2008, 08:50 PM

Quote:

Originally Posted by lefty.crupps

I am trying to create a simple command-line script for a RHEL5.1_64 system to add shared Windows printers to their Linux server. When I run this command alone at a bash prompt, it works:

Code:

lpadmin -p michele1320pcl6 -v smb://Administrator:PASS@michele/michele1320pcl6 -E

But when I put that into a script, I get no successes and a lot of errors in the cups/error_log. Here is my script:

Code:

#!/bin/bash
echo -e "\n"
echo -e "Please enter the Windows computer name, which must not have spaces:"
read COMP
echo -e "Please enter the printer's Share Name, also without spaces:"
read PRINTER
echo -e "Please enter the desktop Administrator's password:"
read PASSWD
clear
echo -e "\n\nDoes this look correct? \n\t Computer: $COMP \n\t Printer:  $PRINTER \n\t Password: $PASSWD \n If this is wrong, press [Ctrl][C] to stop this program; otherwise press [Enter] to add your printer. \n\n"
read PAUSE
/usr/sbin/lpadmin \-p $PRINTER \-v smb://Administrator:${PASSWD}@${COMP}/${PRINTER} \-E
echo -e "\n"
echo -e "Printing test page now to $PRINTER"
/usr/bin/lpr -P "$PRINTER" /root/printtest.txt
echo -e "\n"

The errors are generally "Tree connect failed (NT_STATUS_BAD_NETWORK_NAME)" but I get others also, depending on if I try to \@ escape the @ symbol in the "-v URI" string; I've tried with and without quotes, with and without \-v \-E, but no matter what I cannot get it.

Any ideas out there for me?

Why are you escaping the dashes?

/usr/sbin/lpadmin -p $PRINTER -v smb://Administrator:${PASSWD}@${COMP}/${PRINTER} -E

... a bash shell script should be the same as typing in a bash shell, so unless you're trying to echo something out, there's no reason to escape anything (unless you would escape it when you type it on the command line).

lefty.crupps · 04-24-2008, 10:10 AM

I should have been more clear; when I wrote "I've tried with and without quotes, with and without \-v \-E" I meant, with the escape in \-v and \-E, and without the escape (just -p and -v and -E, not escaped).

So, I've tried both:

/usr/sbin/lpadmin \-p $PRINTER \-v smb://Administrator:${PASSWD}@${COMP}/${PRINTER} \-E
/usr/sbin/lpadmin -p $PRINTER -v smb://Administrator:${PASSWD}@${COMP}/${PRINTER} -E

I have bigger issues, I think. I can connect to another samba share when I mount it but I have browsing issues (like I can cd /mnt/winshare/fakedir/thisisreallyfake/ and run an ls -a there, and it shows me the same as /mnt/winshare/ ...)