[SOLVED] ZFS not importing zpool at boot

replica9000 · 01-27-2018, 10:14 PM

At some point, an upgrade had caused ZFS to stop automatically importing the pool on it's own. Not sure if the upgrade that caused this is the kernel, systemd, or ZFS itself. It's been like this for a while. I can manually import the pool with the same command shown in the output below.

ZFS/SPL: 0.7.5-1
Kernel: 4.14.0-3-amd64

Code:

Please unlock disk cryptroot:
[    8.482283] NET: Registered protocol family 38
cryptsetup (cryptroot): set up successfully
done.
Begin: Running /scripts/local-premount ... Begin: Waiting for suspend/resume device ... Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
Begin: Running /scripts/local-block ... done.
done.
Gave up waiting for suspend/resume device
done.
Begin: Sleeping for ... done.
[   30.432949] spl: loading out-of-tree module taints kernel.
[   30.435094] SPL: Loaded module v0.7.5-1
[   30.436229] znvpair: module license 'CDDL' taints kernel.
[   30.437122] Disabling lock debugging due to kernel taint
[   32.367164] ZFS: Loaded module v0.7.5-1, ZFS pool version 5000, ZFS filesystem version 5
Begin: Sleeping for ... done.
Begin: Attempting to import additional pools. ... Begin: Importing pool 'zroot' using defaults ... Failure: 127
Begin: Importing pool 'zroot' using cachefile. ... Failure: 127

Command: /sbin/zpool import -c /etc/zfs/zpool.cache -N   'zroot'
Message: /init: line 1: /sbin/zpool import -c /etc/zfs/zpool.cache -N  : not found
Error: 127

Failed to import pool 'zroot'.
Manually import the pool and exit.


BusyBox v1.27.2 (Debian 1:1.27.2-2) built-in shell (ash)
Enter 'help' for a list of built-in commands.

/bin/sh: can't access tty: job control turned off
/#

voleg · 01-31-2018, 11:29 AM

Been there.
A starting script checks if zfs module installed, if not it skip ZFS activation.
As a dirty workaround I've forced loading module at boot time.
See how here: ZFS recepies

-TCM- · 07-28-2018, 03:05 PM

For anyone stumbling upon this thread like I did, here is the solution to this particular idiotic problem.

In /usr/share/initramfs-tools/scripts/zfs there are multiple occurrences of the following code, 2 of which are in the function import_pool():

Code:

ZFS_STDERR="$(${ZFS_CMD} 2>&1)

The problem is, this is a bash-ism that doesn't work as it should, in pretty much any other shell. If you look closely at the error

Code:

Message: /init: line 1: /sbin/zpool import -c /etc/zfs/zpool.cache -N  : not found

what you really see is the shell complaining that it can't find a binary called "/sbin/zpool import -c /etc/zfs/zpool.cache -N", including spaces and all. After changing that code to

Code:

ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)

it works as expected. What this tells you is that not a single person on earth has tested this code in real usage. It also tells you NOT TO PROGRAM FOR BASH if you claim to use /bin/sh in your shebang. Yet again stupid coders using bash ruin it for everyone. Thanks for the waste of time to that particular individual.

replica9000 · 08-03-2018, 03:02 PM

Thank you -TCM-

This did solve my issue, however, I did have to change more than two occurances.

Code:

ZFS_STDERR="$($ZFS_CMD "$pool" 2>&1)"
                        ZFS_STDERR="$($ZFS_CMD "$pool" 2>&1)"
        ZFS_STDERR=$(${ZFS_CMD} "${fs}" "${rootmnt}/${mountpoint}" 2>&1)
                ZFS_STDERR="$(${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(${ZFS_CMD} 2>&1)"

to

Code:

ZFS_STDERR="$(eval ${ZFS_CMD} "$pool" 2>&1)"
                        ZFS_STDERR="$(eval ${ZFS_CMD} "$pool" 2>&1)"
        ZFS_STDERR=$(eval ${ZFS_CMD} "${fs}" "${rootmnt}/${mountpoint}" 2>&1)
                ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)"
        ZFS_STDERR="$(eval ${ZFS_CMD} 2>&1)"

And just for good measure, I changed any $ZFS_CMD to ${ZFS_CMD}.