udev rules not unmounting usb

jjinno · 11-24-2009, 01:26 PM

(Fedora 4... don't hassle me... :-P)

Here is my working udev rule for addition:

Code:

ACTION=="add", KERNEL=="sd??", BUS=="usb", DRIVER=="usb-storage", NAME="usb-%k", SYMLINK="usb/%k"
ACTION=="add", KERNEL=="sd??", BUS=="usb", DRIVER=="usb-storage", RUN+="/bin/mkdir -p /media/usb/%k"
ACTION=="add", KERNEL=="sd??", BUS=="usb", DRIVER=="usb-storage", RUN+="/bin/mount /dev/usb-%k /media/usb/%k", OPTIONS="last_rule"

And here was my first (ideal = no scripts involved) attempt for removal:

Code:

ACTION=="remove", SUBSYSTEM=="block", ENV{DEVNAME}=="/dev/usb-sd*", RUN+="/bin/umount $(/bin/mount|/bin/grep ${DEVNAME}|/bin/awk '{print $3}')"

And after that failed, I tried to get something working with a script:

Code:

ACTION=="remove", SUBSYSTEM=="block", ENV{DEVNAME}=="/dev/usb-sd*", PROGRAM="/etc/udev/scripts/usbdrive.sh", RUN+="/bin/umount %c"

And the script:

Code:

#!/bin/sh
# Get the mount entry for ${DEVNAME}
MOUNT=`/bin/mount|/bin/grep ${DEVNAME}|/bin/awk '{print $3}'`
[ $? -eq 0 ] && echo $MOUNT || exit 1

According to the man-page, I should have $DEVNAME available for use in both "RUN" and "PROGRAM". None of these have worked though, leaving my usb-mount there.

The idea here is to NOT have to offshoot the work to a script (aka. my first attempt)... which is why I am getting into trouble.
Any help on what I am doing wrong?
Is inline bash just not allowed?

jjinno · 11-24-2009, 03:27 PM

I was able to make it work with some minor modifications... Apparently udev hates inline-bash?

Code:

# Auto-mount USB storage (on add):
ACTION=="add", BUS=="usb", KERNEL=="sd??", DRIVER=="usb-storage", NAME="usb-%k", SYMLINK="usb/%k"
ACTION=="add", BUS=="usb", KERNEL=="sd??", DRIVER=="usb-storage", RUN+="/bin/mkdir -p /media/usb/%k"
ACTION=="add", BUS=="usb", KERNEL=="sd??", DRIVER=="usb-storage", RUN+="/bin/mount /dev/usb-%k /media/usb/%k", OPTIONS="last_rule"

# Auto-unmount USB storage (on remove):
ACTION=="remove", SUBSYSTEM=="block", ENV{DEVNAME}=="/dev/usb-sd*", RUN+="/bin/umount /media/usb/%k"
ACTION=="remove", SUBSYSTEM=="block", ENV{DEVNAME}=="/dev/usb-sd*", RUN+="/etc/udev/scripts/usbcleanup.sh /media/usb/%k"

And my usbcleanup.sh script:

Code:

#!/bin/bash

# Dont run without input...
[ "$1" = "" ] && exit 1

# Figure out the directory location...
if [ -d $1 ]
then
    DIR=$1
elif [ -d /media/$1 ]
then
    DIR="/media/$1"
elif [ -d /media/usb/$1 ]
then
    DIR="/media/usb/$1"
fi

# Make sure un-mount has happened
/bin/mount|/bin/grep usb|/bin/grep $DIR >/dev/null
if [ $? -ne 0 ]
then
    # Is the directory full?
    /bin/ls -l $DIR|/bin/egrep "r|w|x|-|:" >/dev/null
    if [ $? -ne 0 ]
    then
        # One more check for dir contents
        /bin/ls $DIR|/bin/egrep "*" >/dev/null
        [ $? -ne 0 ] && /bin/rm -rf $DIR
    fi
fi

jjinno · 11-24-2009, 03:29 PM

I say this qualifies as a "no scripts" approach, only cause there is no reason I *have* to delete any empty directories (although it is nicer)...

I fear putting a rule with "rm -rf" in it... so I guess this is as good as I can get for now.