Simple BASH script

fio · 01-17-2003, 04:55 PM

Hey.

I am trying to rename a couple of files containing the character "?" in their names. I want to replace "?" with "-".

I've tried -
for i in `find . -name *\?*' ; do mv "$i" "`echo $i | sed -e s/\?/\-/g`" ; done

DIDN'T WORK.

Can anyone offer a perl / sed / ANY script to accomplish the task?

Thanks.

nxny · 01-17-2003, 06:45 PM

for i in $(find . -name '*\?*'); do mv $i $(echo $i | sed -e s/\?/-/g); done

Note:Wont work with whitespace in the filename.

fio · 01-18-2003, 05:13 AM

Thanks for the reply!

But I need it to work WITH white spaces..

Can you offer additional help?

unSpawn · 01-18-2003, 07:15 AM

find . -name "*\?*"|while read raw; do
mv -f "${raw}" "$(echo ${raw} | tr "?" "-")"; done

Just make it a habit to*always* quote variables + a double quote can't be mistaken by a backtick and the use of $(action) is easier to spot than using backticks. Since it's a simple one char replacement I'm using "tr" instead of sed.

fio · 01-18-2003, 11:00 AM

Thanks,

Worked perfectly.

Fio

nxny · 01-18-2003, 04:26 PM

Good job, unspawn!!