Script checking

Riddick · 09-16-2005, 06:03 PM

Here is my script, please run it, and ask ask it to kill a harmless process.
Script:

Quote:

#!/bin/bash
# The Following line kills the process given by the user
WHO="$(whoami)"
PROCESS_NAME="$1"
PROCESS_NUMBER="$(ps aux | grep "$PROCESS_NAME" | grep -v grep | awk '{print $2}')"
echo "Trying to kill Process $PROCESS_NAME"
echo -e "Trying to kill Process# $PROCESS_NUMBER\c\c\c"
#Check if the user is Root:
if test $WHO = root; then
#kill "$PROCESS_NUMBER"
echo "Sent the KILL command to Process# $PROCESS_NUMBER"
else
echo "Only root can run this script"
#echo $WHO
exit 0
fi
# End of Script

When I run it:

Code:

root@edslaptop:/home/ed# killname kuickshow
Trying to kill Process kuickshow
Trying to kill Process# 10960
11765
11767
11770Sent the KILL command to Process# 10960
11765
11767
11770
root@edslaptop:/home/ed#

Process # 10960 is correct, but what are the other two that have found
their way into $PROCESS_NUMBER?
They are always separated by 2 (i.e. 11765 = 11767 + 2). I don't know where these
numbers are from - I don't think they are process numbers!

Help me!

Riddick

Mad Scientist · 09-16-2005, 06:21 PM

They very well could be process numbers. Try doing a "ps -e | grep processname" and see if multiple results show up. While the names may not be exact matches, the string "processname" may show up in a few processes. You can use sed to keep only the first entry if that's what you want, or something more appropriate to search through the results for exactly what you want.

Riddick · 09-16-2005, 06:26 PM

ed@edslaptop:~$ killname kuickshow
Trying to kill Process kuickshow
Trying to kill Process# 10960
12358
12360
12363Only root can run this script
ed@edslaptop:~$ ps -e | grep processname
ed@edslaptop:~$

How would I just cut $PROCESS_NAME down to its first line?

Thanks,
Riddick

Mad Scientist · 09-16-2005, 06:34 PM

Add an

Code:

sed -e '2,$d'

to the end of your piping structure. For example, if you do

Code:

[user@domain ~]$ ps -e | grep spamd
 6889 ?        00:00:01 spamd
 6892 ?        00:00:00 spamd
 6893 ?        00:00:00 spamd
 6894 ?        00:00:00 spamd
 6895 ?        00:00:00 spamd
 6896 ?        00:00:00 spamd

Then you can do

Code:

[user@domain ~]$ ps -e | grep spamd | sed -e '2,$d'
 6889 ?        00:00:01 spamd

Riddick · 09-16-2005, 06:41 PM

Code:

PROCESS_NUMBER="$(ps aux | grep "$PROCESS_NAME" | grep -v grep | awk '{print $2}')|sed -e '2,$d'"

Gives:

Code:

root@edslaptop:/home/ed# killname kuickshow
Trying to kill Process kuickshow
Trying to kill Process# 10960
12678
12680|sed -e '2,'Sent the KILL command to Process# 10960
12678
12680|sed -e '2,'
root@edslaptop:/home/ed#

Perhaps we should try to find out where those numbers come
from!
Have you tried the script on your machine?

Completely unrelated question, but how do I overwrite a variable?

Thanks,
Riddick

Mad Scientist · 09-16-2005, 06:56 PM

Try this.

Code:

#!/bin/bash
# The following line kills the process given by the user
WHO="$(whoami)"
PROCESS_NAME="$1"
PROCESS_NUMBER="$(ps -e | grep $PROCESS_NAME | sed -e '2,$d' | sed -e's/ //g' | sed -e 's/[^0-9].*//')"

echo "Trying to kill Process $PROCESS_NAME"
echo -e "Trying to kill Process# $PROCESS_NUMBER\n"

#Check if the user is Root:
if test $WHO = root; then
#kill "$PROCESS_NUMBER"
echo "Sent the KILL command to Process# $PROCESS_NUMBER"
else
echo "Only root can run this script"
#echo $WHO
fi

exit 0
# End of Script

Riddick · 09-16-2005, 07:10 PM

excellent, thanks very much!
I hope this could be useful to you too!

Thanks,
Riddick

eddiebaby1023 · 09-18-2005, 07:11 AM

Quote:

Code:

sed -e '2,$d'

Why not use

Code:

head -1

Saves wasting time processing all those other lines. More obvious what you're doing, too.

Mad Scientist · 09-18-2005, 12:11 PM

You're right, that would be simpler.

eddiebaby1023 · 09-18-2005, 03:44 PM

There's always more than one way to do it.