Renaming MP3 collection [bash script]

mainstream · 12-20-2010, 11:00 AM

Hello everybody,

I've been trying (and trying...) to write this script, and now, i am at i point where i cannot go any further without any help from some (more experienced) users here

I'm a complete newbie on bash scripting, so be gentle

This is what i've come up so far:

Code:

./reading 
.---------------------------------- - - -- -- -- --- - - - - - - - - - -
| Number of characters 48
| + Current: 107_david_guetta_-_missing_you_(feat._novel).mp3
| + Changed: 107_david_guetta-missing_you_(ft._novel).mp3
| + Matched: "(feat._" substitute "(ft._"
| + Morping: "107_david_guetta-missing_you_(feat._novel).mp3" to "107_david_guetta-missing_you_(ft._novel).mp3"
'-[END]---------------------------- - - -- -- -- --- - - - - - - - - - -
| Number of characters 69
| + Current: 108_david_guetta_-_choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3
| + Changed: 108_david_guetta-choose_(ft._ne-yo_and_kelly_rowland)_(radio).mp3
| + Matched: "(feat._" substitute "(ft._"
| + Morping: "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3" to "108_david_guetta-choose_(ft._ne-yo_and_kelly_rowland)_(radio).mp3"
'-[END]---------------------------- - - -- -- -- --- - - - - - - - - - -
| + Changed: 108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio_edit).mp3
| + Matched: "(radio)" substitute "(radio_edit)"
| + Morping: "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3" to "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio_edit).mp3"
mv: cannot stat `108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3': No such file or directory
'-[END]---------------------------- - - -- -- -- --- - - - - - - - - - -

The problem is that it works with 1 variable to change, but when it uses 2 or more i'm getting errors (as stated above)

This is the code
It loads the variables from rsub file.

Code:

#!/bin/sh
numbers=*-*  # * (wild card) matches everything between.
bpm=\(*bpm\).mp3
removenumeric=${mp3#$numbers}
removebpm=${mp3%%$bpm}.mp3
echo \.---------------------------------- - - -- -- -- ---  -   - -    -   -    - - -    -    -
for mp3 in ls *.mp3; do
if [ -e "$mp3" ]
then
echo \| "Number of characters ${#mp3}"
echo \| \+ Current: ${mp3} 


#replacing spaces with underscores, changing to lowercase
removed="$(echo ${mp3} | sed 's/ /_/g' | sed 's/_-_/-/g' | tr '[A-Z]' '[a-z]')"
if [ "$mp3" != "$removed" ] ; then
mv $mp3 $removed

  while read inputline
  do
  match="$(echo $inputline | cut -d: -f1)"
  substitute="$(echo $inputline | cut -d: -f2)"
  corrected=$(echo $removed | sed 's/'$match'/''\'$substitute'/g')
  	if [ "$removed" != "$corrected" ] ; then
	echo \| \+ Changed: $corrected
	echo \| \+ Matched: \"$match\" substitute \"$substitute\"
	echo \| \+ Morping: \"$removed\" to \"$corrected\"
	mv $removed "$(echo $removed | sed 's/'$match'/''\'$substitute'/g')"
	echo \'-[END]---------------------------- - - -- -- -- ---  -   - -    -   -    - - -    -    -
	fi
  done < rsub

else echo Nothing to do!
fi
fi
done

kbp · 12-20-2010, 05:22 PM

I'd probably separate them out into unique operations which will make it easier to extend and troubleshoot, coming up with a miracle one-liner is great for fun but sometimes not that maintainable.

eg.

Code:

# remove leading numbers
...
# spaces to underscores
...
# tolower
...
# feat to ft.
...
# versus to vs.
...

cheers

mainstream · 12-21-2010, 04:45 AM

Ok thanks for your reply.

I've already included this:

Code:

while read inputline
do
  match="$(echo $inputline | cut -d: -f1)"
  substitute="$(echo $inputline | cut -d: -f2)"
  corrected=$(echo $file | sed 's/'$match'/'$substitute'/g')
  	if [ "$file" != "$corrected" ] ; then
	echo match \"$match\" substitute \"$substitute\"
	echo Match found "renaming \"$file\" to $corrected"
	local file=$corrected
	fi
done < rsub
exit 0

I already made this script, and tried it. It works very well.
But how can i make it this 2 loops works together?

Regards

kbp · 12-21-2010, 05:55 AM

Double quotes should be fine

mainstream · 12-21-2010, 09:16 AM

I've changed the first post :-) hope you can help me with this!
ANd thanks for your time ^^

kbp · 12-21-2010, 03:52 PM

<winge>It's a little hard to follow if you go back and edit your original posts .. linear is better. </winge>

Quote:

| Number of characters 69
| + Current: 108_david_guetta_-_choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3
| + Changed: 108_david_guetta-choose_(ft._ne-yo_and_kelly_rowland)_(radio).mp3
| + Matched: "(feat._" substitute "(ft._"
| + Morping: "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3" to "108_david_guetta-choose_(ft._ne-yo_and_kelly_rowland)_(radio).mp3"
'-[END]---------------------------- - - -- -- -- --- - - - - - - - - - -
| + Changed: 108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio_edit).mp3
| + Matched: "(radio)" substitute "(radio_edit)"
| + Morping: "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3" to "108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio_edit).mp3"
mv: cannot stat `108_david_guetta-choose_(feat._ne-yo_and_kelly_rowland)_(radio).mp3': No such file or directory
'-[END]---------------------------- - - -- -- -- --- - - - - - - - - -

The problem is that you're still trying to use the same file name variable which no longer exists because it's been renamed due to the previous "feat. to ft."

This is why I suggested you run them as discrete operations

cheers

mainstream · 12-22-2010, 06:20 AM

Quote:

Originally Posted by kbp

<winge>It's a little hard to follow if you go back and edit your original posts .. linear is better. </winge>

The problem is that you're still trying to use the same file name variable which no longer exists because it's been renamed due to the previous "feat. to ft."

This is why I suggested you run them as discrete operations

cheers

Ahh yes i figured out, i figured ;-) thanks
Now i used to mostly used as discrete operations :-)

For other things i use:
If i just use

Code:

 rename "'s/${match}/${substitute}/g'" *.mp3

it works.
Except for filenames/substitutes which need escape characters i still need to find out.

Code:

mainstream@serotonin-pc:/media/500GB/music$ rename 's/(radio)/(radio_edit)/g' ghostface_killah-back_like_that_(remix)_(ft._kanye_west_and_ne-yo)_(radio).mp3
bash: syntax error near unexpected token `(' (output from script)
mainstream@serotonin-pc:/media/500GB/music$ rename 's/\(radio\)/\(radio_edit\)/g' ghostface_killah-back_like_that_\(remix\)_\(ft._kanye_west_and_ne-yo\)_\(radio\).mp3 (this is how i want it)

do you what the best way is?

Thanks again!

kbp · 12-22-2010, 06:29 PM

Try single quotes around the file name