[SOLVED] If Statement

Almaz · 07-29-2013, 10:15 AM

I'm having a problem to use a simple if statement and I need a little directions. Already tried different ways but can't get it to work. Thanks in advance

mywhome=$(wl ssid | awk '{print $3}')
echo $mywhome ----> Returns "1homessid2"
if [ "$mywhome" == *homessid* ] ---> THAT'S A PROBLEM, PLEASE HELP
then
echo 1
else
echo 2
fi

Ser Olmy · 07-29-2013, 10:40 AM

Quote:

Originally Posted by Almaz

if [ "$mywhome" == *homessid* ] ---> THAT'S A PROBLEM, PLEASE HELP

It should be either

Code:

if [ "$mywhome" = *homessid* ]

or

Code:

if [[ "$mywhome" == *homessid* ]]

goumba · 07-29-2013, 10:41 AM

You must double the brackets.

Code:

mywhome=$(wl ssid | awk '{print $3}') 
echo $mywhome
if [[ "$mywhome" == *homessid* ]]
then
echo 1
else
echo 2
fi

Almaz · 07-29-2013, 10:55 AM

Thanks Goumba and Ser Olmy for your advice but I already tried these methods before. None of them works. I've already spent today over 2 hours on a simple line and I still can't get it to work. Any other suggestions?

linosaurusroot · 07-29-2013, 11:05 AM

You have not described in precise English what you intend to happen. I suspect you want a case statement.

Code:

case "$mywhome" in
*homessid*) echo 1;;
*) echo 2;;
esac

Firerat · 07-29-2013, 11:09 AM

This seems to work fine here

Code:

if [[ "$mywhome" = *homessid* ]];
then
    echo 1
else
    echo 2
fi

are you just missing the ;

alternative

Code:

$(echo $mywhome | grep -q homessid ) && echo 1 || echo 2

or even

Code:

wl ssid | grep -q homessid && echo 1 || echo 2

depending on what you are doing, you might find case more useful

Code:

mywhome=$(wl ssid | awk '{print $3}')
case $myhome in
    1homessid2) .. some actions;;
    2homessid1) .. some different actions;;
    randomSSID) .. some very different actions;;
             *) .. action for no match;;
esac

Almaz · 07-29-2013, 11:17 AM

Quote:

Originally Posted by linosaurusroot

You have not described in precise English what you intend to happen. I suspect you want a case statement.

Code:

case "$mywhome" in
*homessid*) echo 1;;
*) echo 2;;
esac

Well, I'm just doing a simple toggle script to rejoin from one network to another network. If & Else command should work just fine. Since I've already spent so much time on a single command line, I want to know why such a simple if command doesn't work. I'm sure something basic is missing. Here is my full script should look like, if it makes any difference.

mywhome=$(wl ssid | awk '{print $3}');
if [[ $mywhome =~ *ssai-i* ]]
then
led white off
led amber on
nvram set wl0_ssid=Wssai-iD
nvram set wl0_wpa_psk=11111111
service wl restart
service wan restart
else
led amber off
led white on
nvram set wl0_ssid=BssiD
nvram set wl0_wpa_psk=22222222
service wl restart
service wan restart
fi

Firerat · 07-29-2013, 11:22 AM

Code:

mywhome=$(wl ssid | awk '{print $3}');
if [[ $mywhome =~ *ssai-i* ]];
then
    led white off
    led amber on
    nvram set wl0_ssid=Wssai-iD
    nvram set wl0_wpa_psk=11111111
    service wl restart
    service wan restart
else
   led amber off
   led white on
   nvram set wl0_ssid=BssiD
   nvram set wl0_wpa_psk=22222222
   service wl restart
   service wan restart
fi

paste code in [code][/code]

Code:

it will
    preserve
           indents
and       such

goumba · 07-29-2013, 11:28 AM

Quote:

Originally Posted by Firerat

This seems to work fine here
...
are you just missing the ;

The semicolon is required if the entire statement was on a singe line. In the case of the posted script and following, it is not required.

Code:

if [ ... ]
then
...
fi

and

Code:

if [ ... ]; then ...; fi

Ser Olmy · 07-29-2013, 11:33 AM

Quote:

Originally Posted by Almaz

if [[ $mywhome =~ *ssai-i* ]]

*ssai-i* is not a valid regexp.

Or, it may be semi-valid, but "any number of occurences of nothing, followed by ssai-, followed by any number of i's" is probably not what you were aiming for.

Try .*ssai-i.* instead.

Almaz · 07-29-2013, 11:35 AM

Ok guys, can anybody get the output of this script to 1 instead of 2

mywhome=$(wl ssid | awk '{print $3}')
echo $mywhome ----> Returns "Test-Ssid"
if [[ "$mywhome" == *est-Ssi* ]] ---> THAT'S A PROBLEM, PLEASE HELP
then
echo 1
else
echo 2
fi

Always shows up as output 2.

Firerat · 07-29-2013, 11:37 AM

Quote:

Originally Posted by goumba

The semicolon is required if the entire statement was on a singe line. In the case of the posted script and following, it is not required.

oops,
not sure why but I have always done it like that

in that case, I have no idea why it is not working

Firerat · 07-29-2013, 11:40 AM

Quote:

Originally Posted by Almaz

Ok guys, can anybody get the output of this script to 1 instead of 2
>

Always shows up as output 2.

see Ser Olmy's post

Ser Olmy · 07-29-2013, 11:42 AM

Quote:

Originally Posted by Almaz

if [[ "$mywhome" == *est-Ssi* ]] ---> THAT'S A PROBLEM, PLEASE HELP

You can't match against a string using shell wildcards. Bash will expand *est-Ssi* to the names of any matching file names in the current directory, or leave it as is if no matching names exist. In either case, it isn't going to work.

Either match against a literal string, or use regexp matching:

Code:

if [[ "$mywhome" =~ .*est-Ssi.* ]]

(And as Firerat pointed out, do use [code] tags like I just did.)

Almaz · 07-29-2013, 11:49 AM

Quote:

Originally Posted by Ser Olmy

Either match against a literal string, or use regexp matching:

Code:

if [[ "$mywhome" =~ .*est-Ssi.* ]]

(And as Firerat pointed out, do use [code] tags like I just did.)

Just tested your way and got the output

Code:

[[: =~: unknown operand
2

When I get home today I'll try without dash. I'm guessing dash is killing everything.