Any help with this script?

grande25 · 10-20-2008, 03:44 PM

Hi! I'm running this script and it seems to "almost" work. It pings the IP address but when it gets a "1" condition it won't reboot like I want it to. Script:

ping -c 5 123.45.678.910
echo $?
if [ $? -ne 0 ] ; then shutdown -r -t 10 "now"
fi

That's it... I can run "shutdown -r -t 10 "now"" from the root and it works just fine.

Thanks!

arizonagroovejet · 10-20-2008, 03:59 PM

In your if condition, you're testing the exit status of the echo command. If you want to test the exit status of the ping command and display it, then assign the exit status to a variable, echo that and then test it.

Code:

ping 
foo=$?
echo $foo
if [ $foo -ne 0];then

GazL · 10-20-2008, 04:11 PM

Ahh, your echo command running before the if is setting $? to 0, so the if is always true. Remove the echo and it should work. (edit: I see Arizona beat me to it)

BTW, You could simplify it a little, no need for the if/test on $?

Code:

 
ping -c 5 123.45.678.910 || shutdown -t 10 -r now

salasi · 10-21-2008, 03:25 AM

This should make apparent one of the problems with cross-posting; you get two fragmented sets of answers. See http://www.linuxquestions.org/questi...script-677882/
And, of course, its against the forum rules.