Theme lacks close icon for some windows

A_UK_LinuxMintUser · 06-05-2017, 01:37 PM

I've looked at the thread you found - thanks.

I notice also that some bits of code in the theme's 'metacity-theme-1.xml' file are marked, rather worryingly, as 'to do'. I've noticed a fair amount of redundant and inconsistent white space in the metacity files too - but I doubt they are the problem.

EDIT: Also, is there any way to get any error messages generated by the theme? That would help!

hydrurga · 06-05-2017, 01:43 PM

Yay - got it!

muktupavels' first post in the thread I linked to provided the clue:

Quote:

Metacity themes are in control whether to show buttons or not. So proper solution is to update themes to stop hide buttons in dialogs, remove 'hide_buttons="true"' or change to false.

So, in the file ~/.themes/SimpleX-Blue/metacity-1/metacity-theme-3.xml, you need to edit hide_buttons="true" in line #81:

Code:

<frame_geometry name="modal" title_scale="small" hide_buttons="true" rounded_top_left="false" rounded_top_right="false" parent="small">

to hide_buttons="false"

Then save the file and reload the theme (switch into and back from another theme).

So the developers of those applications were correct. This is completely down to the theme specifically saying "don't display buttons for modal windows".

A_UK_LinuxMintUser · 06-05-2017, 01:45 PM

This sounds like the business. Unfortunately, I have to go out now but, when I get back, I'll give it a go. I am grateful and surprised and even almost touched by the work you have put into this. Thank you very much.

hydrurga · 06-05-2017, 01:47 PM

Quote:

Originally Posted by A_UK_LinuxMintUser

This sounds like the business. Unfortunately, I have to go out now but, when I get back, I'll give it a go. I am grateful and surprised and even almost touched by the work you have put into this. Thank you very much.

No problem. Let me know if it works for you when you get back to it.

A_UK_LinuxMintUser · 06-05-2017, 06:03 PM

It works. Thank you so much. If there's any interest, I'll post my version of the theme somewhere - a version that includes this fix, as well as mouse-over colour changing of the minimize, maximise and close icons. I do like this theme, because it is simple and clear.

hydrurga · 06-05-2017, 06:14 PM

Quote:

Originally Posted by A_UK_LinuxMintUser

It works. Thank you so much. If there's any interest, I'll post my version of the theme somewhere - a version that includes this fix, as well as mouse-over colour changing of the minimize, maximise and close icons. I do like this theme, because it is simple and clear.

It is indeed a nice theme. Why don't you try contacting nale12, given that the original theme is theirs, and look at options such as forking, taking the theme over if nale12 doesn't want to work on it any more, you both publishing an updated theme etc...

ondoho · 06-07-2017, 01:52 AM

^ yes i remember from my days on dA, it's considered the Right Thing to do, and the answer is usally "yes of course and thanks for asking".

but...
the license is most probably already on the theme's page, or in the package.