SlackwareThis Forum is for the discussion of Slackware Linux.
Notices
Welcome to LinuxQuestions.org, a friendly and active Linux Community.
You are currently viewing LQ as a guest. By joining our community you will have the ability to post topics, receive our newsletter, use the advanced search, subscribe to threads and access many other special features. Registration is quick, simple and absolutely free. Join our community today!
Note that registered members see fewer ads, and ContentLink is completely disabled once you log in.
If you have any problems with the registration process or your account login, please contact us. If you need to reset your password, click here.
Having a problem logging in? Please visit this page to clear all LQ-related cookies.
Get a virtual cloud desktop with the Linux distro that you want in less than five minutes with Shells! With over 10 pre-installed distros to choose from, the worry-free installation life is here! Whether you are a digital nomad or just looking for flexibility, Shells can put your Linux machine on the device that you want to use.
Exclusive for LQ members, get up to 45% off per month. Click here for more info.
This is a thread aimed at fixing SlackBuilds in SBO that are currently having any build issues and need repairs, fixes, patches, etc. Try to stick to the current format.
This post is only to fix and repair existing SlackBuild script, not get newer versions of packages.
THIS THREAD IS AIMED AT -CURRENT USAGE with resyncs from the SBo master repo via git/svn. Stable releases should be okay, unless otherwise noted.
--------------------- TiMidity++.SlackBuild
---------------------
line 96
autoreconf > ./autogen.sh
Original command returns an error when ran.
-------------------------- gst-plugins-bad.SlackBuild
--------------------------
line 87(+88)
make install DESTDIR=$PKG
> cp -v $PKG/usr/include/libmodplug/stdafx.h $PKG/usr/include/stdafx.h
when building gst-plugins-bad against libmodplug, compiler generates stop error stating stdafx.h was not found.
-Current at the moment. New versions of tool sets may be producing problems that may need to start getting tracked. Plus I'm using sbotools to manage the SBo packages which stays in sync with the git/svn SBO repo.
Yes, we are aware of new toolchain that might break some scripts in SBo, but since -current is not officially supported, it will be fixed during the time when next Slackware is about to be released
ReaperX7: I think the problem you attribute to gst-plugins-bad is instead of libmodplug that seems to have a wrong path for its own includes in its pkgconfig file: this patch for the SlackBuild fixes it.
I'll send it to Larry, the libmodplug maintainer too, as it applies to stable too: if it's ok for him I'll send the fix also upstream.
BTW, thanks for reporting the issue!
Code:
From 6fc93b2a34d46ada1faa10cb86cef496e2e1fb61 Mon Sep 17 00:00:00 2001
From: Matteo Bernardini <ponce@slackbuilds.org>
Date: Tue, 3 Feb 2015 16:27:32 +0100
Subject: [PATCH] libraries/libmodplug: Fix includes location in the pkgconfig
file.
Signed-off-by: Matteo Bernardini <ponce@slackbuilds.org>
---
libraries/libmodplug/libmodplug.SlackBuild | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libraries/libmodplug/libmodplug.SlackBuild b/libraries/libmodplug/libmodplug.SlackBuild
index 9570bb4..df39b69 100644
--- a/libraries/libmodplug/libmodplug.SlackBuild
+++ b/libraries/libmodplug/libmodplug.SlackBuild
@@ -24,7 +24,7 @@
PRGNAM=libmodplug
VERSION=${VERSION:-0.8.8.5}
-BUILD=${BUILD:-1}
+BUILD=${BUILD:-2}
TAG=${TAG:-_SBo}
if [ -z "$ARCH" ]; then
@@ -71,6 +71,9 @@ find -L . \
patch -p1 < $CWD/libmodplug-0.8.4-timiditypaths.patch
+# Fix the location of the includes in the pkgconfig file
+sed -i "s|includedir}$|includedir}/libmodplug|" libmodplug.pc.in
+
CFLAGS="$SLKCFLAGS" \
CXXFLAGS="$SLKCFLAGS" \
./configure \
--
2.2.2
If I find more problems, and honestly if anyone finds any problems, this topic could be used as a good starting point to finding the real issues at hand, or just rework things as needed to work better.
Because SBO is community, and most of you guys post here that contribute to SBO, maybe this can be a little bit of help.
The faster things can be found, the faster things can be fixed, patched, etc. upstream.
The slackbuild for lua52 has problems when run using fakeroot. I reported the problem to ponce by email some time ago, but I never received a reply. I think it would be interesting to fix it.
re-reading my answer I think that, aided by my bad english, I may have sounded rude: it wasn't my intention at all, I hope you understand
consider that I'm still thinking, when I'll find enough spare time to test stuff depending on it too, of reworking lua build scripts for trying to have multiple lua version installed together: it could be that the new ones will accidentally work also with fakeroot, who knows!
ReaperX7: I think the problem you attribute to gst-plugins-bad is instead of libmodplug that seems to have a wrong path for its own includes in its pkgconfig file: this patch for the SlackBuild fixes it.
I'll send it to Larry, the libmodplug maintainer too, as it applies to stable too: if it's ok for him I'll send the fix also upstream.
BTW, thanks for reporting the issue!
Code:
From 6fc93b2a34d46ada1faa10cb86cef496e2e1fb61 Mon Sep 17 00:00:00 2001
From: Matteo Bernardini <ponce@slackbuilds.org>
Date: Tue, 3 Feb 2015 16:27:32 +0100
Subject: [PATCH] libraries/libmodplug: Fix includes location in the pkgconfig
file.
Signed-off-by: Matteo Bernardini <ponce@slackbuilds.org>
---
libraries/libmodplug/libmodplug.SlackBuild | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libraries/libmodplug/libmodplug.SlackBuild b/libraries/libmodplug/libmodplug.SlackBuild
index 9570bb4..df39b69 100644
--- a/libraries/libmodplug/libmodplug.SlackBuild
+++ b/libraries/libmodplug/libmodplug.SlackBuild
@@ -24,7 +24,7 @@
PRGNAM=libmodplug
VERSION=${VERSION:-0.8.8.5}
-BUILD=${BUILD:-1}
+BUILD=${BUILD:-2}
TAG=${TAG:-_SBo}
if [ -z "$ARCH" ]; then
@@ -71,6 +71,9 @@ find -L . \
patch -p1 < $CWD/libmodplug-0.8.4-timiditypaths.patch
+# Fix the location of the includes in the pkgconfig file
+sed -i "s|includedir}$|includedir}/libmodplug|" libmodplug.pc.in
+
CFLAGS="$SLKCFLAGS" \
CXXFLAGS="$SLKCFLAGS" \
./configure \
--
2.2.2
I've talked to ponce in a separate email about gst-plugins-bad. The issue is that the version of gst-plugins-bad on SBo doesn't use include statements correctly like the gst-plugins-bad 1.x version does. I sent ponce a patch so that gst-plugins-bad can compile with libmodplug.
LinuxQuestions.org is looking for people interested in writing
Editorials, Articles, Reviews, and more. If you'd like to contribute
content, let us know.