All,

Thanks to rworkman thrice` and FreeNode ##slackware in general.

Here is a memory leak bug from Slackware 12.1. It was accidentally incorrectly patched in xfce.SlackBuild and also failed to patch another memory leak found after it was rolled into a package. Basically, xfdesktop has two memory leaks in 4.4.2 that were reported to XFCE's bug tracking and patched in Debian (thanks Debian team!). The one leak not accounted for was the one in xfdesktop's menu-spec.

I rolled a new xfce.SlackBuild with help from rworkman and built it. It works fine and so far xfdesktop is not hogging triple-digit MB of virtual RAM in top any more, so it appears to have worked very well (since xfdesktop was only up for a week last time, and as of now it's been up almost 24 hours). Changes: added patch file and patch logic for the other memory leak, and fixed the patch command (-p0 not -p1) for the first memory leak.

So here are the files:

http://www.puresimplicity.net/~twinr...fce.SlackBuild

http://www.puresimplicity.net/~twinr...nuspec.diff.gz

Thanks!

Very respectfully,

Robert Delahunt (aka TwinReverb)

(will get submitted to a.o.l.s)

Thanks for sharing!
Although I did not notice memory leak for my part, I use xfce everyday
(but I have to say I have not used big x apps since I upgraded to Slackware 12.1 and I power off my computer every night)

[edit]
Slight error in slackbuild script:

./xfce.SlackBuild: line 143: syntax error near unexpected token `)'
./xfce.SlackBuild: line 143: ` ) || exit 1'

In fact it is a "fi" on line 97 that should be put on next line

I think that leak has been there for a while, I noticed while using Zenwalk quite some time ago. Or are there multiple leaks. Or has someone taken a shotgun to the rodent and now you can never stop the leaking ?

The issue has already been addressed in Slackware-current - see today's ChangeLog entry of Thu Sep 18 01:54:28 CDT 2008

Eric

Yeah, I'm Robert Delahunt

Tell Patrick I appreciate him mentioning me (although it wasn't necessary). All I really did was gripe about memory usage in IRC, and someone pointed out the patches, and then I did a tiny amount of research and a tiny amount of work (with rworkman and thrice` helping) to get it working. So basically all I did was gripe until a solution presented itself

Also, I thank the #xfce guys for putting up with my gripe and pointing the patches out