Request for Testing: bash-completion 2.0

rworkman · 11-06-2011, 03:17 PM

For everyone that uses the bash-completion package from /extra, please have a look at http://connie.slackware.com/~rworkman/bash-completion/ and consider testing the 2.0 prerelease (1.90 at the moment). Be sure to read over the README in there.

sahko · 11-06-2011, 04:21 PM

Besides the mentioned in the README improvements regarding pkgtools and slackpkg etc, theres also a new completion for sbopkg.

Quote:

[ Sergey V ]
* New completions: sbopkg

audriusk · 11-07-2011, 03:41 PM

Hey, Robby,

Have been using completion for various stuff all day with your package installed, haven't noticed any problems.

escaflown · 11-07-2011, 07:08 PM

working fine here too

eddyvp · 11-08-2011, 01:12 PM

seems to work allright

disturbed1 · 11-10-2011, 05:35 AM

Breaks tab completion.

Code:

removepkg /var/log/pa{tab}ckages [space]

should be 

removepkg /var/log/pa{tab}ckages/

---edit---
Well, I have to use it differently

removepkg kde{tab} <--- completes as I'd expect removepkg /var/log/packages/kde{tab}

rworkman · 11-10-2011, 05:21 PM

Thanks for the feedback, guys - it's much appreciated.
Re the /var/log/packages/ tab completion (added space), I too have noticed that, but I also work around it by using the completion as intended. I guess it's arguable whether that's even a bug...

_GArik_ · 11-10-2011, 05:51 PM

This should be fixed now in the master branch of bash-completion with this commit. If there is a slash somewhere in argument to removepkg, completion assumes that user tries to enter a filename.

> I guess it's arguable whether that's even a bug...

Completing filenames is not very useful, but sometimes it can be more desirable. For example, this way you can remove kde with one command

$ removepkg /srv/ftp/slackware/{kde,kdei}/*.txz

rworkman · 11-10-2011, 07:17 PM

Awesome; thanks, GArik

I just pushed a package rebuild with that patch.

audriusk · 11-11-2011, 09:32 AM

Found a bug, just not sure if it happens only after package rebuild or it was there right from the start (I'll try to rebuild without the last patch). Here's how to reproduce:

Code:

$ touch foo\(bar\).txt
$ mv fo<TAB> fo<TAB>

The second attempt to complete does nothing. Happens only with files which have parentheses in their names.

audriusk · 11-11-2011, 09:50 AM

Nope, still the same without the last patch. Also it seems that it's the escaping that's causing this, not the parens themselves (the bug occurs with escaped space characters etc).

_GArik_ · 11-11-2011, 03:03 PM

This is a known issue. Completion fails if there are sequential duplicate items in a list of arguments. It is unlikely that this bug will be fixed before release of bash-completion-2.0

_GArik_ · 11-17-2011, 08:56 AM

Audrius, your issue is fixed now in the master branch. There is also one new slackware related improvement: completion for upgradepkg now supports "oldpkg%newpkg" notation

audriusk · 11-17-2011, 12:37 PM

This is great! Made a package using code from master branch, installed it, and indeed that pesky bug is gone. Thanks!

oldpkg%newpkg completion is a nice addition, too.

rworkman · 11-17-2011, 01:15 PM

I just uploaded a rebuilt package with those patches :-)