LinuxQuestions.org
Visit Jeremy's Blog.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices

Reply
 
Search this Thread
Old 08-06-2013, 07:22 PM   #1
Sl4ck3ver
LQ Newbie
 
Registered: Aug 2013
Posts: 4

Rep: Reputation: Disabled
Please upgrade util-linux ("partx" e.g. is badly broken)


Hi all!

Some times ago I learned the hard way that the partx utility included in util-linux is really broken.

Offset and length of every partition entry added to the kernel tables is silently truncated to 4GB (in 32 bit archs) because of a wrong data type ("unsigned long") used in the declaration of "partx_add_partition".

This together with lots of other things was fixed some times ago during a major internal redesign of the tools.

It surely needs a little bit of attention and testing but I think it is really necessary to upgrade this essential package before 14.1.

For everyone who is also affected by this bug but don't want to upgrade the whole package, here is a diff:

Code:
--- ./partx/partx.h
+++ ./partx/partx.h
@@ -23,7 +23,7 @@
 }
 
 static inline int partx_add_partition(int fd, int partno,
-			unsigned long start, unsigned long size)
+			long long start, long long size)
 {
 	struct blkpg_ioctl_arg a;
 	struct blkpg_partition p;

Now I really wish one of the slackware gurus reads this...

Greetings!
 
Old 08-06-2013, 08:10 PM   #2
volkerdi
Slackware Maintainer
 
Registered: Dec 2002
Location: Minnesota
Distribution: Slackware! :-)
Posts: 867

Rep: Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743Reputation: 1743
Quote:
Originally Posted by Sl4ck3ver View Post
This together with lots of other things was fixed some times ago during a major internal redesign of the tools.
Unfortunately, that major internal redesign brings many major new bugs. Especially in "mount".

Quote:
It surely needs a little bit of attention and testing but I think it is really necessary to upgrade this essential package before 14.1.
The plan right now is not to do an upgrade before 14.1, but I'll take a look at that bug (or any other specific bugs you'd like to point out).
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
How might I restore kmail folders/mail/settings from a "badly" saved "home"? deh6 Linux - Software 5 03-08-2008 09:25 PM
"Broken" envirnment variable (MANPATH) and "/etc/profile.d" question. ErV Slackware 3 03-20-2007 09:42 AM
KPrinter broken by KDE upgrade? (3.3.2 level "a") naps Suse/Novell 2 03-16-2005 12:30 PM


All times are GMT -5. The time now is 11:34 PM.

Main Menu
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
identi.ca: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration